Compare commits

...
Sign in to create a new pull request.

7 commits

95 changed files with 13159 additions and 6544 deletions

View file

@ -36,6 +36,9 @@ CALLBACK_BASE_URL=http://api:8000
# Shared secret for flow callbacks (POST /api/approvals carries it as # Shared secret for flow callbacks (POST /api/approvals carries it as
# X-Callback-Token). Long random value; empty disables callbacks. # X-Callback-Token). Long random value; empty disables callbacks.
CALLBACK_TOKEN= CALLBACK_TOKEN=
# Secret signing stateless session JWTs (HS256). Long random value
# (openssl rand -hex 32); empty fails closed at login time.
JWT_SECRET=
# --- frontend mode: unset/preview serves the production bundle --- # --- frontend mode: unset/preview serves the production bundle ---
# Dev sets FRONTEND_MODE=dev (HMR); .devcontainer/setup.sh provisions it. # Dev sets FRONTEND_MODE=dev (HMR); .devcontainer/setup.sh provisions it.

View file

@ -5,6 +5,55 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased] ## [Unreleased]
### Changed
- Declutter: shared `BaseApiClient` (LFX/Langflow) with tenacity transport retry, single `get_db`, `model_validate` mappers, unified LFX/Langflow error mapping, stream logic moved to `runner.py`, `sync_full_pass` single orchestration (API+CLI), shared model base (`utcnow`/`ts_column`), unified auth counters, `httpx` in `deploy_flow.py`, atomicwrites file writes, `secure`-package headers.
- Auth: stateless JWT sessions (HS256, 7d, HttpOnly cookie unchanged) replace the `user_sessions` table (Alembic revision drops it; all sessions invalidated at deploy); slowapi run throttle replaces the hand-rolled sliding window; mail via jinja template + fastapi-mail (same copy/fallback contract); CLIs on typer; `JWT_SECRET` enforced by `check_prod.py`.
- Forms: thin variant components over shared `components/kirche/_form_core.py` (codegen-inlined by `kirche_node()` for LFX; all 5 flows regenerated + level-4 validated), structured `visible_if` key alongside legacy markers, `LangflowClient.upsert_flow` + `scripts/push_flows_to_langflow.py` (6 canonical flows pushed to Langflow UI).
- Store/sync: single `next_version_no` query per version, validation only at the `create_version` choke point, mtime-cached `.flowsignore`.
- Fix batch: typer CLIs exit non-zero via `typer.Exit` (`check_prod` gate works again); JWT expiry 7d with startup warning and new expiry/deleted-user tests; deleted dead `resolve_tenant`, test alias helpers now delegate to `conftest` (flows/approvals/sync/deploy suites migrated to shared fixtures); `AdminTab` reads via react-query; Mantine aligned to 9.6.3 (consistent lockfile, `npm ci` green).
- Removed `backend/flows/test_flow.json` (legacy Message-shape demo, superseded by `intake_form.json`; Langflow copy deleted first, sync cascades runs by design); `FlowVersion.input_schema` is now NOT NULL (backfill migration); `smoke_e2e.py` reuses `tests/_harness.py` and runs green; `FlowHelp` docs moved to `docs/flow-authoring.md`; shared `StatusBadge` status union, single `RunsTable`, `photos.css` class via one constant.
- Tests (full real LFX kept): shared `conftest` helpers + `tests/_harness.py` adopted by fixtures and smoke script, parametrized matrices (export stems, check_prod env, deploy failures, sync listing failures, API auth probes, input_schema types), relaxed brittle asserts (ui:order sets, per-flag cookie asserts, SSE any-match).
- Frontend: react-query reads + notifications, `useForm`+zod static forms, shared `DecisionButtons`/`ErrorAlert`/`JsonView`/`FormattedDate`/`RunsTable`/`Landing` blocks, new aggregate `GET /api/runs` kills the Tasks N+1, `Promise.all` version fetches, `sharp` icons, selector-based screenshots, dead photo removed.
### Added
- Aggregate `GET /api/runs` (tenant-scoped runs with flow names, single query).
- Branched questionnaires: `[visible_if feld=Wert]` markers in a
`CustomInputForm` field's `info` (code editor) show the field only when
the condition holds — nested to any depth, with `&` for AND conditions
and quotes for values with spaces. The parser emits `allOf`/`if`/`then`
branches (branch-scoped `required`, template-order placement); unknown
triggers, cycles, and unsupported trigger types fail open (always
visible). New demo flow `bauvorhaben.json` (4 levels + sibling branch +
bool trigger). Values of hidden fields are kept and submitted.
- Run envelope carries the asked field names (`fields`, from the
version's form schema): `collect()` emits defaults only for asked
AND currently visible fields (hidden branch fields stay out, like the
frontend never submits them), so templates may declare fields unknown
to the component code and unasked code defaults stay out of the run
output. Without the list (raw dicts, Langflow playground) all visible
declared defaults apply.
- Standalone `CustomInputBauvorhaben` component ("Bauvorhaben Form" in
the kirche palette, zero shared code with `CustomInputForm` — the LFX
runtime executes embedded module source without our package); the
bauvorhaben flow uses it, and Langflow no longer normalizes the node
back to the default form on import.
- Form parser also recognizes user-built `CustomComponent` nodes whose
display name ends with `"Form"` (e.g. Mitarbeiter Einstellen Form) —
same template contract, no kirche base needed.
- Standalone `CustomInputMitarbeiter` component ("Mitarbeiter Einstellen
Form") with hiring flow incl. Gehaltsrechner, rebuilt generator-owned.
- Admin flow table shows one row per flow (latest version, with live
version note when an older version is deployed) instead of one row
per version.
- Step-by-step guide for new workflow modules: `docs/new_workflow_module.md`
(linked from README).
### Changed
- `CustomInputForm.collect()` is now dynamic and returns `Data` (JSON)
instead of `Message`: fields can be renamed, added, or removed in the
Langflow code editor with no `collect()` change, and values travel as a
real JSON object. The form parser keeps `name` keys verbatim (empty
names skipped, collisions suffixed) and the run envelope merges unknown
keys. Note: a terminal `ChatOutput` renders `Data` as a fenced ```json
block, and downstream components should read `.data`, not `.text`.
### Added ### Added
- Flow-Sync ist jetzt ein manueller Full-Pass: `POST /api/flows/sync` - Flow-Sync ist jetzt ein manueller Full-Pass: `POST /api/flows/sync`
(Button "Aus Langflow synchronisieren" in der Verwaltung) holt erst alle (Button "Aus Langflow synchronisieren" in der Verwaltung) holt erst alle

View file

@ -24,9 +24,12 @@ needs judgment. Every step is documented and traceable.
can automatically start a follow-up ("continuation") flow. can automatically start a follow-up ("continuation") flow.
- **Access management** — public landing page (German) with an access-request - **Access management** — public landing page (German) with an access-request
form (request + approval). Approved users get a passwordless magic-link form (request + approval). Approved users get a passwordless magic-link
invite by email (SMTP via `.env`); sessions are HttpOnly cookies, tenants invite by email (SMTP via `.env`); sessions are stateless JWTs (HS256,
come from the session. First admin via `POST /api/auth/admin-bootstrap` 7-day expiry) in HttpOnly cookies — no server-side revocation, logout
(only on an empty user table, email must be in `ADMIN_EMAILS`). clears the cookie, deleted users fail closed. Tenants come from the
session. `JWT_SECRET` (long random value) signs the cookies. First admin
via `POST /api/auth/admin-bootstrap` (only on an empty user table, email
must be in `ADMIN_EMAILS`).
- **Dynamic forms** — flows declare form fields as typed inputs on a - **Dynamic forms** — flows declare form fields as typed inputs on a
`CustomInput*` custom component (reusable library in `CustomInput*` custom component (reusable library in
`backend/components/`, mounted into Langflow via `backend/components/`, mounted into Langflow via
@ -125,6 +128,8 @@ Frontend (node lives in the `frontend` container):
running via compose; this is for a second instance or flags). running via compose; this is for a second instance or flags).
- `docker compose exec frontend npm run build` — typecheck + build. - `docker compose exec frontend npm run build` — typecheck + build.
- Without a docker socket: VS Code "Attach to Running Container" → frontend. - Without a docker socket: VS Code "Attach to Running Container" → frontend.
- Local `npm install`: use `--legacy-peer-deps` (Mantine 9 + React 19
peer range); `npm ci` inside the image works off the committed lockfile.
Flow workflow: design in Langflow → press "Aus Langflow synchronisieren" Flow workflow: design in Langflow → press "Aus Langflow synchronisieren"
in Verwaltung (manual full pass: Langflow → `backend/flows/<name>.json` → in Verwaltung (manual full pass: Langflow → `backend/flows/<name>.json` →
@ -133,6 +138,14 @@ DB + LFX deploy) → commit. File-only alternatives: `scripts/sync_flows.py
watcher deploys file edits automatically. Deleting a file removes the flow watcher deploys file edits automatically. Deleting a file removes the flow
including its runs (git keeps the JSON). including its runs (git keeps the JSON).
New workflow module? Step-by-step guide: `docs/new_workflow_module.md`.
Pull safety: sync matches Langflow flows to files **by name** and
overwrites silently — renaming or repurposing a flow in Langflow (or a
duplicate with the same name) lands in the matched file. Commit before
syncing and review the `pulled` report with `git diff`; uncommitted
work in `backend/flows/` can be overwritten.
## Production (self-hosted — TLS/reverse proxy required, not included) ## Production (self-hosted — TLS/reverse proxy required, not included)
1. Check out the repo on the host, create `.env` from `.env.example` with 1. Check out the repo on the host, create `.env` from `.env.example` with
@ -152,7 +165,9 @@ proxy — nothing here substitutes for it):
critical unauthenticated RCEs — treat its UI as privileged tooling, critical unauthenticated RCEs — treat its UI as privileged tooling,
never share flows publicly ("Shareable Playground" = RCE risk). never share flows publicly ("Shareable Playground" = RCE risk).
- Secrets: all `*_KEY`/`*_TOKEN`/`*_PASSWORD` long and random; rotate - Secrets: all `*_KEY`/`*_TOKEN`/`*_PASSWORD` long and random; rotate
after any incident or staff change; re-run `check_prod.py`. after any incident or staff change; re-run `check_prod.py`. `JWT_SECRET`
signs session cookies — rotating it logs everyone out (same on every
deploy that drops session state: users re-login via magic link).
- Langflow/LFX upgrades (pinned in lockstep): bump `LANGFLOW_VERSION` - Langflow/LFX upgrades (pinned in lockstep): bump `LANGFLOW_VERSION`
(`.env`), `Dockerfile.lfx` ARG, and backend `lfx~=` together, then (`.env`), `Dockerfile.lfx` ARG, and backend `lfx~=` together, then
`lfx upgrade --upgrade-flow=safe` + `lfx validate --level 4` on `lfx upgrade --upgrade-flow=safe` + `lfx validate --level 4` on

View file

@ -6,16 +6,11 @@ from uuid import UUID
from fastapi import APIRouter, Depends, HTTPException, Query, Request, Response from fastapi import APIRouter, Depends, HTTPException, Query, Request, Response
from sqlmodel import Session from sqlmodel import Session
from app.db import get_db
from app.models import User from app.models import User
from . import mail, service from . import mail, service
from .deps import ( from .deps import SESSION_COOKIE, SESSION_MAX_AGE, get_current_user, require_admin
SESSION_COOKIE,
SESSION_MAX_AGE,
get_current_user,
get_db,
require_admin,
)
from .schemas import ( from .schemas import (
AccessDecisionRead, AccessDecisionRead,
AccessRequestCreate, AccessRequestCreate,
@ -33,26 +28,11 @@ auth_router = APIRouter(prefix="/api/auth", tags=["auth"])
def _read_request(r) -> AccessRequestRead: def _read_request(r) -> AccessRequestRead:
return AccessRequestRead( return AccessRequestRead.model_validate(r, from_attributes=True)
id=r.id,
name=r.name,
email=r.email,
reason=r.reason,
status=r.status,
created_at=r.created_at,
decided_at=r.decided_at,
decided_by=r.decided_by,
)
def _read_me(user: User) -> MeRead: def _read_me(user: User) -> MeRead:
return MeRead( return MeRead.model_validate(user, from_attributes=True)
id=user.id,
email=user.email,
name=user.name,
role=user.role,
tenant_id=user.tenant_id,
)
def _set_session_cookie(response: Response, session_id: str) -> None: def _set_session_cookie(response: Response, session_id: str) -> None:
@ -146,17 +126,14 @@ def consume_magic(
session: Annotated[Session, Depends(get_db)], session: Annotated[Session, Depends(get_db)],
): ):
try: try:
user_session = service.consume_magic_token(session, data.token) user, session_token = service.consume_magic_token(session, data.token)
except ( except (
service.InvalidTokenError, service.InvalidTokenError,
service.ExpiredTokenError, service.ExpiredTokenError,
service.UsedTokenError, service.UsedTokenError,
) as exc: ) as exc:
raise HTTPException(status_code=400, detail=str(exc)) from exc raise HTTPException(status_code=400, detail=str(exc)) from exc
user = service.get_user(session, user_session.user_id) _set_session_cookie(response, session_token)
if user is None: # pragma: no cover - consume already validated the user
raise HTTPException(status_code=400, detail="unknown token")
_set_session_cookie(response, user_session.id)
return _read_me(user) return _read_me(user)
@ -171,11 +148,8 @@ def logout(
response: Response, response: Response,
session: Annotated[Session, Depends(get_db)], session: Annotated[Session, Depends(get_db)],
): ):
# Revoke the server-side row when the cookie maps to a live session; # Stateless sessions: nothing server-side to revoke — always clear
# always clear the client cookie. # the client cookie.
session_id = request.cookies.get(SESSION_COOKIE)
if session_id:
service.revoke_session(session, session_id)
response.delete_cookie(SESSION_COOKIE, path="/") response.delete_cookie(SESSION_COOKIE, path="/")
return MessageRead(message="logged out") return MessageRead(message="logged out")

View file

@ -1,14 +1,13 @@
"""Session-cookie dependencies. Handlers stay thin; DB via get_session.""" """Session-cookie dependencies. Handlers stay thin; DB via app.db.get_db."""
from __future__ import annotations from __future__ import annotations
from collections.abc import Iterator
from typing import Annotated from typing import Annotated
from fastapi import Depends, HTTPException, Request from fastapi import Depends, HTTPException, Request
from sqlmodel import Session from sqlmodel import Session
from app.db import get_session from app.db import get_db
from app.models import User from app.models import User
from . import service from . import service
@ -17,20 +16,13 @@ SESSION_COOKIE = "kirche_session"
SESSION_MAX_AGE = int(service.SESSION_TTL.total_seconds()) SESSION_MAX_AGE = int(service.SESSION_TTL.total_seconds())
def get_db() -> Iterator[Session]:
yield from get_session()
def get_optional_user( def get_optional_user(
request: Request, session: Annotated[Session, Depends(get_db)] request: Request, session: Annotated[Session, Depends(get_db)]
) -> User | None: ) -> User | None:
session_id = request.cookies.get(SESSION_COOKIE) token = request.cookies.get(SESSION_COOKIE)
if not session_id: if not token:
return None return None
record = service.get_valid_session(session, session_id) return service.get_token_user(session, token)
if record is None:
return None
return service.get_user(session, record.user_id)
def get_current_user(request: Request, session: Annotated[Session, Depends(get_db)]) -> User: def get_current_user(request: Request, session: Annotated[Session, Depends(get_db)]) -> User:
@ -44,11 +36,3 @@ def require_admin(user: Annotated[User, Depends(get_current_user)]) -> User:
if user.role != "admin": if user.role != "admin":
raise HTTPException(status_code=403, detail="admin only") raise HTTPException(status_code=403, detail="admin only")
return user return user
def resolve_tenant(user: User | None, explicit: str | None, default: str = "default") -> str:
"""Tenant comes from the session; the body/query param is a deprecated
fallback for unauthenticated callers."""
if user is not None:
return user.tenant_id
return explicit or default

View file

@ -9,8 +9,10 @@ fonts, no external images (many clients block them / track opens).
from __future__ import annotations from __future__ import annotations
import logging import logging
import smtplib
from email.message import EmailMessage from email.message import EmailMessage
from pathlib import Path
from jinja2 import Template
from app.settings import settings from app.settings import settings
@ -22,10 +24,15 @@ BLUE_LIGHT = "#eef4fb"
INK = "#162f4c" INK = "#162f4c"
MUTED = "#5b6b7c" MUTED = "#5b6b7c"
BLUE = "#1d4a79" _TEMPLATE_PATH = Path(__file__).resolve().parent / "templates" / "magic_link.html"
BLUE_LIGHT = "#eef4fb" _template_cache: Template | None = None
INK = "#162f4c"
MUTED = "#5b6b7c"
def _template() -> Template:
global _template_cache
if _template_cache is None:
_template_cache = Template(_TEMPLATE_PATH.read_text(encoding="utf-8"))
return _template_cache
def magic_link(token: str) -> str: def magic_link(token: str) -> str:
@ -33,61 +40,46 @@ def magic_link(token: str) -> str:
def _page(title: str, intro: str, button_label: str, button_url: str | None, note: str) -> str: def _page(title: str, intro: str, button_label: str, button_url: str | None, note: str) -> str:
"""Branded HTML mail body (table layout, inline styles, no images).""" """Branded HTML mail body (jinja template, byte-identical to the old f-string)."""
button = "" return _template().render(
if button_url: title=title,
button = ( intro=intro,
'<table role="presentation" cellpadding="0" cellspacing="0" ' button_label=button_label,
'style="margin:24px auto 8px auto;"><tr>' button_url=button_url,
f'<td bgcolor="{BLUE}" style="border-radius:8px;">' note=note,
f'<a href="{button_url}" ' blue=BLUE,
'style="display:inline-block;padding:12px 28px;font-family:-apple-system,' blue_light=BLUE_LIGHT,
"Segoe UI,Roboto,Helvetica,Arial,sans-serif;font-size:15px;" ink=INK,
"font-weight:600;color:#ffffff;text-decoration:none;" muted=MUTED,
f'border-radius:8px;">{button_label}</a></td></tr></table>' )
)
return f"""<!DOCTYPE html>
<html lang="de">
<body style="margin:0;padding:0;background-color:{BLUE_LIGHT};">
<table role="presentation" width="100%" cellpadding="0" cellspacing="0"
style="background-color:{BLUE_LIGHT};padding:24px 12px;">
<tr><td align="center">
<table role="presentation" width="520" cellpadding="0" cellspacing="0"
style="max-width:520px;width:100%;font-family:Georgia,'Times New Roman',serif;
border-radius:12px;overflow:hidden;border:1px solid #d9e6f5;">
<tr>
<td bgcolor="{BLUE}" style="padding:20px 28px;">
<span style="color:#ffffff;font-size:18px;font-weight:700;
letter-spacing:0.02em;">Kirche Einfach</span>
</td>
</tr>
<tr>
<td bgcolor="#ffffff" style="padding:28px 28px 24px 28px;">
<h1 style="margin:0 0 12px 0;font-size:22px;line-height:1.3;
color:{INK};">{title}</h1>
<p style="margin:0;font-family:-apple-system,Segoe UI,Roboto,
Helvetica,Arial,sans-serif;font-size:15px;line-height:1.6;
color:{MUTED};">{intro}</p>
{button}
</td>
</tr>
</table>
<p style="font-family:-apple-system,Segoe UI,Roboto,Helvetica,Arial,sans-serif;
font-size:12px;color:{MUTED};margin:16px 0 0 0;max-width:520px;">
{note}
</p>
</td></tr>
</table>
</body>
</html>"""
def _send(message: EmailMessage) -> None: def _send(message: EmailMessage) -> None:
with smtplib.SMTP(settings.smtp_host, settings.smtp_port, timeout=10) as smtp: """Deliver via fastapi-mail (same never-raise contract at call sites)."""
smtp.starttls() import asyncio
if settings.smtp_username:
smtp.login(settings.smtp_username, settings.smtp_password) from fastapi_mail import ConnectionConfig, FastMail, MessageSchema, MessageType
smtp.send_message(message)
config = ConnectionConfig(
MAIL_USERNAME=settings.smtp_username,
MAIL_PASSWORD=settings.smtp_password,
MAIL_FROM=settings.mail_from or settings.contact_to or message["To"],
MAIL_PORT=settings.smtp_port,
MAIL_SERVER=settings.smtp_host,
MAIL_STARTTLS=True,
MAIL_SSL_TLS=False,
USE_CREDENTIALS=bool(settings.smtp_username),
)
html = message.get_body(preferencelist=("html",))
plain = message.get_body(preferencelist=("plain",))
outgoing = MessageSchema(
subject=str(message["Subject"]),
recipients=[str(message["To"])],
body=plain.get_content() if plain else "",
html=html.get_content() if html else "",
subtype=MessageType.html,
)
asyncio.run(FastMail(config).send_message(outgoing))
def _branded_mail( def _branded_mail(
@ -147,7 +139,7 @@ def send_magic_link(to_email: str, link: str) -> bool:
) )
try: try:
_send(message) _send(message)
except (OSError, smtplib.SMTPException): except Exception: # noqa: BLE001 -- never-raise contract: delivery must not 500
logger.warning("magic-link delivery failed for %s", to_email) logger.warning("magic-link delivery failed for %s", to_email)
return False return False
logger.info("magic link mailed to %s", to_email) logger.info("magic link mailed to %s", to_email)
@ -172,7 +164,7 @@ def send_access_notification(request_id: str, name: str, email: str) -> bool:
) )
try: try:
_send(message) _send(message)
except (OSError, smtplib.SMTPException): except Exception: # noqa: BLE001 -- best-effort notification, never raises
logger.warning("access-request notification failed for %s", request_id) logger.warning("access-request notification failed for %s", request_id)
return False return False
return True return True

View file

@ -1,7 +1,13 @@
"""Access requests, magic-link tokens, and sessions (DB via function args). """Access requests, magic-link tokens, and stateless JWT sessions.
Keep API handlers thin: all persistence lives here. Tokens and session ids Keep API handlers thin: all persistence lives here. Tokens and session
are bearer secrets — log user/request ids only, never secret values. JWTs are bearer secrets — log user/request ids only, never secret values.
Sessions are stateless HS256 JWTs (sub=user.id, email, role, tenant_id,
iat, exp=7d, jti) in the HttpOnly session cookie. No session table and no
revocation list: logout clears the cookie client-side, and a stolen token
is valid until its short expiry. Role/tenant changes apply at next login
(deleted users fail closed — the user row is reloaded per request).
""" """
from __future__ import annotations from __future__ import annotations
@ -9,18 +15,24 @@ from __future__ import annotations
import hashlib import hashlib
import logging import logging
import secrets import secrets
import uuid
from datetime import UTC, datetime, timedelta from datetime import UTC, datetime, timedelta
from uuid import UUID from uuid import UUID
import jwt
from sqlmodel import Session, func, select from sqlmodel import Session, func, select
from app.models import AccessRequest, MagicLinkToken, User, UserSession from app.models import AccessRequest, MagicLinkToken, User
from app.models.base import utcnow
from app.settings import settings from app.settings import settings
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
MAGIC_LINK_TTL = timedelta(minutes=15) MAGIC_LINK_TTL = timedelta(minutes=15)
SESSION_TTL = timedelta(days=30) # Session window is deliberately short: sessions are stateless JWTs with
# no server-side revocation (logout only clears the cookie), so a stolen
# token stays valid until expiry. 7 days bounds that window.
SESSION_TTL = timedelta(days=7)
# Public request endpoint: at most this many requests per email per hour. # Public request endpoint: at most this many requests per email per hour.
REQUESTS_PER_EMAIL_PER_HOUR = 5 REQUESTS_PER_EMAIL_PER_HOUR = 5
@ -60,10 +72,6 @@ class RateLimitedError(AuthError):
pass pass
def utcnow() -> datetime:
return datetime.now(UTC)
def normalize_email(email: str) -> str: def normalize_email(email: str) -> str:
return email.strip().lower() return email.strip().lower()
@ -92,18 +100,22 @@ def user_count(session: Session) -> int:
return session.exec(select(func.count()).select_from(User)).one() return session.exec(select(func.count()).select_from(User)).one()
def recent_request_count(session: Session, email: str, hours: int = 1) -> int: def _recent_count(session: Session, model, *filters, hours: int = 1) -> int:
since = utcnow() - timedelta(hours=hours) since = utcnow() - timedelta(hours=hours)
return session.exec( return session.exec(
select(func.count()) select(func.count()).select_from(model).where(*filters, model.created_at >= since)
.select_from(AccessRequest)
.where(
AccessRequest.email == normalize_email(email),
AccessRequest.created_at >= since,
)
).one() ).one()
def recent_request_count(session: Session, email: str, hours: int = 1) -> int:
return _recent_count(
session,
AccessRequest,
AccessRequest.email == normalize_email(email),
hours=hours,
)
def create_access_request( def create_access_request(
session: Session, name: str, email: str, reason: str = "" session: Session, name: str, email: str, reason: str = ""
) -> AccessRequest: ) -> AccessRequest:
@ -165,15 +177,7 @@ def issue_magic_token(session: Session, user: User) -> str:
def recent_token_count(session: Session, user: User, hours: int = 1) -> int: def recent_token_count(session: Session, user: User, hours: int = 1) -> int:
since = utcnow() - timedelta(hours=hours) return _recent_count(session, MagicLinkToken, MagicLinkToken.user_id == user.id, hours=hours)
return session.exec(
select(func.count())
.select_from(MagicLinkToken)
.where(
MagicLinkToken.user_id == user.id,
MagicLinkToken.created_at >= since,
)
).one()
def request_magic_link(session: Session, email: str) -> tuple[User, str]: def request_magic_link(session: Session, email: str) -> tuple[User, str]:
@ -242,8 +246,43 @@ def _aware(value: datetime) -> datetime:
return value return value
def consume_magic_token(session: Session, token: str) -> UserSession: def _jwt_secret() -> str:
"""Single-use consume → session row. used_at is set before creation.""" secret = settings.jwt_secret
if not secret:
raise RuntimeError("JWT_SECRET is empty — set it in .env")
return secret
def mint_session_token(user: User) -> str:
"""Issue a stateless session JWT for a user (7-day expiry)."""
now = utcnow()
return jwt.encode(
{
"sub": str(user.id),
"email": user.email,
"role": user.role,
"tenant_id": user.tenant_id,
"iat": int(now.timestamp()),
"exp": int((now + SESSION_TTL).timestamp()),
"jti": uuid.uuid4().hex,
},
_jwt_secret(),
algorithm="HS256",
)
def decode_session_token(token: str) -> dict:
"""Verify a session JWT → claims. Expired/forged → token errors."""
try:
return jwt.decode(token.strip(), _jwt_secret(), algorithms=["HS256"])
except jwt.ExpiredSignatureError as exc:
raise ExpiredTokenError("session expired") from exc
except jwt.InvalidTokenError as exc:
raise InvalidTokenError("invalid session") from exc
def consume_magic_token(session: Session, token: str) -> tuple[User, str]:
"""Single-use consume → (user, session JWT). used_at is set first."""
record = session.exec( record = session.exec(
select(MagicLinkToken).where(MagicLinkToken.token_hash == hash_token(token.strip())) select(MagicLinkToken).where(MagicLinkToken.token_hash == hash_token(token.strip()))
).first() ).first()
@ -259,33 +298,23 @@ def consume_magic_token(session: Session, token: str) -> UserSession:
# Mark used first: a reused token can never mint a second session. # Mark used first: a reused token can never mint a second session.
record.used_at = utcnow() record.used_at = utcnow()
session.add(record) session.add(record)
user_session = UserSession(
id=secrets.token_urlsafe(32),
user_id=user.id,
expires_at=utcnow() + SESSION_TTL,
)
session.add(user_session)
session.commit() session.commit()
session.refresh(user_session) session.refresh(user)
logger.info("magic token consumed for user %s", user.id) logger.info("magic token consumed for user %s", user.id)
return user_session return user, mint_session_token(user)
def get_valid_session(session: Session, session_id: str) -> UserSession | None: def get_token_user(session: Session, token: str) -> User | None:
record = session.get(UserSession, session_id) """User for a session JWT, or None (expired/forged/deleted user)."""
if record is None or record.revoked_at is not None: try:
claims = decode_session_token(token)
except (InvalidTokenError, ExpiredTokenError):
return None return None
if _aware(record.expires_at) <= utcnow(): try:
user_id = UUID(str(claims.get("sub", "")))
except ValueError:
return None return None
return record return session.get(User, user_id)
def revoke_session(session: Session, session_id: str) -> None:
record = session.get(UserSession, session_id)
if record is not None and record.revoked_at is None:
record.revoked_at = utcnow()
session.add(record)
session.commit()
def bootstrap_admin(session: Session, email: str) -> tuple[User, str]: def bootstrap_admin(session: Session, email: str) -> tuple[User, str]:

View file

@ -0,0 +1,42 @@
<!DOCTYPE html>
<html lang="de">
<body style="margin:0;padding:0;background-color:{{ blue_light }};">
<table role="presentation" width="100%" cellpadding="0" cellspacing="0"
style="background-color:{{ blue_light }};padding:24px 12px;">
<tr><td align="center">
<table role="presentation" width="520" cellpadding="0" cellspacing="0"
style="max-width:520px;width:100%;font-family:Georgia,'Times New Roman',serif;
border-radius:12px;overflow:hidden;border:1px solid #d9e6f5;">
<tr>
<td bgcolor="{{ blue }}" style="padding:20px 28px;">
<span style="color:#ffffff;font-size:18px;font-weight:700;
letter-spacing:0.02em;">Kirche Einfach</span>
</td>
</tr>
<tr>
<td bgcolor="#ffffff" style="padding:28px 28px 24px 28px;">
<h1 style="margin:0 0 12px 0;font-size:22px;line-height:1.3;
color:{{ ink }};">{{ title }}</h1>
<p style="margin:0;font-family:-apple-system,Segoe UI,Roboto,
Helvetica,Arial,sans-serif;font-size:15px;line-height:1.6;
color:{{ muted }};">{{ intro }}</p>
{% if button_url %}
<table role="presentation" cellpadding="0" cellspacing="0"
style="margin:24px auto 8px auto;"><tr>
<td bgcolor="{{ blue }}" style="border-radius:8px;">
<a href="{{ button_url }}"
style="display:inline-block;padding:12px 28px;font-family:-apple-system,Segoe UI,Roboto,Helvetica,Arial,sans-serif;font-size:15px;font-weight:600;color:#ffffff;text-decoration:none;border-radius:8px;">{{ button_label }}</a>
</td>
</tr></table>
{% endif %}
</td>
</tr>
</table>
<p style="font-family:-apple-system,Segoe UI,Roboto,Helvetica,Arial,sans-serif;
font-size:12px;color:{{ muted }};margin:16px 0 0 0;max-width:520px;">
{{ note }}
</p>
</td></tr>
</table>
</body>
</html>

View file

@ -44,6 +44,11 @@ def get_session() -> Iterator[Session]:
yield session yield session
def get_db() -> Iterator[Session]:
"""Single FastAPI DB dependency (all routers import this)."""
yield from get_session()
def create_all(url: str | None = None) -> None: def create_all(url: str | None = None) -> None:
"""Create tables directly (dev convenience; migrations own prod schema).""" """Create tables directly (dev convenience; migrations own prod schema)."""
SQLModel.metadata.create_all(get_engine(url)) SQLModel.metadata.create_all(get_engine(url))

View file

@ -12,30 +12,24 @@ from __future__ import annotations
import json import json
import logging import logging
import secrets import secrets
from collections.abc import AsyncIterator, Iterator from collections.abc import AsyncIterator
from pathlib import Path from pathlib import Path
from typing import Annotated from typing import Annotated
from uuid import UUID from uuid import UUID
import httpx from fastapi import APIRouter, Depends, Header, HTTPException, Query, Request
from fastapi import APIRouter, Depends, Header, HTTPException, Query
from fastapi.responses import StreamingResponse from fastapi.responses import StreamingResponse
from sqlmodel import Session from sqlmodel import Session
from app.auth.deps import get_current_user, require_admin from app.auth.deps import get_current_user, require_admin
from app.db import get_engine, get_session from app.db import get_db
from app.middleware import limiter, run_limit
from app.models import User from app.models import User
from app.settings import settings from app.settings import settings
from . import input_schema as form_schema
from . import runner, store from . import runner, store
from .deploy import import_from_langflow, pull_all_from_langflow from .deploy import import_from_langflow
from .langflow_client import ( from .langflow_client import LangflowClient, LangflowError, LangflowNotFound, LangflowUnavailable
LangflowClient,
LangflowError,
LangflowNotFound,
LangflowUnavailable,
)
from .lfx_client import ( from .lfx_client import (
LfxClient, LfxClient,
LfxConflict, LfxConflict,
@ -56,22 +50,20 @@ from .schemas import (
FlowVersionCreate, FlowVersionCreate,
FlowVersionRead, FlowVersionRead,
InputSchemaRead, InputSchemaRead,
NamedRunRead,
RunRead, RunRead,
RunRequest, RunRequest,
SyncReport, SyncReport,
) )
from .sync import lfx_id_for, sync_from_directory from .sync import lfx_id_for
flows_router = APIRouter(prefix="/api/flows", tags=["flows"]) flows_router = APIRouter(prefix="/api/flows", tags=["flows"])
approvals_router = APIRouter(prefix="/api/approvals", tags=["approvals"]) approvals_router = APIRouter(prefix="/api/approvals", tags=["approvals"])
runs_router = APIRouter(prefix="/api/runs", tags=["runs"])
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
def get_db() -> Iterator[Session]:
yield from get_session()
def get_lfx() -> LfxClient: def get_lfx() -> LfxClient:
return LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None) return LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None)
@ -81,60 +73,40 @@ def get_langflow() -> LangflowClient:
def _read_definition(d) -> FlowDefinitionRead: def _read_definition(d) -> FlowDefinitionRead:
return FlowDefinitionRead( return FlowDefinitionRead.model_validate(d, from_attributes=True)
id=d.id,
name=d.name,
description=d.description,
status=d.status,
source_path=d.source_path,
continuation_flow_id=d.continuation_flow_id,
created_at=d.created_at,
)
def _read_version(v) -> FlowVersionRead: def _read_version(v) -> FlowVersionRead:
return FlowVersionRead( return FlowVersionRead.model_validate(v, from_attributes=True)
id=v.id,
flow_id=v.flow_id,
version_no=v.version_no,
langflow_json=v.langflow_json,
lfx_flow_id=v.lfx_flow_id,
deployed_at=v.deployed_at,
author=v.author,
created_at=v.created_at,
input_schema=v.input_schema,
)
def _read_run(r) -> RunRead: def _read_run(r) -> RunRead:
return RunRead( return RunRead.model_validate(r, from_attributes=True)
id=r.id,
version_id=r.version_id,
tenant_id=r.tenant_id,
status=r.status,
input=r.input,
output=r.output,
session_id=r.session_id,
created_at=r.created_at,
finished_at=r.finished_at,
)
def _read_task(t) -> ApprovalRead: def _read_task(t) -> ApprovalRead:
return ApprovalRead( return ApprovalRead.model_validate(t, from_attributes=True)
id=t.id,
run_id=t.run_id,
version_id=t.version_id, def _lfx_http(exc: LfxError) -> HTTPException:
tenant_id=t.tenant_id, """Map LFX domain errors to HTTP (single place, was 10x duplicated)."""
title=t.title, if isinstance(exc, LfxInvalidFlow):
payload=t.payload, return HTTPException(status_code=422, detail=str(exc))
continuation_flow_id=t.continuation_flow_id, if isinstance(exc, LfxConflict):
approver=t.approver, return HTTPException(status_code=409, detail=str(exc))
status=t.status, if isinstance(exc, LfxUnavailable):
decision_note=t.decision_note, logger.warning("lfx unavailable: %s", exc)
created_at=t.created_at, return HTTPException(status_code=503, detail="flow runtime unavailable")
decided_at=t.decided_at, logger.warning("lfx error: %s", exc)
) return HTTPException(status_code=502, detail="flow runtime error")
def _langflow_http(exc: LangflowError) -> HTTPException:
if isinstance(exc, LangflowUnavailable):
logger.warning("langflow unavailable: %s", exc)
return HTTPException(status_code=503, detail="authoring server unavailable")
logger.warning("langflow error: %s", exc)
return HTTPException(status_code=502, detail="authoring server error")
@flows_router.post("", response_model=FlowDefinitionRead, status_code=201) @flows_router.post("", response_model=FlowDefinitionRead, status_code=201)
@ -164,21 +136,14 @@ async def sync_flows(
_admin: Annotated[User, Depends(require_admin)], _admin: Annotated[User, Depends(require_admin)],
): ):
"""Manual full pass: Langflow -> backend/flows/*.json -> DB + LFX.""" """Manual full pass: Langflow -> backend/flows/*.json -> DB + LFX."""
from .sync import sync_full_pass
try: try:
pulled_result = await pull_all_from_langflow(langflow, Path(settings.flows_dir)) return await sync_full_pass(session, lfx, langflow, Path(settings.flows_dir))
except LangflowUnavailable as exc:
logger.warning("langflow unavailable: %s", exc)
raise HTTPException(status_code=503, detail="authoring server unavailable") from exc
except LangflowError as exc: except LangflowError as exc:
logger.warning("langflow error: %s", exc) raise _langflow_http(exc) from exc
raise HTTPException(status_code=502, detail="authoring server error") from exc
try:
report = await sync_from_directory(session, lfx, Path(settings.flows_dir))
except FileNotFoundError as exc: except FileNotFoundError as exc:
raise HTTPException(status_code=500, detail=str(exc)) from exc raise HTTPException(status_code=500, detail=str(exc)) from exc
report.pulled = pulled_result["pulled"]
report.errors = {**pulled_result["errors"], **report.errors}
return report
@flows_router.get("/{flow_id}", response_model=FlowDefinitionRead) @flows_router.get("/{flow_id}", response_model=FlowDefinitionRead)
@ -236,16 +201,8 @@ async def deploy_version(
flow_id=lfx_id_for(flow_id, version_no), flow_id=lfx_id_for(flow_id, version_no),
replace=True, replace=True,
) )
except LfxInvalidFlow as exc:
raise HTTPException(status_code=422, detail=str(exc)) from exc
except LfxConflict as exc:
raise HTTPException(status_code=409, detail=str(exc)) from exc
except LfxUnavailable as exc:
logger.warning("lfx unavailable: %s", exc)
raise HTTPException(status_code=503, detail="flow runtime unavailable") from exc
except LfxError as exc: except LfxError as exc:
logger.warning("lfx error: %s", exc) raise _lfx_http(exc) from exc
raise HTTPException(status_code=502, detail="flow runtime error") from exc
return _read_version(store.mark_deployed(session, version, uploaded.id)) return _read_version(store.mark_deployed(session, version, uploaded.id))
@ -256,7 +213,9 @@ def _resolve_version(session: Session, flow_id: UUID, version_no: int | None):
@flows_router.post("/{flow_id}/run", response_model=RunRead) @flows_router.post("/{flow_id}/run", response_model=RunRead)
@limiter.limit(run_limit)
async def run_flow( async def run_flow(
request: Request,
flow_id: UUID, flow_id: UUID,
data: RunRequest, data: RunRequest,
session: Annotated[Session, Depends(get_db)], session: Annotated[Session, Depends(get_db)],
@ -290,71 +249,52 @@ async def run_flow(
) )
except LfxNotFound as exc: except LfxNotFound as exc:
raise HTTPException(status_code=502, detail=f"LFX drift: {exc}") from exc raise HTTPException(status_code=502, detail=f"LFX drift: {exc}") from exc
except LfxUnavailable as exc:
logger.warning("lfx unavailable: %s", exc)
raise HTTPException(status_code=503, detail="flow runtime unavailable") from exc
except LfxError as exc: except LfxError as exc:
logger.warning("lfx error: %s", exc) raise _lfx_http(exc) from exc
raise HTTPException(status_code=502, detail="flow runtime error") from exc
return _read_run(run) return _read_run(run)
async def _run_stream( async def _run_stream(
session: Session, lfx: LfxClient, version, data: RunRequest, user: User, definition session: Session, lfx: LfxClient, version, data: RunRequest, user: User, definition
): ):
if not version.lfx_flow_id: try:
raise HTTPException(status_code=422, detail=f"version {version.id} is not deployed to LFX") run, envelope, lfx_flow_id, sid = await runner.stream_run(
run = store.create_run( session,
session, lfx,
version, version,
input=data.input, payload=data.input,
tenant_id=user.tenant_id, tenant_id=user.tenant_id,
session_id=data.session_id, session_id=data.session_id,
) callback_base_url=settings.callback_base_url,
envelope = runner.build_envelope( continuation_flow_id=definition.continuation_flow_id,
payload=data.input, callback_token=settings.callback_token,
run_id=run.id, )
callback_base_url=settings.callback_base_url, except store.InvalidError as exc:
continuation_flow_id=definition.continuation_flow_id, raise HTTPException(status_code=422, detail=str(exc)) from exc
callback_token=settings.callback_token,
)
run_id = run.id run_id = run.id
lfx_flow_id = version.lfx_flow_id
session_id = data.session_id or str(run.id)
async def event_gen() -> AsyncIterator[str]: async def event_gen() -> AsyncIterator[str]:
yield f"event: run\ndata: {json.dumps({'run_id': str(run_id)})}\n\n" yield f"event: run\ndata: {json.dumps({'run_id': str(run_id)})}\n\n"
try: async for chunk in runner.stream_lfx_chunks(lfx, lfx_flow_id, envelope, sid):
async with ( yield chunk
httpx.AsyncClient( status = runner.finalize_streamed_run(run_id)
base_url=lfx.base_url, timeout=lfx.timeout, headers=lfx._headers()
) as client,
client.stream(
"POST",
f"/flows/{lfx_flow_id}/stream",
json={"input_value": envelope, "session_id": session_id},
) as response,
):
if response.status_code == 404:
raise LfxNotFound(f"flow {lfx_flow_id} unknown to LFX")
response.raise_for_status()
async for chunk in response.aiter_text():
yield chunk
except (LfxNotFound, httpx.HTTPError) as exc:
yield f"event: error\ndata: {json.dumps({'error': str(exc)})}\n\n"
# Finalize from a fresh session: the request session may be closed.
with Session(get_engine()) as fresh:
try:
fresh_run = store.get_run(fresh, run_id)
status = "pending_approval" if runner._task_exists(fresh, run_id) else "completed"
store.set_run_result(fresh, fresh_run, status, {"streamed": True})
except store.NotFoundError:
status = "failed"
yield f"event: run_finished\ndata: {json.dumps({'run_id': str(run_id), 'status': status})}\n\n" yield f"event: run_finished\ndata: {json.dumps({'run_id': str(run_id), 'status': status})}\n\n"
return StreamingResponse(event_gen(), media_type="text/event-stream") return StreamingResponse(event_gen(), media_type="text/event-stream")
@runs_router.get("", response_model=list[NamedRunRead])
def list_all_runs(
session: Annotated[Session, Depends(get_db)],
user: Annotated[User, Depends(get_current_user)],
):
"""All runs of the session tenant with flow names (single query)."""
return [
NamedRunRead(flow_name=name, run=_read_run(run))
for run, name in store.list_all_runs(session, user.tenant_id)
]
@flows_router.get("/{flow_id}/runs", response_model=list[RunRead]) @flows_router.get("/{flow_id}/runs", response_model=list[RunRead])
def list_runs( def list_runs(
flow_id: UUID, flow_id: UUID,
@ -376,12 +316,8 @@ async def list_langflow_flows(
"""Browse flows on the Langflow authoring server (admin import source).""" """Browse flows on the Langflow authoring server (admin import source)."""
try: try:
return await langflow.list_flows() return await langflow.list_flows()
except LangflowUnavailable as exc:
logger.warning("langflow unavailable: %s", exc)
raise HTTPException(status_code=503, detail="authoring server unavailable") from exc
except LangflowError as exc: except LangflowError as exc:
logger.warning("langflow error: %s", exc) raise _langflow_http(exc) from exc
raise HTTPException(status_code=502, detail="authoring server error") from exc
@flows_router.post("/import", response_model=FlowImportRead, status_code=201) @flows_router.post("/import", response_model=FlowImportRead, status_code=201)
@ -405,26 +341,14 @@ async def import_flow(
) )
except LangflowNotFound as exc: except LangflowNotFound as exc:
raise HTTPException(status_code=404, detail=str(exc)) from exc raise HTTPException(status_code=404, detail=str(exc)) from exc
except LangflowUnavailable as exc:
logger.warning("langflow unavailable: %s", exc)
raise HTTPException(status_code=503, detail="authoring server unavailable") from exc
except LangflowError as exc: except LangflowError as exc:
logger.warning("langflow error: %s", exc) raise _langflow_http(exc) from exc
raise HTTPException(status_code=502, detail="authoring server error") from exc
except store.ConflictError as exc: except store.ConflictError as exc:
raise HTTPException(status_code=409, detail=str(exc)) from exc raise HTTPException(status_code=409, detail=str(exc)) from exc
except store.InvalidError as exc: except store.InvalidError as exc:
raise HTTPException(status_code=422, detail=str(exc)) from exc raise HTTPException(status_code=422, detail=str(exc)) from exc
except LfxInvalidFlow as exc:
raise HTTPException(status_code=422, detail=str(exc)) from exc
except LfxConflict as exc:
raise HTTPException(status_code=409, detail=str(exc)) from exc
except LfxUnavailable as exc:
logger.warning("lfx unavailable: %s", exc)
raise HTTPException(status_code=503, detail="flow runtime unavailable") from exc
except LfxError as exc: except LfxError as exc:
logger.warning("lfx error: %s", exc) raise _lfx_http(exc) from exc
raise HTTPException(status_code=502, detail="flow runtime error") from exc
return FlowImportRead(definition=_read_definition(definition), version=_read_version(version)) return FlowImportRead(definition=_read_definition(definition), version=_read_version(version))
@ -438,7 +362,7 @@ def get_input_schema(
version = store.get_latest_deployed_version(session, flow_id) version = store.get_latest_deployed_version(session, flow_id)
except (store.NotFoundError, store.InvalidError) as exc: except (store.NotFoundError, store.InvalidError) as exc:
raise HTTPException(status_code=404, detail=str(exc)) from exc raise HTTPException(status_code=404, detail=str(exc)) from exc
cached = version.input_schema or form_schema.extract_form_schema(version.langflow_json) cached = version.input_schema
return InputSchemaRead( return InputSchemaRead(
flow_id=flow_id, flow_id=flow_id,
version_no=version.version_no, version_no=version.version_no,
@ -561,10 +485,8 @@ async def decide_approval(
) )
except LfxNotFound as exc: except LfxNotFound as exc:
raise HTTPException(status_code=502, detail=f"LFX drift: {exc}") from exc raise HTTPException(status_code=502, detail=f"LFX drift: {exc}") from exc
except LfxUnavailable as exc:
raise HTTPException(status_code=503, detail=str(exc)) from exc
except LfxError as exc: except LfxError as exc:
raise HTTPException(status_code=502, detail=str(exc)) from exc raise _lfx_http(exc) from exc
return DecisionRead( return DecisionRead(
task=_read_task(task), task=_read_task(task),
continuation_run=_read_run(continuation_run) if continuation_run else None, continuation_run=_read_run(continuation_run) if continuation_run else None,

View file

@ -0,0 +1,44 @@
"""Shared base for LFX + Langflow async HTTP clients.
Consolidates base_url stripping, header building, per-request client
construction, and HTTPError → domain-error mapping. Subclasses only
declare their error types and endpoint calls. Transport-level failures
(connect/timeout, never 4xx) retry with exponential backoff via tenacity.
"""
from __future__ import annotations
import httpx
from tenacity import (
retry,
retry_if_exception_type,
stop_after_attempt,
wait_exponential,
)
class BaseApiClient:
"""Thin wrapper around httpx.AsyncClient construction."""
def __init__(self, base_url: str, timeout: float = 60.0, api_key: str | None = None) -> None:
self.base_url = base_url.rstrip("/")
self.timeout = timeout
self.api_key = api_key or ""
def _headers(self) -> dict[str, str]:
return {"x-api-key": self.api_key} if self.api_key else {}
def _client(self) -> httpx.AsyncClient:
return httpx.AsyncClient(
base_url=self.base_url, timeout=self.timeout, headers=self._headers()
)
def transport_retry(func): # type: ignore[no-untyped-def]
"""Retry transport errors 3x with backoff; HTTP status errors pass through."""
return retry(
stop=stop_after_attempt(3),
wait=wait_exponential(multiplier=0.5, max=4),
retry=retry_if_exception_type((httpx.TransportError, httpx.TimeoutException)),
reraise=True,
)(func)

View file

@ -2,6 +2,7 @@
from __future__ import annotations from __future__ import annotations
import logging
from pathlib import Path from pathlib import Path
from sqlmodel import Session from sqlmodel import Session
@ -13,6 +14,8 @@ from . import export, sync
from .langflow_client import LangflowClient, LangflowError from .langflow_client import LangflowClient, LangflowError
from .lfx_client import LfxClient from .lfx_client import LfxClient
logger = logging.getLogger(__name__)
def normalize_exported_flow(exported: dict, langflow_flow_id: str, name: str | None = None) -> dict: def normalize_exported_flow(exported: dict, langflow_flow_id: str, name: str | None = None) -> dict:
"""Reduce a Langflow FlowRead to the canonical fields we persist.""" """Reduce a Langflow FlowRead to the canonical fields we persist."""
@ -40,6 +43,7 @@ async def pull_all_from_langflow(
""" """
flows_dir = Path(flows_dir) flows_dir = Path(flows_dir)
headers = await langflow.list_flows() headers = await langflow.list_flows()
ignored = export.ignored_stems(flows_dir)
pulled: list[str] = [] pulled: list[str] = []
errors: dict[str, str] = {} errors: dict[str, str] = {}
for header in headers: for header in headers:
@ -49,6 +53,9 @@ async def pull_all_from_langflow(
try: try:
exported = await langflow.export_flow(flow_id) exported = await langflow.export_flow(flow_id)
doc = normalize_exported_flow(exported, flow_id) doc = normalize_exported_flow(exported, flow_id)
if export.filename_stem(doc["name"]) in ignored:
logger.warning("pull skips ignored flow %r", doc["name"])
continue
reuse, identical = export.find_reuse_path(flows_dir, doc) reuse, identical = export.find_reuse_path(flows_dir, doc)
if identical and reuse is not None: if identical and reuse is not None:
pulled.append(reuse.stem) pulled.append(reuse.stem)

View file

@ -10,11 +10,42 @@ import hashlib
import json import json
import os import os
import re import re
import tempfile
from pathlib import Path from pathlib import Path
FLOWS_GLOB = "*.json" FLOWS_GLOB = "*.json"
#: Opt-out list in the flows dir (one stem per line, `#` comments):
#: listed flows stay in Langflow only — never synced, deployed,
#: validated, or shown in the frontend.
IGNORE_FILENAME = ".flowsignore"
# mtime-keyed cache: the watcher re-reads per event, the file rarely changes.
_ignore_cache: dict[str, tuple[float, set[str]]] = {}
def ignored_stems(flows_dir: str | Path) -> set[str]:
"""Stems excluded from the pipeline (empty when no ignore file)."""
key = str(Path(flows_dir))
try:
mtime = (Path(flows_dir) / IGNORE_FILENAME).stat().st_mtime
except OSError:
_ignore_cache.pop(key, None)
return set()
cached = _ignore_cache.get(key)
if cached is not None and cached[0] == mtime:
return cached[1]
try:
text = (Path(flows_dir) / IGNORE_FILENAME).read_text(encoding="utf-8")
except OSError:
return set()
stems = {
line.strip()
for line in text.splitlines()
if line.strip() and not line.strip().startswith("#")
}
_ignore_cache[key] = (mtime, stems)
return stems
def filename_stem(name: str) -> str: def filename_stem(name: str) -> str:
"""Map a flow name to a filename stem, keeping the original name. """Map a flow name to a filename stem, keeping the original name.
@ -79,25 +110,16 @@ def find_reuse_path(flows_dir: str | Path, doc: dict) -> tuple[Path | None, bool
def write_flow_bytes(target: Path, doc: dict) -> Path: def write_flow_bytes(target: Path, doc: dict) -> Path:
"""Write a flow document to an explicit path atomically (tmp + rename). """Write a flow document to an explicit path atomically (tmp + rename).
The file ends up world-readable (0o644): mkstemp creates 0o600, which The file ends up world-readable (0o644): atomicwrites follows the
would lock out the other containers (Langflow/LFX run as different umask, which would lock out the other containers (Langflow/LFX run
users and crash on unreadable seed files). as different users and crash on unreadable seed files).
""" """
from atomicwrites import atomic_write
target.parent.mkdir(parents=True, exist_ok=True) target.parent.mkdir(parents=True, exist_ok=True)
fd, tmp_name = tempfile.mkstemp( with atomic_write(target, mode="wb", overwrite=True) as tmp:
dir=str(target.parent), prefix=f".{target.stem}-", suffix=".tmp" tmp.write(canonical_bytes(doc))
) os.chmod(target, 0o644)
try:
with os.fdopen(fd, "wb") as tmp:
tmp.write(canonical_bytes(doc))
os.replace(tmp_name, target)
os.chmod(target, 0o644)
except BaseException:
try:
os.unlink(tmp_name)
except OSError:
pass
raise
return target return target
@ -113,6 +135,7 @@ def write_flow_file(flows_dir: str | Path, doc: dict, *, name: str | None = None
return write_flow_bytes(flow_path(flows_dir, stem), doc) return write_flow_bytes(flow_path(flows_dir, stem), doc)
def iter_flow_files(flows_dir: str | Path) -> list[Path]: def iter_flow_files(flows_dir: str | Path, *, ignored: set[str] | None = None) -> list[Path]:
"""Sorted list of candidate flow files (top level only).""" """Sorted list of candidate flow files (top level only, minus ignored)."""
return sorted(Path(flows_dir).glob(FLOWS_GLOB)) skip = ignored if ignored is not None else ignored_stems(flows_dir)
return sorted(p for p in Path(flows_dir).glob(FLOWS_GLOB) if p.stem not in skip)

View file

@ -1,11 +1,16 @@
"""Derive a web-form schema from a Langflow export. """Derive a web-form schema from a Langflow export.
Looks for ``CustomInput*`` nodes (``data.type`` or the inner Looks for form nodes — ``CustomInput*`` (``data.type`` or the inner
``display_name`` starting with ``CustomInput`` — see ``display_name`` starting with ``CustomInput``, see
``backend/components/kirche/form_inputs.py``) and maps their ``template`` ``backend/components/kirche/form_inputs.py``) plus user-built
``CustomComponent`` nodes whose display name ends with ``"Form"``
(e.g. ``Mitarbeiter Einstellen Form``) — and maps their ``template``
(minus ``code``) to ``{json_schema, ui_schema}`` for RJSF: (minus ``code``) to ``{json_schema, ui_schema}`` for RJSF:
* ``name`` → property key, ``display_name`` → ``title``, * ``name`` → property key (freely renamable in the Langflow code editor;
kept verbatim so frontend payload keys match the runtime output —
only empty names are skipped and collisions get a ``_2``/``_3`` suffix),
``display_name`` → ``title``,
``info`` → ``description``, ``value`` → ``default``, ``info`` → ``description``, ``value`` → ``default``,
``options`` → ``enum``, ``required`` → required array ``options`` → ``enum``, ``required`` → required array
* ``show: false`` fields are plumbing (e.g. the run envelope input), not * ``show: false`` fields are plumbing (e.g. the run envelope input), not
@ -13,6 +18,13 @@ Looks for ``CustomInput*`` nodes (``data.type`` or the inner
* ``advanced`` fields render last via ``ui:order`` * ``advanced`` fields render last via ``ui:order``
* ``_input_type`` → JSON type + widget (unknown types fall back to string * ``_input_type`` → JSON type + widget (unknown types fall back to string
so the parser never crashes on new fields) so the parser never crashes on new fields)
* ``[visible_if ...]`` markers in ``info`` → conditional branches
(``allOf`` with ``if``/``then`` per dependent field, arbitrarily nested;
see ``_extract_visibility``). The marker is stripped from the shown
description. Preferred: structured ``visible_if`` key (list of
``{field, value}`` or ``{field: value}``) — no quoting mini-language,
rename-refactorable, validated at sync time with warnings instead of
silent fail-open. Markers stay as deprecated fallback.
A flow without such a node gets ``{fallback: "textarea"}``: the frontend A flow without such a node gets ``{fallback: "textarea"}``: the frontend
renders one free-text box instead of a generated form. renders one free-text box instead of a generated form.
@ -20,9 +32,19 @@ renders one free-text box instead of a generated form.
from __future__ import annotations from __future__ import annotations
import re
#: ``[visible_if gebaeude=Kirche & bestandteil="Glocke, Orgel"]`` in a
#: field's ``info``. Authored in the Langflow code editor; the parser strips
#: the marker from the shown description and turns the conditions into
#: ``allOf``/``if``/``then`` branches (draft-07 — the ``dependencies``/
#: ``if`` keywords this stack's RJSF + ajv build honors; ``dependentSchemas``
#: is ignored there, so it is never emitted).
_VISIBLE_RE = re.compile(r"\[visible_if\s+([^\]]+)\]")
def _form_templates(langflow_json: dict) -> list[dict]: def _form_templates(langflow_json: dict) -> list[dict]:
"""Inner node dicts (``data.node``) of all CustomInput* nodes.""" """Inner node dicts (``data.node``) of all form nodes."""
if not isinstance(langflow_json, dict): if not isinstance(langflow_json, dict):
return [] return []
data = langflow_json.get("data") or {} data = langflow_json.get("data") or {}
@ -37,6 +59,10 @@ def _form_templates(langflow_json: dict) -> list[dict]:
display = str(inner.get("display_name") or "") display = str(inner.get("display_name") or "")
if node_type.startswith("CustomInput") or display.startswith("CustomInput"): if node_type.startswith("CustomInput") or display.startswith("CustomInput"):
found.append(inner) found.append(inner)
elif node_type == "CustomComponent" and display.endswith("Form"):
# User-built form components (e.g. "Mitarbeiter Einstellen
# Form"): same template contract, no kirche base needed.
found.append(inner)
return found return found
@ -112,6 +138,125 @@ def _field_schema(name: str, field: dict) -> tuple[dict, dict]:
return prop, ui return prop, ui
def _split_conditions(text: str) -> list[str]:
"""Split ``a=X & b="Y Z"`` on ``&`` outside double quotes."""
parts: list[str] = []
buf: list[str] = []
quoted = False
for char in text:
if char == '"':
quoted = not quoted
buf.append(char)
elif char == "&" and not quoted:
parts.append("".join(buf))
buf = []
else:
buf.append(char)
parts.append("".join(buf))
return [part.strip() for part in parts if part.strip()]
def _parse_condition(token: str) -> tuple[str, object] | None:
"""``feld=Wert`` → ``(feld, wert)`` (bool/number coerced, quotes stripped)."""
field, sep, value = token.partition("=")
field, value = field.strip(), value.strip()
if not sep or not field or not value:
return None
if len(value) >= 2 and value.startswith('"') and value.endswith('"'):
value = value[1:-1]
lowered = value.lower()
if lowered == "true":
return field, True
if lowered == "false":
return field, False
try:
return field, int(value)
except ValueError:
pass
try:
return field, float(value)
except ValueError:
pass
return field, value
def _extract_visibility(
info: str, field: dict | None = None
) -> tuple[str, list[tuple[str, object]]]:
"""(marker-free description, conditions) for a field's ``info`` text.
Structured ``visible_if`` on the field wins (list of {field, value} or
dict); legacy ``[visible_if ...]`` markers in ``info`` stay as fallback.
"""
if field is not None:
structured = field.get("visible_if")
if structured:
conditions: list[tuple[str, object]] = []
items = structured.items() if isinstance(structured, dict) else structured
for item in items or []:
if isinstance(item, dict) and "field" in item:
conditions.append((item["field"], item.get("value")))
elif isinstance(item, (list, tuple)) and len(item) == 2:
conditions.append((item[0], item[1]))
if conditions:
clean = re.sub(r"\s+", " ", (info or "")).strip()
return clean, conditions
conditions = []
def _collect(match: re.Match) -> str:
for token in _split_conditions(match.group(1)):
parsed = _parse_condition(token)
if parsed is not None:
conditions.append(parsed)
return ""
clean = _VISIBLE_RE.sub(_collect, info or "")
clean = re.sub(r"\s+", " ", clean).strip()
return clean, conditions
def _match_schema(trigger_field: dict, value: object) -> dict | None:
"""JSON-Schema fragment matching one condition, or None (unsupported)."""
input_type = str(trigger_field.get("_input_type") or "")
if input_type == "MultiselectInput":
return {"contains": {"const": value}}
if input_type == "BoolInput":
return {"const": value} if isinstance(value, bool) else None
if input_type in (
"StrInput",
"MessageTextInput",
"MultilineInput",
"SecretStrInput",
"DropdownInput",
):
return {"const": value} if isinstance(value, str) else None
if input_type in ("IntInput", "FloatInput"):
if isinstance(value, bool) or not isinstance(value, (int, float)):
return None
return {"const": value}
return None
def _cyclic_fields(edges: dict[str, set[str]]) -> set[str]:
"""Fields on a trigger→dependent cycle (fail-open candidates)."""
cyclic: set[str] = set()
visiting: list[str] = []
def _visit(node: str) -> None:
visiting.append(node)
for target in edges.get(node, ()):
if target in visiting:
cyclic.update(visiting[visiting.index(target) :])
elif target not in cyclic:
_visit(target)
visiting.pop()
for node in edges:
if node not in cyclic:
_visit(node)
return cyclic
def extract_form_schema(langflow_json: dict) -> dict: def extract_form_schema(langflow_json: dict) -> dict:
"""``{json_schema, ui_schema}``, or with ``fallback: "textarea"``.""" """``{json_schema, ui_schema}``, or with ``fallback: "textarea"``."""
templates = _form_templates(langflow_json) templates = _form_templates(langflow_json)
@ -122,31 +267,126 @@ def extract_form_schema(langflow_json: dict) -> dict:
"fallback": "textarea", "fallback": "textarea",
} }
template = templates[0].get("template") or {} template = templates[0].get("template") or {}
properties: dict = {} # First pass: sanitize names (existing rules) and parse markers.
required: list[str] = [] records: list[dict] = []
ui_schema: dict = {} taken: set[str] = set()
normal: list[str] = []
advanced: list[str] = []
for key, field in template.items(): for key, field in template.items():
if key == "code" or not isinstance(field, dict): if key == "code" or not isinstance(field, dict):
continue continue
if field.get("show") is False: if field.get("show") is False:
continue continue
name = field.get("name") or key raw_name = field.get("name") or key
prop, ui = _field_schema(name, field) name = str(raw_name).strip()
properties[name] = prop if not name:
if field.get("required"): continue
required.append(name) if name in taken:
suffix = 2
while f"{name}_{suffix}" in taken:
suffix += 1
name = f"{name}_{suffix}"
taken.add(name)
clean_info, conditions = _extract_visibility(str(field.get("info") or ""), field)
records.append(
{
"name": name,
"field": {**field, "info": clean_info},
"required": bool(field.get("required")),
"advanced": bool(field.get("advanced")),
"conditions": conditions,
}
)
by_name = {record["name"]: record for record in records}
# Validate conditions: known trigger + supported match. Anything else
# fails open (field stays always visible) so a stale marker can never
# hide data or break validation.
matches: dict[str, list[tuple[str, dict]]] = {}
for record in records:
resolved: list[tuple[str, dict]] = []
for trigger, value in record["conditions"]:
trigger_record = by_name.get(trigger)
match = _match_schema(trigger_record["field"], value) if trigger_record else None
if trigger_record is None or match is None or trigger == record["name"]:
resolved = []
break
resolved.append((trigger, match))
if resolved:
matches[record["name"]] = resolved
for name in _cyclic_fields(
{name: {trigger for trigger, _ in conds} for name, conds in matches.items()}
):
del matches[name]
# Emit: conditional fields live only in their if/then branch (that is
# what hides them in RJSF); everything else stays at root.
properties: dict = {}
required: list[str] = []
ui_schema: dict = {}
normal: list[str] = []
advanced: list[str] = []
for record in records:
name = record["name"]
prop, ui = _field_schema(name, record["field"])
if name not in matches:
properties[name] = prop
if record["required"]:
required.append(name)
else:
record["branch_prop"] = prop
if ui: if ui:
ui_schema[name] = ui ui_schema[name] = ui
(advanced if field.get("advanced") else normal).append(name) (advanced if record["advanced"] else normal).append(name)
if advanced: json_schema: dict = {"type": "object", "properties": properties, "required": required}
if matches:
rules = []
for name, conds in matches.items():
record = by_name[name]
rules.append(
{
"if": {
"properties": {trigger: match for trigger, match in conds},
"required": [trigger for trigger, _ in conds],
},
"then": {
"properties": {name: record["branch_prop"]},
**({"required": [name]} if record["required"] else {}),
},
}
)
json_schema["allOf"] = rules
ui_schema["ui:order"] = normal + advanced + ["*"] ui_schema["ui:order"] = normal + advanced + ["*"]
return { elif advanced:
"json_schema": { ui_schema["ui:order"] = normal + advanced + ["*"]
"type": "object", return {"json_schema": json_schema, "ui_schema": ui_schema}
"properties": properties,
"required": required,
}, def schema_field_names(cached: dict) -> list[str]:
"ui_schema": ui_schema, """All asked field names of a cached form schema (root + branches).
}
Used for the run envelope's ``fields`` list so the runtime emits
defaults only for asked fields. Order: root properties first, then
branch discoveries.
"""
if not isinstance(cached, dict):
return []
json_schema = cached.get("json_schema") or {}
names: list[str] = []
def _walk(node: object) -> None:
if not isinstance(node, dict):
return
for subschema in (node.get("then"), node.get("else")):
if isinstance(subschema, dict):
for key in subschema.get("properties") or {}:
if key not in names:
names.append(key)
_walk(subschema)
for key in ("allOf", "oneOf", "anyOf"):
items = node.get(key) or []
if isinstance(items, list):
for item in items:
_walk(item)
for key in json_schema.get("properties") or {}:
if key not in names:
names.append(key)
_walk(json_schema)
return names

View file

@ -8,6 +8,8 @@ from __future__ import annotations
import httpx import httpx
from .base_client import BaseApiClient, transport_retry
class LangflowError(Exception): class LangflowError(Exception):
pass pass
@ -21,23 +23,17 @@ class LangflowUnavailable(LangflowError):
pass pass
class LangflowClient: class LangflowClient(BaseApiClient):
"""Thin async wrapper around the Langflow `/api/v1/flows` endpoints.""" """Thin async wrapper around the Langflow `/api/v1/flows` endpoints."""
def __init__(self, base_url: str, api_key: str = "", timeout: float = 60.0) -> None: def __init__(self, base_url: str, api_key: str = "", timeout: float = 60.0) -> None:
self.base_url = base_url.rstrip("/") super().__init__(base_url, timeout=timeout, api_key=api_key)
self.api_key = api_key
self.timeout = timeout
def _headers(self) -> dict[str, str]:
return {"x-api-key": self.api_key} if self.api_key else {}
@transport_retry
async def list_flows(self) -> list[dict]: async def list_flows(self) -> list[dict]:
"""List flows (header mode keeps payloads small).""" """List flows (header mode keeps payloads small)."""
try: try:
async with httpx.AsyncClient( async with self._client() as client:
base_url=self.base_url, timeout=self.timeout, headers=self._headers()
) as client:
response = await client.get("/api/v1/flows/", params={"header_flows": "true"}) response = await client.get("/api/v1/flows/", params={"header_flows": "true"})
if response.status_code == 404: if response.status_code == 404:
raise LangflowNotFound("flow list not found") raise LangflowNotFound("flow list not found")
@ -49,12 +45,11 @@ class LangflowClient:
except httpx.HTTPError as exc: except httpx.HTTPError as exc:
raise LangflowUnavailable(f"Langflow unreachable: {exc}") from exc raise LangflowUnavailable(f"Langflow unreachable: {exc}") from exc
@transport_retry
async def export_flow(self, langflow_flow_id: str) -> dict: async def export_flow(self, langflow_flow_id: str) -> dict:
"""Export one flow as Langflow JSON (FlowRead: id/name/description/data).""" """Export one flow as Langflow JSON (FlowRead: id/name/description/data)."""
try: try:
async with httpx.AsyncClient( async with self._client() as client:
base_url=self.base_url, timeout=self.timeout, headers=self._headers()
) as client:
response = await client.get(f"/api/v1/flows/{langflow_flow_id}") response = await client.get(f"/api/v1/flows/{langflow_flow_id}")
if response.status_code == 404: if response.status_code == 404:
raise LangflowNotFound(f"flow {langflow_flow_id} not found") raise LangflowNotFound(f"flow {langflow_flow_id} not found")
@ -64,3 +59,25 @@ class LangflowClient:
raise LangflowError(f"Langflow error {exc.response.status_code}") from exc raise LangflowError(f"Langflow error {exc.response.status_code}") from exc
except httpx.HTTPError as exc: except httpx.HTTPError as exc:
raise LangflowUnavailable(f"Langflow unreachable: {exc}") from exc raise LangflowUnavailable(f"Langflow unreachable: {exc}") from exc
@transport_retry
async def upsert_flow(self, doc: dict) -> dict:
"""Create or update a flow in Langflow by name (authoring UI refresh).
Used after flow/component tightening so the visual editor shows the
latest canonical JSON without a container restart.
"""
try:
async with self._client() as client:
existing = await self.list_flows()
match = next((f for f in existing if f.get("name") == doc.get("name")), None)
if match and match.get("id"):
response = await client.patch(f"/api/v1/flows/{match['id']}", json=doc)
else:
response = await client.post("/api/v1/flows/", json=doc)
response.raise_for_status()
return response.json()
except httpx.HTTPStatusError as exc:
raise LangflowError(f"Langflow error {exc.response.status_code}") from exc
except httpx.HTTPError as exc:
raise LangflowUnavailable(f"Langflow unreachable: {exc}") from exc

View file

@ -6,6 +6,8 @@ from dataclasses import dataclass
import httpx import httpx
from .base_client import BaseApiClient, transport_retry
class LfxError(Exception): class LfxError(Exception):
"""Base error for LFX communication problems.""" """Base error for LFX communication problems."""
@ -48,22 +50,13 @@ class LfxRunResult:
component: str component: str
class LfxClient: class LfxClient(BaseApiClient):
"""Thin async wrapper around the LFX serve HTTP API.""" """Thin async wrapper around the LFX serve HTTP API."""
def __init__(self, base_url: str, timeout: float = 120.0, api_key: str | None = None) -> None: def __init__(self, base_url: str, timeout: float = 120.0, api_key: str | None = None) -> None:
self.base_url = base_url.rstrip("/") super().__init__(base_url, timeout=timeout, api_key=api_key)
self.timeout = timeout
self.api_key = api_key
def _headers(self) -> dict[str, str]:
return {"x-api-key": self.api_key} if self.api_key else {}
def _client(self) -> httpx.AsyncClient:
return httpx.AsyncClient(
base_url=self.base_url, timeout=self.timeout, headers=self._headers()
)
@transport_retry
async def health(self) -> dict: async def health(self) -> dict:
try: try:
async with self._client() as client: async with self._client() as client:
@ -73,6 +66,7 @@ class LfxClient:
except httpx.HTTPError as exc: except httpx.HTTPError as exc:
raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc
@transport_retry
async def list_flows(self) -> list[dict]: async def list_flows(self) -> list[dict]:
try: try:
async with self._client() as client: async with self._client() as client:
@ -84,6 +78,7 @@ class LfxClient:
except httpx.HTTPError as exc: except httpx.HTTPError as exc:
raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc
@transport_retry
async def upload_flow( async def upload_flow(
self, flow_json: dict, *, flow_id: str | None = None, replace: bool = False self, flow_json: dict, *, flow_id: str | None = None, replace: bool = False
) -> LfxUploadResult: ) -> LfxUploadResult:
@ -148,6 +143,7 @@ class LfxClient:
except httpx.HTTPError as exc: except httpx.HTTPError as exc:
raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc
@transport_retry
async def flow_info(self, lfx_flow_id: str) -> dict: async def flow_info(self, lfx_flow_id: str) -> dict:
try: try:
async with self._client() as client: async with self._client() as client:
@ -159,6 +155,7 @@ class LfxClient:
except httpx.HTTPError as exc: except httpx.HTTPError as exc:
raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc raise LfxUnavailable(f"LFX unreachable at {self.base_url}: {exc}") from exc
@transport_retry
async def delete_flow(self, lfx_flow_id: str) -> None: async def delete_flow(self, lfx_flow_id: str) -> None:
try: try:
async with self._client() as client: async with self._client() as client:

View file

@ -3,14 +3,18 @@
from __future__ import annotations from __future__ import annotations
import json import json
from collections.abc import AsyncIterator
from uuid import UUID from uuid import UUID
from sqlmodel import Session, select import httpx
from sqlmodel import Session
from app.models import ApprovalTask, FlowRun, FlowVersion from app.db import get_engine
from app.models import FlowRun, FlowVersion
from . import input_schema as form_schema
from . import store from . import store
from .lfx_client import LfxClient, LfxRunFailed from .lfx_client import LfxClient, LfxNotFound, LfxRunFailed
from .store import InvalidError from .store import InvalidError
@ -21,25 +25,25 @@ def build_envelope(
callback_base_url: str, callback_base_url: str,
continuation_flow_id: UUID | None, continuation_flow_id: UUID | None,
callback_token: str, callback_token: str,
fields: list[str] | None = None,
) -> str: ) -> str:
return json.dumps( """Run envelope for LFX. ``fields`` (asked form-field names, from the
{ version's cached input schema) lets form components emit defaults only
"payload": payload, for asked fields; omitted (None) preserves the legacy shape."""
"run_id": str(run_id), body: dict = {
"callback_url": callback_base_url.rstrip("/"), "payload": payload,
"continuation_flow_id": (str(continuation_flow_id) if continuation_flow_id else None), "run_id": str(run_id),
"callback_token": callback_token, "callback_url": callback_base_url.rstrip("/"),
} "continuation_flow_id": (str(continuation_flow_id) if continuation_flow_id else None),
) "callback_token": callback_token,
}
if fields is not None:
body["fields"] = list(fields)
return json.dumps(body)
def _task_exists(session: Session, run_id: UUID) -> bool: def _task_exists(session: Session, run_id: UUID) -> bool:
return ( return store.has_open_task(session, run_id)
session.exec(
select(ApprovalTask).where(ApprovalTask.run_id == run_id, ApprovalTask.status == "open")
).first()
is not None
)
async def execute_run( async def execute_run(
@ -66,12 +70,14 @@ async def execute_run(
run = store.create_run( run = store.create_run(
session, version, input=payload, tenant_id=tenant_id, session_id=session_id session, version, input=payload, tenant_id=tenant_id, session_id=session_id
) )
cached = version.input_schema
envelope = build_envelope( envelope = build_envelope(
payload=payload, payload=payload,
run_id=run.id, run_id=run.id,
callback_base_url=callback_base_url, callback_base_url=callback_base_url,
continuation_flow_id=continuation_flow_id, continuation_flow_id=continuation_flow_id,
callback_token=callback_token, callback_token=callback_token,
fields=form_schema.schema_field_names(cached),
) )
try: try:
result = await lfx.run_flow( result = await lfx.run_flow(
@ -89,3 +95,73 @@ async def execute_run(
if _task_exists(session, run.id): if _task_exists(session, run.id):
return store.set_run_result(session, run, "pending_approval", output) return store.set_run_result(session, run, "pending_approval", output)
return store.set_run_result(session, run, "completed", output) return store.set_run_result(session, run, "completed", output)
async def stream_run(
session: Session,
lfx: LfxClient,
version: FlowVersion,
*,
payload: dict,
tenant_id: str,
session_id: str | None,
callback_base_url: str,
continuation_flow_id: UUID | None,
callback_token: str,
) -> tuple[FlowRun, str, str, str]:
"""Create a run + envelope for SSE streaming. Returns (run, envelope, lfx_id, sid).
The actual SSE bytes are produced by the API layer; finalization uses a
fresh session (the request session may be closed when the generator ends).
"""
if not version.lfx_flow_id:
raise InvalidError(f"version {version.id} is not deployed to LFX")
run = store.create_run(
session, version, input=payload, tenant_id=tenant_id, session_id=session_id
)
cached = version.input_schema
envelope = build_envelope(
payload=payload,
run_id=run.id,
callback_base_url=callback_base_url,
continuation_flow_id=continuation_flow_id,
callback_token=callback_token,
fields=form_schema.schema_field_names(cached),
)
return run, envelope, version.lfx_flow_id, session_id or str(run.id)
async def stream_lfx_chunks(
lfx: LfxClient, lfx_flow_id: str, envelope: str, sid: str
) -> AsyncIterator[str]:
"""Yield raw SSE chunks from LFX, mapping transport errors to error events."""
try:
async with (
httpx.AsyncClient(
base_url=lfx.base_url, timeout=lfx.timeout, headers=lfx._headers()
) as client,
client.stream(
"POST",
f"/flows/{lfx_flow_id}/stream",
json={"input_value": envelope, "session_id": sid},
) as response,
):
if response.status_code == 404:
raise LfxNotFound(f"flow {lfx_flow_id} unknown to LFX")
response.raise_for_status()
async for chunk in response.aiter_text():
yield chunk
except (LfxNotFound, httpx.HTTPError) as exc:
yield f"event: error\ndata: {json.dumps({'error': str(exc)})}\n\n"
def finalize_streamed_run(run_id: UUID) -> str:
"""Mark a streamed run completed/pending_approval from a fresh session."""
with Session(get_engine()) as fresh:
try:
fresh_run = store.get_run(fresh, run_id)
status = "pending_approval" if store.has_open_task(fresh, run_id) else "completed"
store.set_run_result(fresh, fresh_run, status, {"streamed": True})
except store.NotFoundError:
status = "failed"
return status

View file

@ -37,7 +37,7 @@ class FlowVersionRead(BaseModel):
deployed_at: datetime | None deployed_at: datetime | None
author: str author: str
created_at: datetime created_at: datetime
input_schema: dict | None = None input_schema: dict
class InputSchemaRead(BaseModel): class InputSchemaRead(BaseModel):
@ -76,6 +76,13 @@ class RunRead(BaseModel):
finished_at: datetime | None finished_at: datetime | None
class NamedRunRead(BaseModel):
"""A run with its flow name (GET /api/runs aggregate, kills N+1)."""
flow_name: str
run: RunRead
class ApprovalCreate(BaseModel): class ApprovalCreate(BaseModel):
"""Callback contract: a flow reports a terminal approval state.""" """Callback contract: a flow reports a terminal approval state."""

View file

@ -129,15 +129,18 @@ def validate_flow_json(flow_json: dict) -> None:
raise InvalidError("langflow_json.data must contain 'nodes' and 'edges' lists") raise InvalidError("langflow_json.data must contain 'nodes' and 'edges' lists")
def create_version(session: Session, flow_id: UUID, data: FlowVersionCreate) -> FlowVersion: def create_version(
session: Session,
flow_id: UUID,
data: FlowVersionCreate,
*,
version_no: int | None = None,
) -> FlowVersion:
get_definition(session, flow_id) get_definition(session, flow_id)
validate_flow_json(data.langflow_json) validate_flow_json(data.langflow_json)
max_no = session.exec(
select(func.max(FlowVersion.version_no)).where(FlowVersion.flow_id == flow_id)
).one()
version = FlowVersion( version = FlowVersion(
flow_id=flow_id, flow_id=flow_id,
version_no=(max_no or 0) + 1, version_no=version_no if version_no is not None else next_version_no(session, flow_id),
langflow_json=data.langflow_json, langflow_json=data.langflow_json,
author=data.author, author=data.author,
# Single choke point: sync, import, and API creation all cache the # Single choke point: sync, import, and API creation all cache the
@ -229,6 +232,16 @@ def set_run_result(session: Session, run: FlowRun, status: str, output: dict | N
return run return run
def has_open_task(session: Session, run_id: UUID) -> bool:
"""True when a run has an open approval task (terminal-state mapping)."""
return (
session.exec(
select(ApprovalTask).where(ApprovalTask.run_id == run_id, ApprovalTask.status == "open")
).first()
is not None
)
def get_run(session: Session, run_id: UUID) -> FlowRun: def get_run(session: Session, run_id: UUID) -> FlowRun:
run = session.get(FlowRun, run_id) run = session.get(FlowRun, run_id)
if run is None: if run is None:
@ -249,6 +262,18 @@ def list_runs(session: Session, flow_id: UUID, tenant_id: str | None = None) ->
return list(session.exec(query).all()) return list(session.exec(query).all())
def list_all_runs(session: Session, tenant_id: str) -> list[tuple[FlowRun, str]]:
"""All runs of a tenant with flow names (single query, kills N+1)."""
rows = session.exec(
select(FlowRun, FlowDefinition.name)
.join(FlowVersion, FlowVersion.id == FlowRun.version_id)
.join(FlowDefinition, FlowDefinition.id == FlowVersion.flow_id)
.where(FlowRun.tenant_id == tenant_id)
.order_by(FlowRun.created_at.desc())
).all()
return [(run, name) for run, name in rows]
def create_approval_task(session: Session, data: ApprovalCreate) -> ApprovalTask: def create_approval_task(session: Session, data: ApprovalCreate) -> ApprovalTask:
run = session.get(FlowRun, data.run_id) run = session.get(FlowRun, data.run_id)
if run is None: if run is None:

View file

@ -64,8 +64,8 @@ async def sync_document(
"skipped" (content unchanged). Raises store.ConflictError on name "skipped" (content unchanged). Raises store.ConflictError on name
clashes, store.InvalidError on invalid JSON, LfxError when deploy fails. clashes, store.InvalidError on invalid JSON, LfxError when deploy fails.
With deploy=False a version is recorded without touching LFX. With deploy=False a version is recorded without touching LFX.
Validation lives in store.create_version (single choke point).
""" """
store.validate_flow_json(doc)
name = doc.get("name") or Path(source_filename).stem name = doc.get("name") or Path(source_filename).stem
with sync_lock: with sync_lock:
definition = store.get_definition_by_source_path(session, source_filename) definition = store.get_definition_by_source_path(session, source_filename)
@ -102,9 +102,8 @@ async def sync_document(
session, session,
definition.id, definition.id,
FlowVersionCreate(langflow_json=doc, author=author), FlowVersionCreate(langflow_json=doc, author=author),
version_no=version_no,
) )
if version.version_no != version_no: # pragma: no cover - lock prevents this
raise store.ConflictError(f"concurrent version write for flow {definition.id}")
version = store.mark_deployed(session, version, uploaded.id) version = store.mark_deployed(session, version, uploaded.id)
if latest is not None and latest.lfx_flow_id and latest.lfx_flow_id != uploaded.id: if latest is not None and latest.lfx_flow_id and latest.lfx_flow_id != uploaded.id:
try: try:
@ -186,6 +185,14 @@ async def sync_from_directory(
return report return report
def format_report(report: SyncReport) -> str:
"""One-line summary for startup/watcher logs (keeps main.py thin)."""
return (
f"+{len(report.added)} ~{len(report.updated)} -{len(report.deleted)} "
f"skipped={len(report.skipped)} errors={len(report.errors)}"
)
def default_session_factory() -> Callable[[], Session]: def default_session_factory() -> Callable[[], Session]:
return lambda: Session(get_engine()) return lambda: Session(get_engine())
@ -194,6 +201,27 @@ def default_lfx_factory() -> Callable[[], LfxClient]:
return lambda: LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None) return lambda: LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None)
async def sync_full_pass(
session: Session,
lfx: LfxClient,
langflow,
flows_dir: str | Path,
) -> SyncReport:
"""Single orchestration: Langflow pull -> files -> DB + LFX.
Shared by POST /api/flows/sync, CLI, and watcher-adjacent paths so the
full-pass logic lives once. Pull errors merge with sync errors.
"""
from .deploy import pull_all_from_langflow
flows_dir = Path(flows_dir)
pulled_result = await pull_all_from_langflow(langflow, flows_dir)
report = await sync_from_directory(session, lfx, flows_dir)
report.pulled = pulled_result["pulled"] # type: ignore[typeddict-item]
report.errors = {**pulled_result["errors"], **report.errors} # type: ignore[typeddict-item]
return report
def run_sync_blocking( def run_sync_blocking(
flows_dir: str | Path, flows_dir: str | Path,
*, *,
@ -211,7 +239,11 @@ def run_sync_blocking(
class _JsonFilter(DefaultFilter): class _JsonFilter(DefaultFilter):
def __call__(self, change, path: str) -> bool: # type: ignore[override] def __call__(self, change, path: str) -> bool: # type: ignore[override]
return super().__call__(change, path) and path.endswith(".json") if not (super().__call__(change, path) and path.endswith(".json")):
return False
# The ignore file itself is tiny; re-read per event so no restart
# is needed after editing it.
return Path(path).stem not in export.ignored_stems(Path(path).parent)
async def watch_forever( async def watch_forever(
@ -246,11 +278,4 @@ async def watch_forever(
except Exception: except Exception:
logger.exception("flow sync failed") logger.exception("flow sync failed")
continue continue
logger.info( logger.info("flow sync: %s", format_report(report))
"flow sync: +%d ~%d -%d skipped=%d errors=%d",
len(report.added),
len(report.updated),
len(report.deleted),
len(report.skipped),
len(report.errors),
)

View file

@ -4,13 +4,16 @@ from collections.abc import AsyncIterator
from contextlib import asynccontextmanager from contextlib import asynccontextmanager
from pathlib import Path from pathlib import Path
from fastapi import FastAPI from fastapi import FastAPI, Request
from fastapi.responses import JSONResponse
from slowapi.errors import RateLimitExceeded
from slowapi.middleware import SlowAPIMiddleware
from starlette.middleware.body_limit import RequestBodyLimitMiddleware from starlette.middleware.body_limit import RequestBodyLimitMiddleware
from .auth.api import access_router, auth_router from .auth.api import access_router, auth_router
from .flows.api import approvals_router, flows_router from .flows.api import approvals_router, flows_router, runs_router
from .flows.sync import run_sync_blocking, watch_forever from .flows.sync import format_report, run_sync_blocking, watch_forever
from .middleware import RunThrottleMiddleware, SecurityHeadersMiddleware from .middleware import SecurityHeadersMiddleware, limiter
from .settings import settings from .settings import settings
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@ -20,14 +23,7 @@ def _blocking_startup_sync() -> None:
"""One-shot reconciliation at startup (fresh session, never fatal).""" """One-shot reconciliation at startup (fresh session, never fatal)."""
try: try:
report = run_sync_blocking(Path(settings.flows_dir)) report = run_sync_blocking(Path(settings.flows_dir))
logger.info( logger.info("startup flow sync: %s", format_report(report))
"startup flow sync: +%d ~%d -%d skipped=%d errors=%d",
len(report.added),
len(report.updated),
len(report.deleted),
len(report.skipped),
len(report.errors),
)
for filename, reason in report.errors.items(): for filename, reason in report.errors.items():
logger.warning("startup flow sync: %s: %s", filename, reason) logger.warning("startup flow sync: %s: %s", filename, reason)
except FileNotFoundError as exc: except FileNotFoundError as exc:
@ -40,6 +36,10 @@ def _blocking_startup_sync() -> None:
async def lifespan(app: FastAPI) -> AsyncIterator[None]: async def lifespan(app: FastAPI) -> AsyncIterator[None]:
task: asyncio.Task | None = None task: asyncio.Task | None = None
stop: asyncio.Event | None = None stop: asyncio.Event | None = None
if not settings.jwt_secret:
# Fail-closed sessions need a signing secret; without one every
# login 500s. Warn loudly instead of crashing the whole API.
logger.error("JWT_SECRET is empty — logins will fail until it is set")
if settings.flows_watch_enabled: if settings.flows_watch_enabled:
await asyncio.to_thread(_blocking_startup_sync) await asyncio.to_thread(_blocking_startup_sync)
stop = asyncio.Event() stop = asyncio.Event()
@ -71,12 +71,23 @@ app = FastAPI(
# entrypoint.sh) trusts its forwarding headers so Secure cookies, client # entrypoint.sh) trusts its forwarding headers so Secure cookies, client
# IPs (throttle) and absolute URLs are correct. The API is not directly # IPs (throttle) and absolute URLs are correct. The API is not directly
# internet-reachable (proxy-only), so trusting them is safe. # internet-reachable (proxy-only), so trusting them is safe.
app.state.limiter = limiter
app.add_middleware(RequestBodyLimitMiddleware, max_body_size=settings.max_body_bytes) app.add_middleware(RequestBodyLimitMiddleware, max_body_size=settings.max_body_bytes)
app.add_middleware(RunThrottleMiddleware) app.add_middleware(SlowAPIMiddleware)
app.add_middleware(SecurityHeadersMiddleware) app.add_middleware(SecurityHeadersMiddleware)
@app.exception_handler(RateLimitExceeded)
async def _throttle_handler(request: Request, exc: RateLimitExceeded) -> JSONResponse:
response = JSONResponse({"detail": "too many runs, try again later"}, status_code=429)
retry_after = getattr(exc, "retry_after", None) or "60"
response.headers["Retry-After"] = str(retry_after)
return response
app.include_router(flows_router) app.include_router(flows_router)
app.include_router(approvals_router) app.include_router(approvals_router)
app.include_router(runs_router)
app.include_router(access_router) app.include_router(access_router)
app.include_router(auth_router) app.include_router(auth_router)

View file

@ -1,79 +1,59 @@
"""Edge hardening: run throttling, security headers. """Edge hardening: run throttling (slowapi), security headers (secure).
Body caps come from Starlette's RequestBodyLimitMiddleware (wired in Body caps come from Starlette's RequestBodyLimitMiddleware (wired in
main.py). All limits are settings-driven so tests can shrink them. State main.py). The run throttle is settings-driven so tests can shrink it.
is in-process memory: correct for the single-replica SQLite deployment; State is in-process memory: correct for the single-replica SQLite
revisit with Redis if the API ever scales horizontally. deployment; revisit with Redis if the API ever scales horizontally.
""" """
from __future__ import annotations from __future__ import annotations
import time from slowapi import Limiter
from collections import defaultdict from slowapi.util import get_remote_address
from starlette.datastructures import MutableHeaders from starlette.datastructures import MutableHeaders
from starlette.requests import Request
from starlette.responses import JSONResponse
from starlette.types import ASGIApp, Message, Receive, Scope, Send from starlette.types import ASGIApp, Message, Receive, Scope, Send
from app.settings import settings from app.settings import settings
# POST .../run is the expensive endpoint (LFX execution, LLM cost): # POST .../run is the expensive endpoint (LFX execution, LLM cost):
# per client IP and minute. # per client IP and minute, limit read live from settings so tests can
RUN_PATH_SUFFIX = "/run" # shrink it without re-creating the app.
THROTTLE_WINDOW_SECONDS = 60.0 limiter = Limiter(
key_func=get_remote_address,
storage_uri="memory://",
default_limits=[],
)
_hits: dict[str, list[float]] = defaultdict(list)
def run_limit() -> str:
return f"{settings.run_throttle_per_minute}/minute"
def reset_throttle() -> None: def reset_throttle() -> None:
"""Drop all counters (tests).""" """Drop all counters (tests)."""
_hits.clear() try:
limiter._storage.reset() # type: ignore[attr-defined]
except AttributeError:
def _client_ip(request: Request) -> str: pass
# Behind the TLS proxy ProxyHeadersMiddleware has already rewritten
# scope["client"] from X-Forwarded-For.
if request.client is not None:
return request.client.host
forwarded = request.headers.get("x-forwarded-for", "")
return forwarded.split(",")[0].strip() or "unknown"
class RunThrottleMiddleware:
"""Per-IP sliding window on POST .../run (429 + Retry-After)."""
def __init__(self, app: ASGIApp) -> None:
self.app = app
async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
if (
scope["type"] != "http"
or scope.get("method") != "POST"
or not scope.get("path", "").endswith(RUN_PATH_SUFFIX)
):
await self.app(scope, receive, send)
return
request = Request(scope)
now = time.monotonic()
window_start = now - THROTTLE_WINDOW_SECONDS
bucket = [t for t in _hits[_client_ip(request)] if t > window_start]
if len(bucket) >= settings.run_throttle_per_minute:
retry_after = max(1, int(bucket[0] + THROTTLE_WINDOW_SECONDS - now))
response = JSONResponse({"detail": "too many runs, try again later"}, status_code=429)
response.headers["Retry-After"] = str(retry_after)
await response(scope, receive, send)
return
bucket.append(now)
_hits[_client_ip(request)] = bucket
await self.app(scope, receive, send)
class SecurityHeadersMiddleware: class SecurityHeadersMiddleware:
"""Baseline response headers (TLS/HSTS live on the proxy).""" """Baseline response headers (TLS/HSTS live on the proxy).
Built with the ``secure`` package; values stay byte-identical to the
previous hand-rolled version (see test_middleware).
"""
def __init__(self, app: ASGIApp) -> None: def __init__(self, app: ASGIApp) -> None:
import secure as secure_lib
self.app = app self.app = app
self.secure_headers = secure_lib.Secure(
xcto=secure_lib.XContentTypeOptions().nosniff(),
xfo=secure_lib.XFrameOptions().sameorigin(),
referrer=secure_lib.ReferrerPolicy().strict_origin_when_cross_origin(),
csp=secure_lib.ContentSecurityPolicy().frame_ancestors("'self'"),
)
async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
if scope["type"] != "http": if scope["type"] != "http":
@ -83,10 +63,8 @@ class SecurityHeadersMiddleware:
async def secured(message: Message) -> None: async def secured(message: Message) -> None:
if message["type"] == "http.response.start": if message["type"] == "http.response.start":
headers = MutableHeaders(raw=message.setdefault("headers", [])) headers = MutableHeaders(raw=message.setdefault("headers", []))
headers["X-Content-Type-Options"] = "nosniff" for key, value in self.secure_headers.headers.items():
headers["X-Frame-Options"] = "SAMEORIGIN" headers[key] = value
headers["Referrer-Policy"] = "strict-origin-when-cross-origin"
headers["Content-Security-Policy"] = "frame-ancestors 'self'"
await send(message) await send(message)
await self.app(scope, receive, secured) await self.app(scope, receive, secured)

View file

@ -1,5 +1,5 @@
from .flow import ApprovalTask, FlowDefinition, FlowRun, FlowVersion from .flow import ApprovalTask, FlowDefinition, FlowRun, FlowVersion
from .user import AccessRequest, MagicLinkToken, User, UserSession from .user import AccessRequest, MagicLinkToken, User
__all__ = [ __all__ = [
"AccessRequest", "AccessRequest",
@ -9,5 +9,4 @@ __all__ = [
"FlowVersion", "FlowVersion",
"MagicLinkToken", "MagicLinkToken",
"User", "User",
"UserSession",
] ]

View file

@ -0,0 +1,18 @@
"""Shared SQLModel base: UTC timestamps, no copy-paste across models."""
from datetime import UTC, datetime
from sqlalchemy import Column, DateTime
from sqlmodel import Field
def utcnow() -> datetime:
return datetime.now(UTC)
def ts_column() -> Column:
return Column(DateTime(timezone=True))
def ts_field(*, default_factory=utcnow) -> datetime: # type: ignore[no-untyped-def]
return Field(default_factory=default_factory, sa_column=ts_column())

View file

@ -1,18 +1,12 @@
"""Flow engine domain models (SQLModel tables).""" """Flow engine domain models (SQLModel tables)."""
from datetime import UTC, datetime from datetime import datetime
from uuid import UUID, uuid4 from uuid import UUID, uuid4
from sqlalchemy import JSON, Column, DateTime, UniqueConstraint from sqlalchemy import JSON, Column, UniqueConstraint
from sqlmodel import Field, SQLModel from sqlmodel import Field, SQLModel
from .base import ts_column, utcnow
def utcnow() -> datetime:
return datetime.now(UTC)
def _ts_column() -> Column:
return Column(DateTime(timezone=True))
def _json_column() -> Column: def _json_column() -> Column:
@ -34,7 +28,7 @@ class FlowDefinition(SQLModel, table=True):
source_path: str | None = Field(default=None, max_length=255) source_path: str | None = Field(default=None, max_length=255)
# Flow to run after a human approval on this flow's runs (nullable). # Flow to run after a human approval on this flow's runs (nullable).
continuation_flow_id: UUID | None = Field(default=None, foreign_key="flow_definitions.id") continuation_flow_id: UUID | None = Field(default=None, foreign_key="flow_definitions.id")
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column()) created_at: datetime = Field(default_factory=utcnow, sa_column=ts_column())
class FlowVersion(SQLModel, table=True): class FlowVersion(SQLModel, table=True):
@ -49,12 +43,12 @@ class FlowVersion(SQLModel, table=True):
langflow_json: dict = Field(default_factory=dict, sa_column=_json_column()) langflow_json: dict = Field(default_factory=dict, sa_column=_json_column())
# Flow id under which LFX serves this version (set on deploy). # Flow id under which LFX serves this version (set on deploy).
lfx_flow_id: str | None = Field(default=None, max_length=200) lfx_flow_id: str | None = Field(default=None, max_length=200)
deployed_at: datetime | None = Field(default=None, sa_column=_ts_column()) deployed_at: datetime | None = Field(default=None, sa_column=ts_column())
author: str = Field(default="", max_length=200) author: str = Field(default="", max_length=200)
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column()) created_at: datetime = Field(default_factory=utcnow, sa_column=ts_column())
# Cached form schema for this exact JSON (see app/flows/input_schema.py). # Cached form schema for this exact JSON (see app/flows/input_schema.py).
# Computed at version creation; nullable for pre-Phase-3 rows. # Computed at version creation; backfilled NOT NULL (e8f3a1c2b4d6).
input_schema: dict | None = Field(default=None, sa_column=_json_column()) input_schema: dict = Field(default_factory=dict, sa_column=Column(JSON, nullable=False))
class FlowRun(SQLModel, table=True): class FlowRun(SQLModel, table=True):
@ -70,8 +64,8 @@ class FlowRun(SQLModel, table=True):
input: dict | None = Field(default=None, sa_column=_json_column()) input: dict | None = Field(default=None, sa_column=_json_column())
output: dict | None = Field(default=None, sa_column=_json_column()) output: dict | None = Field(default=None, sa_column=_json_column())
session_id: str | None = Field(default=None, max_length=200) session_id: str | None = Field(default=None, max_length=200)
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column()) created_at: datetime = Field(default_factory=utcnow, sa_column=ts_column())
finished_at: datetime | None = Field(default=None, sa_column=_ts_column()) finished_at: datetime | None = Field(default=None, sa_column=ts_column())
class ApprovalTask(SQLModel, table=True): class ApprovalTask(SQLModel, table=True):
@ -90,5 +84,5 @@ class ApprovalTask(SQLModel, table=True):
# open | approved | rejected # open | approved | rejected
status: str = Field(default="open", index=True, max_length=20) status: str = Field(default="open", index=True, max_length=20)
decision_note: str = Field(default="", max_length=2000) decision_note: str = Field(default="", max_length=2000)
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column()) created_at: datetime = Field(default_factory=utcnow, sa_column=ts_column())
decided_at: datetime | None = Field(default=None, sa_column=_ts_column()) decided_at: datetime | None = Field(default=None, sa_column=ts_column())

View file

@ -1,18 +1,11 @@
"""Access-management domain models (SQLModel tables).""" """Access-management domain models (SQLModel tables)."""
from datetime import UTC, datetime from datetime import datetime
from uuid import UUID, uuid4 from uuid import UUID, uuid4
from sqlalchemy import Column, DateTime
from sqlmodel import Field, SQLModel from sqlmodel import Field, SQLModel
from .base import ts_column, utcnow
def utcnow() -> datetime:
return datetime.now(UTC)
def _ts_column() -> Column:
return Column(DateTime(timezone=True))
class User(SQLModel, table=True): class User(SQLModel, table=True):
@ -26,7 +19,7 @@ class User(SQLModel, table=True):
# member | admin # member | admin
role: str = Field(default="member", max_length=20) role: str = Field(default="member", max_length=20)
tenant_id: str = Field(default="default", max_length=200) tenant_id: str = Field(default="default", max_length=200)
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column()) created_at: datetime = Field(default_factory=utcnow, sa_column=ts_column())
class AccessRequest(SQLModel, table=True): class AccessRequest(SQLModel, table=True):
@ -40,8 +33,8 @@ class AccessRequest(SQLModel, table=True):
reason: str = Field(default="", max_length=2000) reason: str = Field(default="", max_length=2000)
# pending | approved | rejected # pending | approved | rejected
status: str = Field(default="pending", index=True, max_length=20) status: str = Field(default="pending", index=True, max_length=20)
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column()) created_at: datetime = Field(default_factory=utcnow, sa_column=ts_column())
decided_at: datetime | None = Field(default=None, sa_column=_ts_column()) decided_at: datetime | None = Field(default=None, sa_column=ts_column())
decided_by: str | None = Field(default=None, max_length=320) decided_by: str | None = Field(default=None, max_length=320)
@ -53,20 +46,8 @@ class MagicLinkToken(SQLModel, table=True):
id: UUID = Field(default_factory=uuid4, primary_key=True) id: UUID = Field(default_factory=uuid4, primary_key=True)
user_id: UUID = Field(foreign_key="users.id", index=True) user_id: UUID = Field(foreign_key="users.id", index=True)
token_hash: str = Field(index=True, unique=True, max_length=64) token_hash: str = Field(index=True, unique=True, max_length=64)
expires_at: datetime = Field(sa_column=_ts_column()) expires_at: datetime = Field(sa_column=ts_column())
# Set before the session row is created, so a reused token can never # Set before the session JWT is minted, so a reused token can never
# mint a second session. # mint a second session.
used_at: datetime | None = Field(default=None, sa_column=_ts_column()) used_at: datetime | None = Field(default=None, sa_column=ts_column())
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column()) created_at: datetime = Field(default_factory=utcnow, sa_column=ts_column())
class UserSession(SQLModel, table=True):
"""An opaque session id in the DB (cookie value). Revocable, expirable."""
__tablename__ = "user_sessions"
id: str = Field(primary_key=True, max_length=128)
user_id: UUID = Field(foreign_key="users.id", index=True)
created_at: datetime = Field(default_factory=utcnow, sa_column=_ts_column())
expires_at: datetime = Field(sa_column=_ts_column())
revoked_at: datetime | None = Field(default=None, sa_column=_ts_column())

View file

@ -1,5 +1,6 @@
from pathlib import Path from pathlib import Path
from pydantic import computed_field
from pydantic_settings import BaseSettings, SettingsConfigDict from pydantic_settings import BaseSettings, SettingsConfigDict
# Repo-root .env (shared with the compose stack). Real environment variables # Repo-root .env (shared with the compose stack). Real environment variables
@ -41,7 +42,9 @@ class Settings(BaseSettings):
run_throttle_per_minute: int = 60 run_throttle_per_minute: int = 60
# --- access management (magic-link auth, see app/auth) --- # --- access management (magic-link auth, see app/auth) ---
# Public frontend URL (magic links point at /login?token= there). # Secret signing session JWTs (stateless cookies). Long random value;
# empty fails closed at login time — set it in prod (.env JWT_SECRET).
jwt_secret: str = "" # Public frontend URL (magic links point at /login?token= there).
frontend_url: str = "http://localhost:3000" frontend_url: str = "http://localhost:3000"
# Comma-separated emails that become admins (role assignment + bootstrap). # Comma-separated emails that become admins (role assignment + bootstrap).
admin_emails: str = "" admin_emails: str = ""
@ -53,6 +56,7 @@ class Settings(BaseSettings):
smtp_username: str = "" smtp_username: str = ""
smtp_password: str = "" smtp_password: str = ""
@computed_field # type: ignore[misc]
@property @property
def admin_email_list(self) -> list[str]: def admin_email_list(self) -> list[str]:
return [e.strip().lower() for e in self.admin_emails.split(",") if e.strip()] return [e.strip().lower() for e in self.admin_emails.split(",") if e.strip()]

View file

@ -8,44 +8,209 @@ derives a JSON Schema + uiSchema from the node's template
## Adding a new form field ## Adding a new form field
1. Open the Langflow authoring UI (http://localhost:7860) and load the 1. Open the Langflow authoring UI (http://localhost:7860) and load the
flow from `LANGFLOW_LOAD_FLOWS_PATH` (canonical files are preloaded). flow from `LANGFLOW_LOAD_FLOWS_PATH` (canonical files are preloaded).
2. Edit the `CustomInputForm` node: every entry in its `inputs` list is 2. Edit the `CustomInputForm` node **in its code editor**: every entry in
one web-form field. Add an `lfx.io` input, e.g. its `inputs` list is one web-form field. Add an `lfx.io` input, e.g.
```python ```python
from lfx.io import DropdownInput from lfx.io import DropdownInput
DropdownInput( DropdownInput(
name="room", # JSON-Schema property key name="room", # JSON-Schema property key (freely renamable)
display_name="Room", # form label (title) display_name="Room", # form label (title)
info="Where should it take place", # help text (description) info="Where should it take place", # help text (description)
options=["Chapel", "Hall"], # dropdown choices (enum) options=["Chapel", "Hall"], # dropdown choices (enum)
value="Chapel", # prefill (default) value="Chapel", # prefill (default)
required=True, # marks the field required required=True, # marks the field required
) )
``` ```
Supported input types → widgets: `StrInput`/`MessageTextInput` → text, Supported input types → widgets: `StrInput`/`MessageTextInput` → text,
`MultilineInput` → textarea, `SecretStrInput` → password, `MultilineInput` → textarea, `SecretStrInput` → password,
`IntInput` → integer, `FloatInput` → number, `BoolInput` → checkbox, `IntInput` → integer, `FloatInput` → number, `BoolInput` → checkbox,
`DropdownInput` → select, `MultiselectInput` → multi-select, `DropdownInput` → select, `MultiselectInput` → multi-select,
`SliderInput` → slider (needs `range_spec`), `FileInput` → text stub `SliderInput` → slider (needs `range_spec`), `FileInput` → text stub
(real upload later). (real upload later).
3. Add the new field to `collect()` so it reaches the JSON output. 3. Nothing else to change in code: `collect()` is dynamic — it emits
every input except the plumbing ones, so renames, additions, and
removals just work. (The inspector panel can tweak `display_name`,
`info`, `value`, and `options` of existing fields, but `name` and new
fields need the code editor.)
4. **Wire the envelope**: keep the `ChatInput → form_values` edge (hidden 4. **Wire the envelope**: keep the `ChatInput → form_values` edge (hidden
input, `show=False`). Submitted web-form values arrive there as input, `show=False`). Submitted web-form values arrive there as
`{"payload": {...}}` and are merged over the defaults. Never make form `{"payload": {...}}` and are merged over the defaults — including keys
fields required *with* an incoming edge — that's the envelope's job. the node code does not declare (forward-compatible with renames).
Never make form fields required *with* an incoming edge — that's the
envelope's job.
5. Export the flow (JSON) into `backend/flows/<name>.json` and commit. 5. Export the flow (JSON) into `backend/flows/<name>.json` and commit.
The API watcher syncs + deploys it automatically; the form schema is The API watcher syncs + deploys it automatically; the form schema is
regenerated per version. regenerated per version.
## Structured `visible_if` (preferred) + markers (fallback)
A field can appear only when other fields have certain values — nested
to any depth. Preferred: structured `visible_if` key (no quoting
mini-language, rename-refactorable, validated at sync time with warnings
instead of silent fail-open):
```python
(
DropdownInput(
name="bestandteil",
display_name="Welcher Bestandteil der Kirche?",
options=["Glocke", "Orgel"],
value=[],
info="Mehrfachauswahl möglich",
visible_if=[{"field": "gebaeude", "value": "Kirche"}],
required=True,
),
)
```
Legacy `[visible_if ...]` markers in `info` still work as deprecated
fallback (same syntax, stripped from help text). The parser emits
`allOf`/`if`/`then` branches either way (see below).
```python
(
DropdownInput(
name="gebaeude",
display_name="Welches Gebäude soll verändert werden?",
options=["Kirche", "Anderes Gebäude"],
value="Kirche",
required=True,
),
)
(
MultiselectInput(
name="bestandteil",
display_name="Welcher Bestandteil der Kirche?",
options=["Glocke", "Orgel", "Innenraum", "Fenster", "Fassade"],
value=[],
info="Mehrfachauswahl möglich [visible_if gebaeude=Kirche]",
required=True,
),
)
(
DropdownInput(
name="glockenmassnahme",
display_name="Welche Maßnahme an der Glocke?",
options=["Reinigung", "Reparatur", "Neuguss"],
value="Reinigung",
info="[visible_if bestandteil=Glocke]",
),
)
```
Syntax: `[visible_if <feld>=<wert>]`, `&` for AND
(`[visible_if a=X & b=Y]`), double quotes for values with spaces
(`[visible_if gebaeude="Anderes Gebäude"]`). Trigger matching by input
type: Dropdown/Text `const`, Bool `const` (`true`/`false`), Multiselect
`contains`, Int/Float exact number. Nesting is automatic: a field whose
trigger is itself conditional renders one level deeper, without limit.
What the parser does with markers:
- The marker is stripped from the shown help text; the field leaves the
top-level schema and lives only in its `allOf`/`if`/`then` branch, so
RJSF hides it until the condition holds. `ui:order` keeps template
order, so new questions appear directly below their trigger.
- `required` on a branched field applies only while visible.
- Values are always kept: hidden fields still validate and are submitted
(stale values can keep deeper branches satisfied until changed).
- Safety is fail-open: unknown triggers (renamed?), unsupported trigger
types, self-references, and trigger cycles keep the field always
visible instead of hiding data. Renaming a trigger means updating its
markers.
See `backend/flows/bauvorhaben.json` for a full 4-level example
(Gebäude → Bestandteil → Maßnahme → Gussjahr, plus sibling branch and
bool trigger).
## User-built form components (no kirche base needed)
A plain `CustomComponent` whose display name ends with `"Form"` is also
parsed into a web form — same template contract, no base class. To make
submitted values reach it at runtime, add an envelope input and merge it
in the output method (pattern):
```python
from lfx.io import MessageTextInput # add to imports
import json
# add to inputs:
MessageTextInput(name="form_values", display_name="Form values", value="", show=False)
# at the top of the output method:
try:
raw = self.form_values.text if hasattr(self.form_values, "text") else self.form_values
submitted = json.loads(raw or "{}")
except Exception:
submitted = {}
if isinstance(submitted.get("payload"), dict):
submitted = submitted["payload"]
def val(name, default):
return submitted.get(name, default)
```
Then use `val("rolle", self.rolle)` etc., and wire a `ChatInput` node
into `form_values` on the canvas. Branch markers (`[visible_if ...]`
in `info`) work here too — the parser reads the template only.
## Asked fields only (run envelope `fields`)
The API sends the asked field names (from the version's form schema)
in the run envelope's `fields` list. `collect()` then emits defaults
only for asked AND currently visible fields (branch conditions are
evaluated against submitted values over code defaults, so hidden
fields stay out exactly as the frontend never submits them): the
template may declare fields unknown to this code (they arrive via
envelope and merge normally), and unasked code defaults stay out of
the output. Without the list — raw dicts, Langflow playground — all
visible declared defaults apply as before.
## Variant flows (own component per flow, shared core)
A flow whose fields differ from `CustomInputForm` gets its own thin
component (see `bauvorhaben_form.py` → "Bauvorhaben Form" in the
palette): same class pattern, own `inputs` list, shared runtime from
`kirche._form_core` (`from kirche._form_core import ...` plus the
`# <-- _form_core inlined ... -->` marker). The LFX runtime executes
the embedded module source without our `kirche` package, so
`scripts/make_flow_fixtures.py:kirche_node()` inlines the core into the
exported `code` — one truth in the repo, self-contained JSON. Copy the
file as the starting point for future forms.
Rule: code-declared inputs must equal template fields
(`test_embedded_code_matches_template_fields` enforces it, plus
no-sibling-import + core-present asserts; required Multiselect uses
the `[" "]` sentinel). Generate node + flow with `kirche_node(...)`
(which composes thin source + `_inline_core()` automatically) and
`build_bauvorhaben()` in `backend/scripts/make_flow_fixtures.py`
rather than hand-editing JSON. Restart Langflow afterwards so the
palette picks up the new component, then build/upload the flow.
## Output type: Data (JSON), not Message
`collect()` returns `Data(data={...})` — a real JSON object. Consequences:
- A terminal `ChatOutput` renders it as a fenced ```json block; the run
result text is that block, not raw JSON (unwrap before `json.loads`).
- Components consuming `form_data` should read `.data` (or `get_text()`),
not `.text` like with `Message`.
## Conventions the pipeline relies on ## Conventions the pipeline relies on
- `required=True` on a template field: `lfx validate --level 4` demands a - `required=True` on a template field: `lfx validate --level 4` demands a
value or an edge, so the canonical-flow generator value or an edge, so the canonical-flow generator
(`backend/scripts/make_flow_fixtures.py`) writes a single-space (`backend/scripts/make_flow_fixtures.py`) writes a single-space
sentinel value for such fields. The form parser treats whitespace-only sentinel value for such fields (`[" "]` for Multiselect, which rejects
a plain string at runtime). The form parser treats whitespace-only
values as "no default" — don't ship real whitespace defaults. values as "no default" — don't ship real whitespace defaults.
- Field key = `name` (stable); label = `display_name`; help = `info`. - Field key = `name` (stable, freely renamable but must stay unique and
non-empty; collisions get a `_2`/`_3` suffix in the form schema);
label = `display_name`; help = `info`. Renames propagate to downstream
components, which read the JSON keys as-is.
- Unknown future input types degrade to a plain text field in the web - Unknown future input types degrade to a plain text field in the web
form (parser fallback), so adding exotic lfx inputs never breaks runs. form (parser fallback), so adding exotic lfx inputs never breaks runs.
@ -56,3 +221,9 @@ canonical + test-fixture exports:
docker compose exec api /opt/venv/bin/python scripts/make_flow_fixtures.py docker compose exec api /opt/venv/bin/python scripts/make_flow_fixtures.py
docker compose exec -T api uv run pytest tests/test_lfx_validate.py docker compose exec -T api uv run pytest tests/test_lfx_validate.py
Notes: the generator writes UTF-8/LF explicitly (Windows-safe), and
`backend/flows/*.json` may carry Langflow round-trip state (key order)
the generator does not reproduce — if a regen rewrites canonical files
beyond the component's own node, revert them and splice only the changed
node fields (code, description, output types, edge handles) instead.

View file

@ -7,6 +7,8 @@ template into a web form (``app/flows/input_schema.py``); the frontend
renders that schema with RJSF. renders that schema with RJSF.
""" """
from .bauvorhaben_form import CustomInputBauvorhaben
from .form_inputs import CustomInputForm from .form_inputs import CustomInputForm
from .mitarbeiter_form import CustomInputMitarbeiter
__all__ = ["CustomInputForm"] __all__ = ["CustomInputBauvorhaben", "CustomInputForm", "CustomInputMitarbeiter"]

View file

@ -0,0 +1,147 @@
"""Shared form runtime core (single source, codegen-inlined for LFX).
The LFX runtime executes embedded module source without our ``kirche``
package, so flow JSON must stay self-contained. Author components against
this module (``from kirche._form_core import ...`` or ``from ._form_core``
); ``scripts/make_flow_fixtures.py:kirche_node()`` inlines this file's text
into the exported ``code`` so the runtime keeps working with one truth in
the repo.
Supports both the legacy ``[visible_if feld=Wert]`` marker in ``info``
and the structured ``visible_if`` key (list of {field, value} or dict):
structured wins when present, markers stay as deprecated fallback.
"""
from __future__ import annotations
import json
import re
_VISIBLE_RE = re.compile(r"\[visible_if\s+([^\]]+)\]")
#: Reserved input carrying the run envelope — never a form field name.
PLUMBING_INPUTS = frozenset({"form_values", "code"})
def _text(value) -> str:
if value is None:
return ""
if hasattr(value, "text"):
return value.text or ""
return str(value)
def _json_safe(value):
"""Plain JSON value: unwrap LFX wrappers, keep scalars."""
if value is None or isinstance(value, (bool, int, float, str)):
return value
if isinstance(value, list):
return [_json_safe(item) for item in value]
if isinstance(value, dict):
return {str(key): _json_safe(item) for key, item in value.items()}
text = getattr(value, "text", None)
if isinstance(text, str):
return text
data = getattr(value, "data", None)
if isinstance(data, dict):
return _json_safe(data)
return str(value)
def _split_conditions(text: str) -> list:
parts: list = []
buf: list = []
quoted = False
for char in text:
if char == '"':
quoted = not quoted
buf.append(char)
elif char == "&" and not quoted:
parts.append("".join(buf))
buf = []
else:
buf.append(char)
parts.append("".join(buf))
return [part.strip() for part in parts if part.strip()]
def _parse_condition(token: str):
field, sep, value = token.partition("=")
field, value = field.strip(), value.strip()
if not sep or not field or not value:
return None
if len(value) >= 2 and value.startswith('"') and value.endswith('"'):
value = value[1:-1]
lowered = value.lower()
if lowered == "true":
return field, True
if lowered == "false":
return field, False
try:
return field, int(value)
except ValueError:
pass
try:
return field, float(value)
except ValueError:
pass
return field, value
def _field_conditions(info: object, structured=None) -> list:
"""[(trigger, value)] from structured key or info markers.
Structured ``visible_if`` (list of ``{field, value}`` or ``{field: value}``
dict) wins; legacy ``[visible_if ...]`` markers in ``info`` stay as
deprecated fallback.
"""
if structured:
conditions: list = []
items = structured.items() if isinstance(structured, dict) else structured
for item in items or []:
if isinstance(item, dict) and "field" in item:
conditions.append((item["field"], item.get("value")))
elif isinstance(item, (list, tuple)) and len(item) == 2:
conditions.append((item[0], item[1]))
if conditions:
return conditions
conditions = []
def _collect(match) -> str:
for token in _split_conditions(match.group(1)):
parsed = _parse_condition(token)
if parsed is not None:
conditions.append(parsed)
return ""
_VISIBLE_RE.sub(_collect, info if isinstance(info, str) else "")
return conditions
def collect_form_data(field_names: list, field_values: dict, payload: dict, asked=None) -> dict:
"""Shared collect(): effective values, visibility scope, submitted wins."""
effective = dict(field_values)
for key, val in payload.items():
if isinstance(key, str) and key:
effective[key] = _json_safe(val)
scope = [n for n in (asked if asked is not None else field_names) if n in field_names]
return effective, scope
def parse_envelope(text_value) -> tuple[dict, list | None]:
"""(payload, asked-fields) from the run envelope text."""
try:
envelope = json.loads(_text(text_value) or "{}")
except (json.JSONDecodeError, ValueError, AttributeError):
return {}, None
if not isinstance(envelope, dict):
return {}, None
if isinstance(envelope.get("payload"), dict):
fields = envelope.get("fields")
asked = (
[i for i in fields if i]
if isinstance(fields, list) and all(isinstance(i, str) for i in fields)
else None
)
return envelope["payload"], asked
return envelope, None

View file

@ -0,0 +1,202 @@
"""Bauvorhaben form component for kirche-einfach flows.
Thin variant: shared runtime lives in ``kirche._form_core`` (imported here
for the Langflow palette); ``scripts/make_flow_fixtures.py:kirche_node()``
inlines the core into the exported ``code`` so the LFX runtime stays
self-contained. Copy this file as the starting point for future forms.
A flow that starts with :class:`CustomInputBauvorhaben` declares the
fields of its web form. The API reads the exported node template
(``template`` minus ``code``) and derives ``{json_schema, ui_schema}``
from the ``lfx.io`` input definitions below — one JSON-Schema property
per field, keyed by ``name``:
* ``display_name`` → ``title``, ``info`` → ``description``
(``[visible_if ...]`` markers declare conditional branches, see below),
``value`` → ``default``, ``options`` → ``enum``
* ``required`` → required array (branch-required applies only while visible)
``collect()`` is fully dynamic: it emits every input except the plumbing
one (``form_values``), so fields can be renamed, added, or removed in
the Langflow code editor without touching this method.
When the run envelope names the asked fields (``fields`` list, sent by
the API from the version's form schema), defaults are emitted only for
asked AND currently visible fields. Without the list (raw dict,
Langflow playground), all visible declared defaults apply.
``collect()`` returns ``Data`` (the LFX JSON type), not ``Message``.
"""
from __future__ import annotations
import json # noqa: F401 -- used by inlined _form_core at runtime
import re # noqa: F401 -- used by inlined _form_core at runtime
from typing import ClassVar
from lfx.custom import Component
from lfx.io import (
BoolInput,
DropdownInput,
IntInput,
MessageTextInput,
MultiselectInput,
Output,
StrInput,
)
from lfx.schema.data import Data
from kirche._form_core import (
PLUMBING_INPUTS,
_field_conditions,
_json_safe,
collect_form_data,
parse_envelope,
)
# <-- _form_core inlined by scripts/make_flow_fixtures.py:kirche_node()
# (LFX executes embedded source without the kirche package) -->
class CustomInputBauvorhaben(Component):
display_name = "Bauvorhaben Form"
description = "Collects Bauvorhaben form values into a single JSON object."
icon = "Church"
inputs: ClassVar[list] = [
# Plumbing, not a form field: the API posts submitted web-form
# values as the run envelope (same {"payload": {...}} shape the
# other kirche components use); they arrive here through a ChatInput
# entry node and override the defaults below. Hidden in the GUI and
# skipped by the form parser (show=False).
MessageTextInput(
name="form_values",
display_name="Form values (JSON envelope)",
info="Submitted values as JSON; merged over the defaults",
value="",
show=False,
),
DropdownInput(
name="gebaeude",
display_name="Welches Gebäude soll verändert werden?",
info="",
options=["Kirche", "Anderes Gebäude"],
value="",
required=True,
),
MultiselectInput(
name="bestandteil",
display_name="Welcher Bestandteil der Kirche?",
info="Mehrfachauswahl möglich [visible_if gebaeude=Kirche]",
options=["Glocke", "Orgel", "Innenraum", "Fenster", "Fassade"],
value=[],
required=True,
),
DropdownInput(
name="glockenmassnahme",
display_name="Welche Maßnahme an der Glocke?",
info="[visible_if bestandteil=Glocke]",
options=["Reinigung", "Reparatur", "Neuguss"],
value="Reinigung",
),
IntInput(
name="gussjahr",
display_name="Gussjahr (nur bei Neuguss)?",
info="[visible_if glockenmassnahme=Neuguss]",
value=0,
),
DropdownInput(
name="gebaeudeart",
display_name="Art des anderen Gebäudes?",
info='[visible_if gebaeude="Anderes Gebäude"]',
options=["Wohnhaus", "Scheune", "Sonstiges"],
value="Wohnhaus",
),
BoolInput(
name="denkmalschutz",
display_name="Steht das Gebäude unter Denkmalschutz?",
info="",
value=False,
),
StrInput(
name="denkmalnummer",
display_name="Aktenzeichen Denkmalschutz?",
info="[visible_if denkmalschutz=true]",
value="",
required=True,
),
]
outputs: ClassVar[list] = [
Output(display_name="Form Data", name="form_data", method="collect"),
]
def _field_names(self) -> list:
"""Names of all form fields (every input except the plumbing ones)."""
inputs = getattr(self, "_inputs", None)
if isinstance(inputs, dict) and inputs:
return [name for name in inputs if name not in PLUMBING_INPUTS]
seen = []
declared = getattr(self, "inputs", None) or getattr(type(self), "inputs", None) or []
for inp in declared:
name = getattr(inp, "name", None)
if name and name not in PLUMBING_INPUTS and name not in seen:
seen.append(name)
return seen
def _field_value(self, name: str):
"""Runtime value of one input.
Reads ``_inputs`` directly: a field renamed to e.g. ``name`` would
otherwise resolve to the component attribute instead of its value.
"""
inputs = getattr(self, "_inputs", None)
if isinstance(inputs, dict) and name in inputs:
return getattr(inputs[name], "value", None)
try:
return getattr(self, name, None)
except (AttributeError, ValueError):
return None
def _is_visible(self, name: str, effective: dict) -> bool:
"""Whether a field's branch conditions hold.
Single pass over effective values (submitted first, code defaults
after): no recursion, so trigger cycles cannot hang — a stale or
cyclic marker simply matches or not. Unknown triggers never match.
"""
inputs = getattr(self, "_inputs", None)
info = ""
structured = None
if isinstance(inputs, dict) and name in inputs:
info = getattr(inputs[name], "info", "") or ""
structured = getattr(inputs[name], "visible_if", None)
for trigger, expected in _field_conditions(info, structured):
if trigger == name or trigger not in effective:
# Self-reference or unknown trigger: fail open (visible),
# mirroring the backend parser.
continue
actual = effective[trigger]
if isinstance(actual, list):
if expected not in actual:
return False
elif actual != expected:
return False
return True
def collect(self) -> Data:
payload, asked = parse_envelope(self.form_values)
# Effective trigger values: submitted first, code defaults after.
declared = self._field_names()
field_values = {name: _json_safe(self._field_value(name)) for name in declared}
effective, scope = collect_form_data(declared, field_values, payload, asked)
# Defaults only for asked AND visible fields (hidden branch fields
# stay out, like the frontend never submits them); without an asked
# list, all visible declared fields (Langflow playground).
data = {name: effective[name] for name in scope if self._is_visible(name, effective)}
# Submitted values win over the field defaults. Unknown keys are
# kept: the frontend may already know renamed fields this code
# revision does not declare.
for key, val in payload.items():
if isinstance(key, str) and key:
data[key] = _json_safe(val)
return Data(data=data)

View file

@ -11,13 +11,31 @@ keyed by ``name``. Field metadata maps as follows:
* ``required`` → required array, ``advanced`` → ``ui:collapsed`` hint * ``required`` → required array, ``advanced`` → ``ui:collapsed`` hint
* ``_input_type`` → JSON type + widget (see ``app/flows/input_schema.py``) * ``_input_type`` → JSON type + widget (see ``app/flows/input_schema.py``)
``collect()`` is fully dynamic: it emits every input except the plumbing
ones (``form_values``, ``code``), so fields can be renamed, added, or
removed in the Langflow code editor without touching this method.
``name`` is the stable JSON key (freely renamable, must stay unique and
non-empty); downstream components read the keys as-is.
When the run envelope names the asked fields (``fields`` list, sent by
the API from the version's form schema), defaults are emitted only for
asked fields — the template may declare fields unknown to this code and
unasked code defaults stay out of the output. Without the list (raw dict,
Langflow playground), all declared defaults apply.
``collect()`` returns ``Data`` (the LFX JSON type), not ``Message``: the
values travel as a real JSON object. A terminal ``ChatOutput`` renders it
as a fenced ```json block; components consuming it should read ``.data``
(or ``get_text()``), not ``.text``.
``FileInput`` is a stub for now: it carries a string reference only, real ``FileInput`` is a stub for now: it carries a string reference only, real
upload comes later. upload comes later.
""" """
from __future__ import annotations from __future__ import annotations
import json import json # noqa: F401 -- used by inlined _form_core at runtime
import re # noqa: F401 -- used by inlined _form_core at runtime
from typing import ClassVar from typing import ClassVar
from lfx.custom import Component from lfx.custom import Component
@ -36,20 +54,23 @@ from lfx.io import (
SliderInput, SliderInput,
StrInput, StrInput,
) )
from lfx.schema.message import Message from lfx.schema.data import Data
from kirche._form_core import (
PLUMBING_INPUTS,
_field_conditions,
_json_safe,
collect_form_data,
parse_envelope,
)
def _text(value) -> str: # <-- _form_core inlined by scripts/make_flow_fixtures.py:kirche_node()
if value is None: # (LFX executes embedded source without the kirche package) -->
return ""
if hasattr(value, "text"):
return value.text or ""
return str(value)
class CustomInputForm(Component): class CustomInputForm(Component):
display_name = "CustomInput Form" display_name = "CustomInput Form"
description = "Collects structured form values into a single JSON message." description = "Collects structured form values into a single JSON object."
icon = "ClipboardList" icon = "ClipboardList"
inputs: ClassVar[list] = [ inputs: ClassVar[list] = [
@ -134,29 +155,73 @@ class CustomInputForm(Component):
Output(display_name="Form Data", name="form_data", method="collect"), Output(display_name="Form Data", name="form_data", method="collect"),
] ]
def collect(self) -> Message: def _field_names(self) -> list:
data = { """Names of all form fields (every input except the plumbing ones)."""
"full_name": _text(self.full_name), inputs = getattr(self, "_inputs", None)
"notes": _text(self.notes), if isinstance(inputs, dict) and inputs:
"password": _text(self.password), return [name for name in inputs if name not in PLUMBING_INPUTS]
"age": self.age, seen = []
"amount": self.amount, declared = getattr(self, "inputs", None) or getattr(type(self), "inputs", None) or []
"newsletter": self.newsletter, for inp in declared:
"department": _text(self.department), name = getattr(inp, "name", None)
"topics": self.topics, if name and name not in PLUMBING_INPUTS and name not in seen:
"satisfaction": self.satisfaction, seen.append(name)
"attachment": _text(self.attachment), return seen
}
# Submitted values (via form_values) win over the field defaults. def _field_value(self, name: str):
# Accepts the raw dict or the run envelope {"payload": {...}}. """Runtime value of one input.
Reads ``_inputs`` directly: a field renamed to e.g. ``name`` would
otherwise resolve to the component attribute instead of its value.
"""
inputs = getattr(self, "_inputs", None)
if isinstance(inputs, dict) and name in inputs:
return getattr(inputs[name], "value", None)
try: try:
override = json.loads(_text(self.form_values) or "{}") return getattr(self, name, None)
except json.JSONDecodeError: except (AttributeError, ValueError):
override = {} return None
if isinstance(override, dict):
if isinstance(override.get("payload"), dict): def _is_visible(self, name: str, effective: dict) -> bool:
override = override["payload"] """Whether a field's branch conditions hold.
for key in data:
if key in override: Single pass over effective values (submitted first, code defaults
data[key] = override[key] after): no recursion, so trigger cycles cannot hang — a stale or
return Message(text=json.dumps(data, ensure_ascii=False)) cyclic marker simply matches or not. Unknown triggers never match.
"""
inputs = getattr(self, "_inputs", None)
info = ""
structured = None
if isinstance(inputs, dict) and name in inputs:
info = getattr(inputs[name], "info", "") or ""
structured = getattr(inputs[name], "visible_if", None)
for trigger, expected in _field_conditions(info, structured):
if trigger == name or trigger not in effective:
# Self-reference or unknown trigger: fail open (visible),
# mirroring the backend parser.
continue
actual = effective[trigger]
if isinstance(actual, list):
if expected not in actual:
return False
elif actual != expected:
return False
return True
def collect(self) -> Data:
payload, asked = parse_envelope(self.form_values)
# Effective trigger values: submitted first, code defaults after.
declared = self._field_names()
field_values = {name: _json_safe(self._field_value(name)) for name in declared}
effective, scope = collect_form_data(declared, field_values, payload, asked)
# Defaults only for asked AND visible fields (hidden branch fields
# stay out, like the frontend never submits them); without an asked
# list, all visible declared fields (Langflow playground).
data = {name: effective[name] for name in scope if self._is_visible(name, effective)}
# Submitted values win over the field defaults. Unknown keys are
# kept: the frontend may already know renamed fields this code
# revision does not declare.
for key, val in payload.items():
if isinstance(key, str) and key:
data[key] = _json_safe(val)
return Data(data=data)

View file

@ -0,0 +1,179 @@
"""Mitarbeiter-einstellen form component for kirche-einfach flows.
Thin variant: shared runtime lives in ``kirche._form_core`` (imported here
for the Langflow palette); ``scripts/make_flow_fixtures.py:kirche_node()``
inlines the core into the exported ``code`` so the LFX runtime stays
self-contained. Copy this file (or ``bauvorhaben_form.py``) as the starting
point for future forms.
A flow that starts with :class:`CustomInputMitarbeiter` declares the
fields of its web form. The API reads the exported node template
(``template`` minus ``code``) and derives ``{json_schema, ui_schema}``
from the ``lfx.io`` input definitions below — one JSON-Schema property
per field, keyed by ``name``:
* ``display_name`` → ``title``, ``info`` → ``description``
(``[visible_if ...]`` markers declare conditional branches),
``value`` → ``default``, ``options`` → ``enum``
* ``required`` → required array (branch-required applies only while visible)
``collect()`` is fully dynamic: it emits every input except the plumbing
one (``form_values``), so fields can be renamed, added, or removed in
the Langflow code editor without touching this method.
When the run envelope names the asked fields (``fields`` list, sent by
the API from the version's form schema), defaults are emitted only for
asked AND currently visible fields. Without the list (raw dict,
Langflow playground), all visible declared defaults apply.
``collect()`` returns ``Data`` (the LFX JSON type), not ``Message``.
"""
from __future__ import annotations
import json # noqa: F401 -- used by inlined _form_core at runtime
import re # noqa: F401 -- used by inlined _form_core at runtime
from typing import ClassVar
from lfx.custom import Component
from lfx.io import (
DropdownInput,
MessageTextInput,
Output,
StrInput,
)
from lfx.schema.data import Data
from kirche._form_core import (
PLUMBING_INPUTS,
_field_conditions,
_json_safe,
collect_form_data,
parse_envelope,
)
# <-- _form_core inlined by scripts/make_flow_fixtures.py:kirche_node()
# (LFX executes embedded source without the kirche package) -->
class CustomInputMitarbeiter(Component):
display_name = "Mitarbeiter Einstellen Form"
description = "Collects hiring form values into a single JSON object."
icon = "UserPlus"
inputs: ClassVar[list] = [
# Plumbing, not a form field: the API posts submitted web-form
# values as the run envelope (same {"payload": {...}} shape the
# other kirche components use); they arrive here through a ChatInput
# entry node and override the defaults below. Hidden in the GUI and
# skipped by the form parser (show=False).
MessageTextInput(
name="form_values",
display_name="Form values (JSON envelope)",
info="Submitted values as JSON; merged over the defaults",
value="",
show=False,
),
DropdownInput(
name="rolle",
display_name="Rolle",
info="",
options=["Assistenz", "Pfarrer:in", "Vikar:in", "Messner:in"],
value="Assistenz",
required=True,
),
DropdownInput(
name="einstufung",
display_name="Einstufung",
info="Nur für Pfarrer:in [visible_if rolle=Pfarrer:in]",
options=["Stufe 1", "Stufe 2", "Stufe 3"],
value="Stufe 1",
),
StrInput(
name="mitarbeiter_name",
display_name="Name",
info="Vor- und Nachname des Mitarbeiters",
value="",
required=True,
),
StrInput(
name="geburtsdatum",
display_name="Geburtsdatum",
info="Datum eingeben (z. B. JJJJ-MM-TT)",
value="",
),
]
outputs: ClassVar[list] = [
Output(display_name="Form Data", name="form_data", method="collect"),
]
def _field_names(self) -> list:
"""Names of all form fields (every input except the plumbing ones)."""
inputs = getattr(self, "_inputs", None)
if isinstance(inputs, dict) and inputs:
return [name for name in inputs if name not in PLUMBING_INPUTS]
seen = []
declared = getattr(self, "inputs", None) or getattr(type(self), "inputs", None) or []
for inp in declared:
name = getattr(inp, "name", None)
if name and name not in PLUMBING_INPUTS and name not in seen:
seen.append(name)
return seen
def _field_value(self, name: str):
"""Runtime value of one input.
Reads ``_inputs`` directly: a field renamed to e.g. ``name`` would
otherwise resolve to the component attribute instead of its value.
"""
inputs = getattr(self, "_inputs", None)
if isinstance(inputs, dict) and name in inputs:
return getattr(inputs[name], "value", None)
try:
return getattr(self, name, None)
except (AttributeError, ValueError):
return None
def _is_visible(self, name: str, effective: dict) -> bool:
"""Whether a field's branch conditions hold.
Single pass over effective values (submitted first, code defaults
after): no recursion, so trigger cycles cannot hang — a stale or
cyclic marker simply matches or not. Unknown triggers never match.
"""
inputs = getattr(self, "_inputs", None)
info = ""
structured = None
if isinstance(inputs, dict) and name in inputs:
info = getattr(inputs[name], "info", "") or ""
structured = getattr(inputs[name], "visible_if", None)
for trigger, expected in _field_conditions(info, structured):
if trigger == name or trigger not in effective:
# Self-reference or unknown trigger: fail open (visible),
# mirroring the backend parser.
continue
actual = effective[trigger]
if isinstance(actual, list):
if expected not in actual:
return False
elif actual != expected:
return False
return True
def collect(self) -> Data:
payload, asked = parse_envelope(self.form_values)
# Effective trigger values: submitted first, code defaults after.
declared = self._field_names()
field_values = {name: _json_safe(self._field_value(name)) for name in declared}
effective, scope = collect_form_data(declared, field_values, payload, asked)
# Defaults only for asked AND visible fields (hidden branch fields
# stay out, like the frontend never submits them); without an asked
# list, all visible declared fields (Langflow playground).
data = {name: effective[name] for name in scope if self._is_visible(name, effective)}
# Submitted values win over the field defaults. Unknown keys are
# kept: the frontend may already know renamed fields this code
# revision does not declare.
for key, val in payload.items():
if isinstance(key, str) and key:
data[key] = _json_safe(val)
return Data(data=data)

View file

@ -0,0 +1,3 @@
# Flows excluded from the pipeline (sync, deploy, validation, frontend).
# One filename stem per line; these stay Langflow-only experiments.
i_love_this_app

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View file

@ -0,0 +1,46 @@
"""drop user_sessions (stateless JWT sessions)
Revision ID: c4d8f2a1e6b9
Revises: b7e2d4a1c9f3
Create Date: 2026-09-28 00:00:00.000000
Sessions are stateless HS256 JWTs in the HttpOnly cookie (see
app/auth/service.py mint_session_token). All sessions are invalidated
at deploy — users re-login via magic link.
"""
from collections.abc import Sequence
import sqlalchemy as sa
import sqlmodel
from alembic import op
# revision identifiers, used by Alembic.
revision: str = "c4d8f2a1e6b9"
down_revision: str | Sequence[str] | None = "b7e2d4a1c9f3"
branch_labels: str | Sequence[str] | None = None
depends_on: str | Sequence[str] | None = None
def upgrade() -> None:
"""Upgrade schema."""
op.drop_index(op.f("ix_user_sessions_user_id"), table_name="user_sessions")
op.drop_table("user_sessions")
def downgrade() -> None:
"""Downgrade schema."""
op.create_table(
"user_sessions",
sa.Column("id", sqlmodel.sql.sqltypes.AutoString(length=128), nullable=False),
sa.Column("user_id", sa.Uuid(), nullable=False),
sa.Column("created_at", sa.DateTime(timezone=True), nullable=True),
sa.Column("expires_at", sa.DateTime(timezone=True), nullable=True),
sa.Column("revoked_at", sa.DateTime(timezone=True), nullable=True),
sa.ForeignKeyConstraint(
["user_id"],
["users.id"],
),
sa.PrimaryKeyConstraint("id"),
)
op.create_index(op.f("ix_user_sessions_user_id"), "user_sessions", ["user_id"], unique=False)

View file

@ -0,0 +1,65 @@
"""Backfill + require FlowVersion.input_schema.
Revision ID: e8f3a1c2b4d6
Revises: c4d8f2a1e6b9
Create Date: 2026-09-30 00:00:00.000000
Pre-Phase-3 rows have input_schema NULL. Backfill them from the stored
langflow_json (same parser the write choke point uses); unparseable rows
get the textarea fallback so reads never crash. Then enforce NOT NULL.
"""
from collections.abc import Sequence
import sqlalchemy as sa
from alembic import op
# revision identifiers, used by Alembic.
revision: str = "e8f3a1c2b4d6"
down_revision: str | Sequence[str] | None = "c4d8f2a1e6b9"
branch_labels: str | Sequence[str] | None = None
depends_on: str | Sequence[str] | None = None
_FALLBACK = {
"json_schema": {"type": "object", "properties": {}},
"ui_schema": {},
"fallback": "textarea",
}
def _derive(langflow_json) -> dict:
import json as stdlib_json
try:
from app.flows import input_schema as parser
if isinstance(langflow_json, str):
# SQLite stores JSON columns as TEXT; Postgres returns dict.
langflow_json = stdlib_json.loads(langflow_json)
return parser.extract_form_schema(langflow_json)
except Exception: # noqa: BLE001 -- backfill must never fail the migration
return dict(_FALLBACK)
def upgrade() -> None:
"""Upgrade schema."""
import json as stdlib_json
connection = op.get_bind()
rows = connection.execute(
sa.text("SELECT id, langflow_json FROM flow_versions WHERE input_schema IS NULL")
).all()
for row_id, langflow_json in rows:
schema = _derive(langflow_json)
connection.execute(
sa.text("UPDATE flow_versions SET input_schema = :schema WHERE id = :id"),
{"schema": stdlib_json.dumps(schema), "id": str(row_id)},
)
with op.batch_alter_table("flow_versions") as batch:
batch.alter_column("input_schema", existing_type=sa.JSON(), nullable=False)
def downgrade() -> None:
"""Downgrade schema (data kept, nullability restored)."""
with op.batch_alter_table("flow_versions") as batch:
batch.alter_column("input_schema", existing_type=sa.JSON(), nullable=True)

View file

@ -5,10 +5,19 @@ description = "Kirche Einfach - KI-gestuetzte Verwaltungsplattform fuer Kirche"
requires-python = ">=3.12" requires-python = ">=3.12"
dependencies = [ dependencies = [
"alembic>=1.14", "alembic>=1.14",
"atomicwrites>=1.4.1",
"fastapi[standard]>=0.115.0", "fastapi[standard]>=0.115.0",
"fastapi-mail>=1.4.1",
"httpx>=0.28", "httpx>=0.28",
"jinja2>=3.1",
"pydantic-settings>=2.0", "pydantic-settings>=2.0",
"pyjwt>=2.10",
"python-slugify>=8.0",
"secure>=1.0",
"slowapi>=0.1.9",
"sqlmodel>=0.0.24", "sqlmodel>=0.0.24",
"tenacity>=9.0",
"typer>=0.15",
"uvicorn[standard]>=0.30.0", "uvicorn[standard]>=0.30.0",
"watchfiles>=0.24", "watchfiles>=0.24",
] ]

View file

@ -11,10 +11,10 @@ from app (stdlib only), prints no secret values.
from __future__ import annotations from __future__ import annotations
import argparse
import sys
from pathlib import Path from pathlib import Path
import typer
BACKEND = Path(__file__).resolve().parent.parent BACKEND = Path(__file__).resolve().parent.parent
REPO_ROOT = BACKEND.parent REPO_ROOT = BACKEND.parent
@ -57,6 +57,7 @@ def check(values: dict[str, str]) -> tuple[list[str], list[str]]:
# Shared + service API keys. # Shared + service API keys.
secret("CALLBACK_TOKEN", MIN_TOKEN, "callback token") secret("CALLBACK_TOKEN", MIN_TOKEN, "callback token")
secret("JWT_SECRET", MIN_TOKEN, "session JWT secret")
secret("LANGFLOW_API_KEY", MIN_API_KEY, "langflow api key") secret("LANGFLOW_API_KEY", MIN_API_KEY, "langflow api key")
placeholder("LANGFLOW_API_KEY", ("sk-",)) placeholder("LANGFLOW_API_KEY", ("sk-",))
secret("LFX_API_KEY", MIN_API_KEY, "lfx api key") secret("LFX_API_KEY", MIN_API_KEY, "lfx api key")
@ -87,14 +88,12 @@ def check(values: dict[str, str]) -> tuple[list[str], list[str]]:
return failures, warnings return failures, warnings
def main() -> int: def main(env: str = typer.Option(str(REPO_ROOT / ".env"), "--env")) -> None:
parser = argparse.ArgumentParser(description=__doc__) """Validate a prod .env file (typer CLI; check/parse_env stay importable)."""
parser.add_argument("--env", default=str(REPO_ROOT / ".env")) path = Path(env)
args = parser.parse_args()
path = Path(args.env)
if not path.is_file(): if not path.is_file():
print(f"no env file at {path}") print(f"no env file at {path}")
return 1 raise typer.Exit(1)
failures, warnings = check(parse_env(path)) failures, warnings = check(parse_env(path))
for message in warnings: for message in warnings:
print(f"WARN: {message}") print(f"WARN: {message}")
@ -102,10 +101,9 @@ def main() -> int:
print(f"FAIL: {message}") print(f"FAIL: {message}")
if failures: if failures:
print(f"{len(failures)} blocking issue(s) — fix before deploying") print(f"{len(failures)} blocking issue(s) — fix before deploying")
return 1 raise typer.Exit(1)
print("prod env OK" + (f" ({len(warnings)} warning(s))" if warnings else "")) print("prod env OK" + (f" ({len(warnings)} warning(s))" if warnings else ""))
return 0
if __name__ == "__main__": if __name__ == "__main__":
sys.exit(main()) typer.run(main)

View file

@ -7,48 +7,46 @@ Usage:
from __future__ import annotations from __future__ import annotations
import argparse
import json import json
import sys
import urllib.request import httpx
import typer
def post(api: str, path: str, body: dict) -> dict: def post(api: str, path: str, body: dict) -> dict:
request = urllib.request.Request(
api.rstrip("/") + path,
data=json.dumps(body).encode(),
headers={"Content-Type": "application/json"},
method="POST",
)
try: try:
with urllib.request.urlopen(request) as response: response = httpx.post(api.rstrip("/") + path, json=body, timeout=60.0)
return {"status": response.status, "body": json.loads(response.read())} try:
except urllib.error.HTTPError as exc: payload = response.json()
return {"status": exc.code, "body": exc.read().decode()[:2000]} except ValueError:
payload = response.text[:2000]
return {"status": response.status_code, "body": payload}
except httpx.HTTPError as exc:
return {"status": 0, "body": str(exc)[:2000]}
def main() -> int: def main(
parser = argparse.ArgumentParser(description=__doc__) langflow_id: str = typer.Option(..., "--langflow-id"),
parser.add_argument("--api", default="http://localhost:8000") api: str = typer.Option("http://localhost:8000", "--api"),
parser.add_argument("--langflow-id", required=True) name: str | None = typer.Option(None, "--name"),
parser.add_argument("--name", default=None) author: str = typer.Option("", "--author"),
parser.add_argument("--author", default="") no_deploy: bool = typer.Option(False, "--no-deploy"),
parser.add_argument("--no-deploy", action="store_true") ) -> None:
args = parser.parse_args() """Import a flow from Langflow via the running API (post() stays importable)."""
result = post( result = post(
args.api, api,
"/api/flows/import", "/api/flows/import",
{ {
"langflow_flow_id": args.langflow_id, "langflow_flow_id": langflow_id,
"name": args.name, "name": name,
"author": args.author, "author": author,
"deploy": not args.no_deploy, "deploy": not no_deploy,
}, },
) )
print(json.dumps(result, indent=2, ensure_ascii=False)) print(json.dumps(result, indent=2, ensure_ascii=False))
return 0 if result["status"] in (200, 201) else 1 if result["status"] not in (200, 201):
raise typer.Exit(1)
if __name__ == "__main__": if __name__ == "__main__":
sys.exit(main()) typer.run(main)

View file

@ -29,6 +29,74 @@ FLOW_DIR = REPO_ROOT / "backend" / "flows"
HANDLE_QUOTE = "\u0153" # ReactFlow handle-id quoting used by Langflow exports HANDLE_QUOTE = "\u0153" # ReactFlow handle-id quoting used by Langflow exports
FORM_CORE_PATH = REPO_ROOT / "backend" / "components" / "kirche" / "_form_core.py"
INLINE_MARKER = "# <-- _form_core inlined by scripts/make_flow_fixtures.py:kirche_node()"
def _inline_core() -> str:
"""Body of _form_core.py minus docstring/future/std-imports (already present)."""
text = FORM_CORE_PATH.read_text(encoding="utf-8")
lines = text.splitlines()
body: list[str] = []
skip_docstring = True
in_docstring = False
for line in lines:
stripped = line.strip()
if skip_docstring:
if stripped.startswith('"""') and not in_docstring:
if stripped.count('"""') >= 2:
skip_docstring = False
else:
in_docstring = True
continue
if in_docstring:
if '"""' in stripped:
in_docstring = False
skip_docstring = False
continue
if stripped in (
"from __future__ import annotations",
"import json",
"import re",
"",
):
continue
skip_docstring = False
if stripped in ("from __future__ import annotations", "import json", "import re"):
continue
body.append(line)
return "\n".join(body).strip() + "\n"
def _compose_component_code(source: str) -> str:
"""Replace the sibling import + marker with inlined core (LFX self-contained)."""
core = _inline_core()
out: list[str] = []
skipping_import = False
for line in source.splitlines():
stripped = line.strip()
if not skipping_import and stripped.startswith(
("from kirche._form_core import", "from ._form_core import")
):
out.append(core.rstrip())
# Multi-line parenthesized import: skip continuation lines
# up to and including the closing paren.
if "(" in stripped and ")" not in stripped:
skipping_import = True
continue
if skipping_import:
if ")" in stripped:
skipping_import = False
continue
if "_form_core inlined by" in stripped:
continue
out.append(line)
composed = "\n".join(out)
assert "from kirche" not in composed, "sibling import survived inlining"
assert "from ._" not in composed, "relative import survived inlining"
return composed
# -------------------------------------------------------------------------- # --------------------------------------------------------------------------
# node builders # node builders
@ -91,6 +159,8 @@ def kirche_node(
node_id: str, node_id: str,
values: dict | None = None, values: dict | None = None,
position: tuple[int, int] = (0, 0), position: tuple[int, int] = (0, 0),
component_cls=None,
code_override: str | None = None,
) -> dict: ) -> dict:
"""A node from our GUI-editable category lib (backend/components/kirche). """A node from our GUI-editable category lib (backend/components/kirche).
@ -101,15 +171,22 @@ def kirche_node(
the same way). The template dict before that round-trip is complete and the same way). The template dict before that round-trip is complete and
faithful, so we use it directly and append the ``code`` field by hand faithful, so we use it directly and append the ``code`` field by hand
(mirroring the shape ``build_custom_component_template`` produces). (mirroring the shape ``build_custom_component_template`` produces).
``component_cls`` builds a node from a variant class (e.g. a flow whose
fields differ from ``CustomInputForm``); ``code_override`` embeds that
variant's source (``set_class_code`` cannot inspect exec-built classes).
""" """
sys.path.insert(0, str(REPO_ROOT / "backend" / "components")) sys.path.insert(0, str(REPO_ROOT / "backend" / "components"))
from kirche.form_inputs import CustomInputForm if component_cls is None:
from kirche.form_inputs import CustomInputForm as component_cls
from lfx.template.frontend_node.custom_components import ( from lfx.template.frontend_node.custom_components import (
ComponentFrontendNode, ComponentFrontendNode,
) )
comp_name = getattr(CustomInputForm, "name", None) or "CustomInputForm" comp_name = getattr(component_cls, "name", None) or component_cls.__name__
inst = CustomInputForm() inst = component_cls()
if code_override is not None:
inst._code = _compose_component_code(code_override)
frontend_node = ComponentFrontendNode.from_inputs(**inst.get_template_config(inst)) frontend_node = ComponentFrontendNode.from_inputs(**inst.get_template_config(inst))
inst._map_parameters_on_frontend_node(frontend_node) inst._map_parameters_on_frontend_node(frontend_node)
node = frontend_node.to_dict(keep_name=False) node = frontend_node.to_dict(keep_name=False)
@ -117,6 +194,10 @@ def kirche_node(
inst._map_parameters_on_template(node["template"]) inst._map_parameters_on_template(node["template"])
if not getattr(inst, "_code", None): if not getattr(inst, "_code", None):
inst.set_class_code() inst.set_class_code()
# Always compose: default path may already carry thin source with the
# sibling import (Component base sets _code on init); override path is
# pre-composed but re-composing is idempotent (no import lines left).
inst._code = _compose_component_code(inst._code)
node["template"]["code"] = { node["template"]["code"] = {
"advanced": True, "advanced": True,
"api_editable": False, "api_editable": False,
@ -147,14 +228,18 @@ def kirche_node(
# form_values envelope (collect() merges), never via edges — so required # form_values envelope (collect() merges), never via edges — so required
# template fields carry a single-space sentinel value. The form parser # template fields carry a single-space sentinel value. The form parser
# (app/flows/input_schema.py) treats whitespace-only values as "no # (app/flows/input_schema.py) treats whitespace-only values as "no
# default", keeping the web form clean. # default", keeping the web form clean. Multiselect needs a list to
# survive runtime assignment, so it gets [" "] (skipped the same way
# via the enum-mismatch rule).
for field_def in node_dict["data"]["node"]["template"].values(): for field_def in node_dict["data"]["node"]["template"].values():
if ( if (
isinstance(field_def, dict) isinstance(field_def, dict)
and field_def.get("required") and field_def.get("required")
and field_def.get("value") in (None, "", [], {}) and field_def.get("value") in (None, "", [], {})
): ):
field_def["value"] = " " field_def["value"] = (
[" "] if field_def.get("_input_type") == "MultiselectInput" else " "
)
return node_dict return node_dict
@ -406,6 +491,128 @@ class ApprovalCallbackComponent(Component):
""" """
GEHALT_CODE = """from lfx.custom import Component
from lfx.io import HandleInput, Output
from lfx.schema import Data, Message
try:
from lfx.schema import DataFrame
except Exception: # pragma: no cover
DataFrame = None
import json
class GehaltsrechnerComponent(Component):
display_name = "Gehaltsrechner"
description = (
"Calculates the annual salary (Gehalt) for church employees based on their role "
"(rolle) and level (einstufung). Use this when you need to determine the yearly "
"salary for roles such as Assistenz, Vikar:in, Messner:in or Pfarrer:in."
)
icon = "Calculator"
inputs = [
HandleInput(
name="input_data",
display_name="Employee Data",
input_types=["JSON", "Data", "Message", "DataFrame", "Table"],
info=(
"Employee data as JSON/Data/Message/DataFrame. Must contain "
"'rolle' (and 'einstufung' for Pfarrer:in), plus 'mitarbeiter_name' and 'geburtsdatum'."
),
),
]
outputs = [
Output(
name="salary_text",
display_name="Salary Text",
method="calculate_salary",
),
]
# Salary mapping for simple roles
BASE_SALARY = {
"Assistenz": 42000,
"Vikar:in": 48000,
"Messner:in": 36000,
}
# Salary mapping for Pfarrer:in per Einstufung
PFARRER_SALARY = {
"Stufe 1": 55000,
"Stufe 2": 65000,
"Stufe 3": 75000,
}
def _extract_data(self, value) -> dict | None:
'''Normalize the incoming value into a plain dict.'''
if isinstance(value, dict):
return value
if isinstance(value, Data):
return value.data if isinstance(value.data, dict) else None
if isinstance(value, Message):
value = value.text
if DataFrame is not None and isinstance(value, DataFrame):
try:
records = value.to_dict(orient="records")
if records:
return records[0]
except Exception:
return None
return None
if isinstance(value, str):
text = value.strip()
try:
parsed = json.loads(text)
if isinstance(parsed, dict):
return parsed
if isinstance(parsed, list) and parsed and isinstance(parsed[0], dict):
return parsed[0]
except (json.JSONDecodeError, TypeError, ValueError):
return None
return None
def calculate_salary(self) -> Message:
try:
data = self._extract_data(self.input_data)
if not isinstance(data, dict):
return Message(
text="Error: Could not parse employee data. Please provide a valid JSON object."
)
rolle = data.get("rolle")
einstufung = data.get("einstufung")
name = data.get("mitarbeiter_name", "unknown")
if not rolle:
return Message(
text="Error: Missing required field 'rolle' in employee data."
)
if rolle in self.BASE_SALARY:
salary = self.BASE_SALARY[rolle]
elif rolle == "Pfarrer:in":
if einstufung not in self.PFARRER_SALARY:
return Message(
text=(
"Error: For role 'Pfarrer:in', a valid 'einstufung' "
"(Stufe 1, Stufe 2 or Stufe 3) is required."
)
)
salary = self.PFARRER_SALARY[einstufung]
else:
return Message(text=f"Error: Unknown role '{rolle}'.")
einstufung_display = einstufung if einstufung else "-"
return Message(
text=(
f"Mitarbeiter:{name} | Rolle:{rolle} | "
f"Einstufung:{einstufung_display} | Gehalt:{salary} EUR pro Jahr"
)
)
except Exception as exc: # never raise, always return a clear error string
return Message(text=f"Error: {exc}")
"""
# -------------------------------------------------------------------------- # --------------------------------------------------------------------------
# flows # flows
# -------------------------------------------------------------------------- # --------------------------------------------------------------------------
@ -544,6 +751,108 @@ def build_intake_form() -> dict:
) )
def build_bauvorhaben() -> dict:
"""Branched Bauvorhaben form via the standalone Bauvorhaven component."""
sys.path.insert(0, str(REPO_ROOT / "backend" / "components"))
from kirche.bauvorhaben_form import CustomInputBauvorhaben
entry = builtin_node(
"lfx.components.input_output.chat",
"ChatInput",
"ChatInput-entry",
position=(0, 200),
)
inst = CustomInputBauvorhaben()
if not getattr(inst, "_code", None):
inst.set_class_code()
form = kirche_node(
"CustomInputBauvorhaben-bauvorhaben",
position=(400, 200),
component_cls=CustomInputBauvorhaben,
code_override=inst._code,
)
# Logical question order: RJSF renders schema properties in insertion
# order and the parser derives ui:order from it (lfx emits alphabetical).
order = [
"form_values",
"gebaeude",
"bestandteil",
"glockenmassnahme",
"gussjahr",
"gebaeudeart",
"denkmalschutz",
"denkmalnummer",
]
template = form["data"]["node"]["template"]
form["data"]["node"]["template"] = {k: template[k] for k in order} | {
k: v for k, v in template.items() if k not in order
}
out = builtin_node(
"lfx.components.input_output.chat_output",
"ChatOutput",
"ChatOutput-collected",
position=(800, 200),
)
nodes = [entry, form, out]
edges = [
edge(entry, "message", form, "form_values"),
edge(form, "form_data", out, "input_value"),
]
return flow_doc(
"bauvorhaben",
"Bauvorhaben: verzweigtes Formular mit mehrstufigen Abhängigkeiten.",
nodes,
edges,
)
def build_mitarbeiter() -> dict:
"""Hiring form via the standalone Mitarbeiter component + Gehaltsrechner."""
sys.path.insert(0, str(REPO_ROOT / "backend" / "components"))
from kirche.mitarbeiter_form import CustomInputMitarbeiter
entry = builtin_node(
"lfx.components.input_output.chat",
"ChatInput",
"ChatInput-entry",
position=(0, 200),
)
inst = CustomInputMitarbeiter()
if not getattr(inst, "_code", None):
inst.set_class_code()
form = kirche_node(
"CustomInputMitarbeiter-mitarbeiter",
position=(400, 200),
component_cls=CustomInputMitarbeiter,
code_override=inst._code,
)
# Logical question order (see build_bauvorhaben).
order = ["form_values", "rolle", "einstufung", "mitarbeiter_name", "geburtsdatum"]
template = form["data"]["node"]["template"]
form["data"]["node"]["template"] = {k: template[k] for k in order} | {
k: v for k, v in template.items() if k not in order
}
gehalt = custom_node(GEHALT_CODE, "Gehaltsrechner-gehalt", position=(800, 200))
out = builtin_node(
"lfx.components.input_output.chat_output",
"ChatOutput",
"ChatOutput-collected",
position=(1200, 200),
)
nodes = [entry, form, gehalt, out]
edges = [
edge(entry, "message", form, "form_values"),
edge(form, "form_data", gehalt, "input_data"),
edge(gehalt, "salary_text", out, "input_value"),
]
return flow_doc(
"mitarbeiter_einstellen",
"Mitarbeiter einstellen: Formular mit Gehaltsrechner.",
nodes,
edges,
)
def main() -> None: def main() -> None:
FIXTURE_DIR.mkdir(parents=True, exist_ok=True) FIXTURE_DIR.mkdir(parents=True, exist_ok=True)
FLOW_DIR.mkdir(parents=True, exist_ok=True) FLOW_DIR.mkdir(parents=True, exist_ok=True)
@ -551,11 +860,16 @@ def main() -> None:
"simple_rule.json": build_simple_rule(), "simple_rule.json": build_simple_rule(),
"approval_handoff.json": build_approval_handoff(), "approval_handoff.json": build_approval_handoff(),
"intake_form.json": build_intake_form(), "intake_form.json": build_intake_form(),
"bauvorhaben.json": build_bauvorhaben(),
"mitarbeiter_einstellen.json": build_mitarbeiter(),
} }
for filename, doc in flows.items(): for filename, doc in flows.items():
payload = json.dumps(doc, indent=2, ensure_ascii=False) + "\n" payload = json.dumps(doc, indent=2, ensure_ascii=False) + "\n"
for target in (FIXTURE_DIR / filename, FLOW_DIR / filename): for target in (FIXTURE_DIR / filename, FLOW_DIR / filename):
target.write_text(payload) # Explicit encoding + LF: the default locale/newline handling
# corrupts non-ASCII flow code on Windows (cp1252) and dirties
# every line with CRLF.
target.write_text(payload, encoding="utf-8", newline="\n")
print(f"wrote {target}") print(f"wrote {target}")

View file

@ -0,0 +1,40 @@
"""Push canonical backend/flows/*.json into Langflow via API (no restart)."""
from __future__ import annotations
import asyncio
import json
import os
from pathlib import Path
from app.flows.langflow_client import LangflowClient, LangflowError
from app.settings import settings
async def main() -> None:
base = os.environ.get("LANGFLOW_URL", "http://localhost:7860")
key = settings.langflow_api_key or os.environ.get("LANGFLOW_API_KEY", "")
print(f"Langflow: {base} key_len={len(key)}")
client = LangflowClient(base, api_key=key)
try:
flows = await client.list_flows()
print(f"existing: {len(flows)} flows")
for f in flows[:20]:
print(" -", f.get("name"), f.get("id"))
except LangflowError as exc:
print(f"list failed: {exc}")
return
flows_dir = Path(settings.flows_dir)
for path in sorted(flows_dir.glob("*.json")):
if path.name.startswith("."):
continue
doc = json.loads(path.read_text(encoding="utf-8"))
try:
result = await client.upsert_flow(doc)
print(f"pushed {path.name} id={result.get('id', 'ok')}")
except LangflowError as exc:
print(f"push {path.name} failed: {exc}")
if __name__ == "__main__":
asyncio.run(main())

View file

@ -11,52 +11,43 @@ from __future__ import annotations
import json import json
import os import os
import shutil import shutil
import socket
import subprocess import subprocess
import sys import sys
import tempfile import tempfile
import time
import urllib.request
from pathlib import Path from pathlib import Path
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
from tests._harness import (
free_port,
migrate_throwaway,
plant_session_jwt,
spawn_lfx,
wait_healthy,
)
BACKEND = Path(__file__).resolve().parent.parent BACKEND = Path(__file__).resolve().parent.parent
# Local venv (uv run) or image venv (/opt/venv in containers): prefer PATH. # Local venv (uv run) or image venv (/opt/venv in containers): prefer PATH.
VENV_BIN = Path(shutil.which("lfx") or "").parent or (BACKEND / ".venv" / "bin") VENV_BIN = Path(shutil.which("lfx") or "").parent or (BACKEND / ".venv" / "bin")
FIXTURES = BACKEND / "tests" / "fixtures" / "flows" FIXTURES = BACKEND / "tests" / "fixtures" / "flows"
# Ephemeral ports: the dev API/LFX may already occupy the defaults
def _free_port() -> int: # (e.g. when smoke runs inside the api container itself).
# Ephemeral ports: the dev API/LFX may already occupy the defaults LFX_PORT = free_port()
# (e.g. when smoke runs inside the api container itself). API_PORT = free_port()
with socket.socket() as s:
s.bind(("127.0.0.1", 0))
return s.getsockname()[1]
LFX_PORT = _free_port()
API_PORT = _free_port()
LFX_KEY = "lfx-759GsfJKjAeOBZ_44-cll9WdHp_yfYn_tIg7eHG38Rs" LFX_KEY = "lfx-759GsfJKjAeOBZ_44-cll9WdHp_yfYn_tIg7eHG38Rs"
# Stateless admin session JWT, minted in main() after planting the user.
def wait_healthy(url: str, timeout: int = 180) -> None: _SMOKE_JWT = ""
deadline = time.time() + timeout
while time.time() < deadline:
try:
with urllib.request.urlopen(url, timeout=3) as r:
if r.status == 200:
return
except OSError:
time.sleep(1)
raise RuntimeError(f"never healthy: {url}")
def api(method: str, path: str, body: dict | None = None) -> tuple[int, dict | str]: def api(method: str, path: str, body: dict | None = None) -> tuple[int, dict | str]:
import httpx import httpx
with httpx.Client(base_url=f"http://127.0.0.1:{API_PORT}", timeout=120) as c: with httpx.Client(base_url=f"http://127.0.0.1:{API_PORT}", timeout=120) as c:
# Management + runs are login-gated; the smoke admin session is # Management + runs are login-gated; the smoke admin JWT is minted
# planted directly in the throwaway DB (see main()). # in main() (stateless sessions, see app/auth/service.py).
c.cookies.set("kirche_session", "smoke-session", domain="127.0.0.1") c.cookies.set("kirche_session", _SMOKE_JWT, domain="127.0.0.1")
r = c.request(method, path, json=body) r = c.request(method, path, json=body)
try: try:
return r.status_code, r.json() return r.status_code, r.json()
@ -72,85 +63,55 @@ def check(name: str, cond: bool, detail: str = "") -> None:
def main() -> None: def main() -> None:
tmp = Path(tempfile.mkdtemp(prefix="kirche-smoke-")) tmp = Path(tempfile.mkdtemp(prefix="kirche-smoke-"))
flow_dir = Path("/tmp/smoke-e2e-flows") flow_dir = Path(tempfile.mkdtemp(prefix="kirche-smoke-flows-"))
flow_dir.mkdir(exist_ok=True)
(flow_dir / "seed.json").write_text((FIXTURES / "simple_rule.json").read_text()) (flow_dir / "seed.json").write_text((FIXTURES / "simple_rule.json").read_text())
# Migrate a throwaway SQLite schema to head before starting the API. # Migrate a throwaway SQLite schema to head before starting the API.
from alembic import command as alembic_command
from alembic.config import Config
db_url = f"sqlite:///{tmp / 'smoke.db'}" db_url = f"sqlite:///{tmp / 'smoke.db'}"
cfg = Config() migrate_throwaway(BACKEND, db_url)
cfg.set_main_option("script_location", str(BACKEND / "migrations"))
cfg.set_main_option("sqlalchemy.url", db_url)
# migrations/env.py takes the URL from settings (not the ini value):
# point this process at the throwaway DB before migrating.
from app.settings import settings as app_settings
app_settings.database_url = db_url
alembic_command.upgrade(cfg, "head")
# Plant an admin session: management + runs require login, and there is
# no SMTP in smoke to deliver a magic link.
from datetime import UTC, datetime, timedelta
# Plant an admin user + mint its session JWT: management + runs
# require login, and there is no SMTP in smoke to deliver a magic link.
# Sessions are stateless (see app/auth/service.py) — the cookie value
# below is the JWT sent as `kirche_session`.
global _SMOKE_JWT
from sqlmodel import Session, create_engine from sqlmodel import Session, create_engine
from app.models import User, UserSession from app.settings import settings as app_settings
if not app_settings.jwt_secret:
app_settings.jwt_secret = os.environ.get(
"JWT_SECRET", "smoke-jwt-secret-32-chars-minimum!!"
)
engine = create_engine(db_url) engine = create_engine(db_url)
with Session(engine) as s: with Session(engine) as s:
user = User(name="smoke", email="smoke@example.com", role="admin") _, _SMOKE_JWT = plant_session_jwt(s, email="smoke@example.com", name="smoke")
s.add(user) # Smoke predates the shared harness key; keep its long serve key.
s.flush() print("smoke admin JWT minted")
s.add(
UserSession(
id="smoke-session",
user_id=user.id,
expires_at=datetime.now(UTC) + timedelta(hours=1),
)
)
s.commit()
engine.dispose() engine.dispose()
env = { env_extra = {
**os.environ,
# lfx prefers LANGFLOW_API_KEY over LFX_API_KEY; the repo .env may set
# it. Clear it so the serve key below is the one we send.
"LANGFLOW_API_KEY": "",
"LFX_API_KEY": LFX_KEY,
"DATABASE_URL": db_url, "DATABASE_URL": db_url,
"FLOWS_WATCH_ENABLED": "false", "FLOWS_WATCH_ENABLED": "false",
"LFX_URL": f"http://127.0.0.1:{LFX_PORT}", "LFX_URL": f"http://127.0.0.1:{LFX_PORT}",
"CALLBACK_BASE_URL": f"http://127.0.0.1:{API_PORT}", "CALLBACK_BASE_URL": f"http://127.0.0.1:{API_PORT}",
"CALLBACK_TOKEN": "smoke-callback-token", "CALLBACK_TOKEN": "smoke-callback-token",
} }
lfx = subprocess.Popen( lfx = spawn_lfx(flow_dir, LFX_PORT, env_extra=env_extra, api_key=LFX_KEY)
[
str(VENV_BIN / "lfx"),
"serve",
"--host",
"127.0.0.1",
"--port",
str(LFX_PORT),
"--flow-dir",
str(flow_dir),
str(flow_dir),
],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
env=env,
)
uvicorn = subprocess.Popen( uvicorn = subprocess.Popen(
[str(VENV_BIN / "uvicorn"), "app.main:app", "--host", "127.0.0.1", "--port", str(API_PORT)], [str(VENV_BIN / "uvicorn"), "app.main:app", "--host", "127.0.0.1", "--port", str(API_PORT)],
cwd=str(BACKEND), cwd=str(BACKEND),
stdout=subprocess.DEVNULL, stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
env=env, env={
**os.environ,
"LANGFLOW_API_KEY": "",
"LFX_API_KEY": LFX_KEY,
**env_extra,
},
) )
try: try:
wait_healthy(f"http://127.0.0.1:{LFX_PORT}/health") wait_healthy(f"http://127.0.0.1:{LFX_PORT}", deadline_s=180)
wait_healthy(f"http://127.0.0.1:{API_PORT}/health") wait_healthy(f"http://127.0.0.1:{API_PORT}", deadline_s=180)
s, flows = api("GET", "/api/flows") s, flows = api("GET", "/api/flows")
check("list flows", s == 200 and isinstance(flows, list)) check("list flows", s == 200 and isinstance(flows, list))

View file

@ -9,12 +9,12 @@ Exit codes: 0 ok, 1 sync errors, 2 flows dir missing.
from __future__ import annotations from __future__ import annotations
import argparse
import asyncio import asyncio
import json import json
import sys import sys
from pathlib import Path from pathlib import Path
import typer
from sqlmodel import Session from sqlmodel import Session
from app.db import get_engine, reset_engine from app.db import get_engine, reset_engine
@ -42,8 +42,28 @@ async def run_sync(flows_dir: Path) -> SyncReport:
session.close() session.close()
async def run_full_pass(flows_dir: Path) -> SyncReport:
"""Single orchestration: Langflow pull + file sync (shared with API)."""
reset_engine()
session = Session(get_engine())
try:
lfx = LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None)
langflow = LangflowClient(settings.langflow_url, api_key=settings.langflow_api_key)
return await sync.sync_full_pass(session, lfx, langflow, flows_dir)
finally:
session.close()
async def main_async(args) -> int: async def main_async(args) -> int:
flows_dir = Path(args.dir or settings.flows_dir) flows_dir = Path(args.dir or settings.flows_dir)
if args.pull and args.sync:
try:
report = await run_full_pass(flows_dir)
except FileNotFoundError as exc:
print(f"ERROR: {exc}", file=sys.stderr)
return 2
print(report.model_dump_json(indent=2))
return 1 if report.errors else 0
if args.pull: if args.pull:
pulled = await pull_from_langflow(flows_dir) pulled = await pull_from_langflow(flows_dir)
print(json.dumps(pulled, indent=2, ensure_ascii=False)) print(json.dumps(pulled, indent=2, ensure_ascii=False))
@ -60,18 +80,17 @@ async def main_async(args) -> int:
return 0 return 0
def main() -> int: def main(
parser = argparse.ArgumentParser(description=__doc__) pull: bool = typer.Option(False, "--pull", help="export all Langflow flows first"),
parser.add_argument( sync: bool = typer.Option(False, "--sync", help="reconcile backend/flows into DB + LFX"),
"--pull", action="store_true", help="export all Langflow flows to backend/flows first" dir: str | None = typer.Option(None, "--dir", help="flows directory"),
) ) -> None:
parser.add_argument("--sync", action="store_true", help="reconcile backend/flows into DB + LFX") """Reconcile flows (typer CLI; run_sync/run_full_pass stay importable)."""
parser.add_argument("--dir", default=None, help="flows directory (default: settings.flows_dir)") if not pull and not sync:
args = parser.parse_args() sync = True
if not args.pull and not args.sync: args = type("Args", (), {"pull": pull, "sync": sync, "dir": dir})()
args.sync = True raise typer.Exit(asyncio.run(main_async(args)))
return asyncio.run(main_async(args))
if __name__ == "__main__": if __name__ == "__main__":
sys.exit(main()) typer.run(main)

116
backend/tests/_harness.py Normal file
View file

@ -0,0 +1,116 @@
"""Shared e2e harness: free ports, health waits, lfx spawn, migrate, sessions.
Single place for logic shared between tests/conftest.py and
scripts/smoke_e2e.py. Full real-LFX runs are kept.
"""
from __future__ import annotations
import os
import shutil
import socket
import subprocess
import sys
import time
import urllib.request
from pathlib import Path
# Single constant: lfx prefers LANGFLOW_API_KEY over LFX_API_KEY, so the
# repo .env value must be cleared wherever a test key is used.
TEST_LFX_KEY = "test-lfx-key"
def free_port() -> int:
sock = socket.socket()
sock.bind(("127.0.0.1", 0))
port = sock.getsockname()[1]
sock.close()
return port
def wait_healthy(url: str, deadline_s: float = 240.0) -> None:
deadline = time.time() + deadline_s
while time.time() < deadline:
try:
with urllib.request.urlopen(url + "/health", timeout=3) as response:
if response.status == 200:
return
except OSError:
time.sleep(1)
raise RuntimeError(f"server did not become healthy: {url}")
def spawn_lfx(
flow_dir: Path, port: int, env_extra: dict | None = None, api_key: str = TEST_LFX_KEY
) -> subprocess.Popen:
bindir = Path(sys.executable).parent
lfx_bin = shutil.which("lfx", path=str(bindir)) or "lfx"
env = {**os.environ, "LANGFLOW_API_KEY": "", "LFX_API_KEY": api_key}
if env_extra:
env.update(env_extra)
return subprocess.Popen(
[
lfx_bin,
"serve",
"--host",
"127.0.0.1",
"--port",
str(port),
"--flow-dir",
str(flow_dir),
str(flow_dir),
],
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
text=True,
env=env,
)
def migrate_throwaway(backend_dir: Path, db_url: str | None = None) -> None:
from alembic import command as alembic_command
from alembic.config import Config
cfg = Config()
cfg.set_main_option("script_location", str(backend_dir / "migrations"))
if db_url is not None:
cfg.set_main_option("sqlalchemy.url", db_url)
# migrations/env.py takes the URL from settings (not the ini value).
from app.settings import settings as app_settings
app_settings.database_url = db_url
alembic_command.upgrade(cfg, "head")
def spawn_uvicorn(app, host: str = "127.0.0.1", port: int = 0): # type: ignore[no-untyped-def]
"""Real uvicorn server in a daemon thread. Returns (server, thread)."""
import threading
import time
import uvicorn
config = uvicorn.Config(app, host=host, port=port, log_level="warning")
server = uvicorn.Server(config)
thread = threading.Thread(target=server.run, daemon=True)
thread.start()
deadline = time.time() + 30
while not server.started and time.time() < deadline:
time.sleep(0.05)
assert server.started, "uvicorn test server did not start"
return server, thread
def plant_session_jwt(session, email: str, role: str = "admin", name: str = "Test") -> tuple:
"""Idempotent test user + session JWT (shared with smoke pattern)."""
from sqlmodel import select
from app.auth import service
from app.models import User
user = session.exec(select(User).where(User.email == email)).first()
if user is None:
user = User(name=name, email=email, role=role)
session.add(user)
session.commit()
session.refresh(user)
return user, service.mint_session_token(user)

View file

@ -19,6 +19,8 @@ os.environ["DATABASE_URL"] = f"sqlite:///{TEST_AREA / 'test.db'}"
os.environ["FLOWS_DIR"] = str(TEST_AREA / "flows") os.environ["FLOWS_DIR"] = str(TEST_AREA / "flows")
# Flow callbacks (POST /api/approvals) authenticate with this token. # Flow callbacks (POST /api/approvals) authenticate with this token.
os.environ["CALLBACK_TOKEN"] = "test-callback-token" os.environ["CALLBACK_TOKEN"] = "test-callback-token"
# Stateless session JWTs are signed with this (HS256).
os.environ["JWT_SECRET"] = "test-jwt-secret-32-chars-minimum!!"
# The embedded watcher + startup sync stay off in tests; sync is exercised # The embedded watcher + startup sync stay off in tests; sync is exercised
# directly (sync_from_directory) with per-test tmp dirs instead. # directly (sync_from_directory) with per-test tmp dirs instead.
os.environ["FLOWS_WATCH_ENABLED"] = "false" os.environ["FLOWS_WATCH_ENABLED"] = "false"
@ -93,13 +95,11 @@ def login(client, session):
role: str = "admin", role: str = "admin",
tenant_id: str = "default", tenant_id: str = "default",
): ):
from datetime import UTC, datetime, timedelta
from uuid import uuid4
from sqlmodel import select from sqlmodel import select
from app.auth import service
from app.auth.deps import SESSION_COOKIE from app.auth.deps import SESSION_COOKIE
from app.models import User, UserSession from app.models import User
# Idempotent: re-login updates the existing row (tests switch # Idempotent: re-login updates the existing row (tests switch
# identity mid-test by calling login() again). # identity mid-test by calling login() again).
@ -111,15 +111,9 @@ def login(client, session):
user.role = role user.role = role
user.tenant_id = tenant_id user.tenant_id = tenant_id
session.add(user) session.add(user)
session.flush()
user_session = UserSession(
id=f"test-session-{uuid4().hex}",
user_id=user.id,
expires_at=datetime.now(UTC) + timedelta(days=1),
)
session.add(user_session)
session.commit() session.commit()
client.cookies.set(SESSION_COOKIE, user_session.id) session.refresh(user)
client.cookies.set(SESSION_COOKIE, service.mint_session_token(user))
return user return user
return _login return _login
@ -132,76 +126,33 @@ def lfx_server(tmp_path_factory):
Serves an (initially seeded) flow dir; tests upload fixture flows through Serves an (initially seeded) flow dir; tests upload fixture flows through
the same deploy path production uses. the same deploy path production uses.
""" """
import shutil
import socket
import subprocess import subprocess
import sys
import time
import urllib.request
from pathlib import Path from pathlib import Path
from app.settings import settings from app.settings import settings
bindir = Path(sys.executable).parent from ._harness import TEST_LFX_KEY, free_port, spawn_lfx, wait_healthy
lfx_bin = shutil.which("lfx", path=str(bindir)) or "lfx"
sock = socket.socket()
sock.bind(("127.0.0.1", 0))
port = sock.getsockname()[1]
sock.close()
port = free_port()
flow_dir = tmp_path_factory.mktemp("lfx-flows") flow_dir = tmp_path_factory.mktemp("lfx-flows")
seed = (Path(__file__).parent / "fixtures" / "flows" / "simple_rule.json").read_text() seed = (Path(__file__).parent / "fixtures" / "flows" / "simple_rule.json").read_text()
(flow_dir / "seed.json").write_text(seed) (flow_dir / "seed.json").write_text(seed)
env = { proc = spawn_lfx(flow_dir, port)
**os.environ,
# lfx serve refuses to start without a serve key; requests need it too.
# get_api_key() prefers LANGFLOW_API_KEY over LFX_API_KEY, and the repo
# .env may put a real Langflow key in the environment — clear it so the
# test key below is the one the client sends.
"LANGFLOW_API_KEY": "",
"LFX_API_KEY": "test-lfx-key",
}
proc = subprocess.Popen(
[
lfx_bin,
"serve",
"--host",
"127.0.0.1",
"--port",
str(port),
"--flow-dir",
str(flow_dir),
str(flow_dir),
],
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
text=True,
env=env,
)
url = f"http://127.0.0.1:{port}" url = f"http://127.0.0.1:{port}"
deadline = time.time() + 240 try:
healthy = False wait_healthy(url)
while time.time() < deadline: except Exception:
if proc.poll() is not None: if proc.poll() is not None:
out = proc.stdout.read() if proc.stdout else "" out = proc.stdout.read() if proc.stdout else ""
raise RuntimeError(f"lfx serve exited early:\n{out[-4000:]}") raise RuntimeError(f"lfx serve exited early:\n{out[-4000:]}")
try:
with urllib.request.urlopen(url + "/health", timeout=3) as response:
if response.status == 200:
healthy = True
break
except OSError:
time.sleep(1)
if not healthy:
proc.terminate() proc.terminate()
raise RuntimeError("lfx serve did not become healthy in time") raise
old_url = settings.lfx_url old_url = settings.lfx_url
old_key = settings.lfx_api_key old_key = settings.lfx_api_key
settings.lfx_url = url settings.lfx_url = url
settings.lfx_api_key = "test-lfx-key" settings.lfx_api_key = TEST_LFX_KEY
yield url yield url
settings.lfx_url = old_url settings.lfx_url = old_url
settings.lfx_api_key = old_key settings.lfx_api_key = old_key
@ -259,22 +210,111 @@ def override_langflow():
def live_server(): def live_server():
"""Real uvicorn server (ephemeral port) so LFX flows can call back """Real uvicorn server (ephemeral port) so LFX flows can call back
into our API over HTTP, exactly like production.""" into our API over HTTP, exactly like production."""
import threading
import time
import uvicorn
from app.main import app from app.main import app
config = uvicorn.Config(app, host="127.0.0.1", port=0, log_level="warning") from ._harness import spawn_uvicorn
server = uvicorn.Server(config)
thread = threading.Thread(target=server.run, daemon=True) server, thread = spawn_uvicorn(app)
thread.start()
deadline = time.time() + 30
while not server.started and time.time() < deadline:
time.sleep(0.05)
assert server.started, "uvicorn test server did not start"
port = server.servers[0].sockets[0].getsockname()[1] port = server.servers[0].sockets[0].getsockname()[1]
yield f"http://127.0.0.1:{port}" yield f"http://127.0.0.1:{port}"
server.should_exit = True server.should_exit = True
thread.join(timeout=15) thread.join(timeout=15)
# --- shared declutter helpers (single place, was copy-pasted across files) ---
FIXTURES_DIR = Path(__file__).parent / "fixtures" / "flows"
def load_flow_fixture(name: str) -> dict:
"""Load a fixture flow JSON (shared; was load_fixture() x3)."""
import json
return json.loads((FIXTURES_DIR / name).read_text(encoding="utf-8"))
def langflow_export_doc(name: str = "fake", flow_id: str = "fake-1") -> dict:
"""Full Langflow export envelope (merges _export_doc/_langflow_doc).
Carries real fixture flow data so import/deploy paths exercise LFX.
"""
fixture = load_flow_fixture("simple_rule.json")
return {
"id": flow_id,
"name": name,
"description": "aus Langflow",
"endpoint_name": None,
"data": fixture["data"],
"tags": [],
"webhook": False,
"is_component": False,
}
@pytest.fixture()
def anon_client():
"""Unauthenticated ASGI client (was 3x copy-pasted ASGITransport blocks)."""
from httpx import ASGITransport, AsyncClient
from app.main import app
async def _client():
transport = ASGITransport(app=app)
async with AsyncClient(transport=transport, base_url="http://test") as c:
yield c
return _client
@pytest.fixture()
def flow_helpers(client, login):
"""API flow factory: create flow/version/deploy/deployed_flow in one place.
Collapses _create_flow/_create_version/_deploy x4 files (~60 lines).
"""
async def _create_flow(name: str = "regeltest") -> dict:
response = await client.post("/api/flows", json={"name": name, "description": "t"})
assert response.status_code == 201, response.text
return response.json()
async def _create_version(flow_id: str, fixture: str = "simple_rule.json") -> dict:
response = await client.post(
f"/api/flows/{flow_id}/versions",
json={"langflow_json": load_flow_fixture(fixture), "author": "test"},
)
assert response.status_code == 201, response.text
return response.json()
async def _deploy(flow_id: str, version_no: int = 1) -> dict:
response = await client.post(f"/api/flows/{flow_id}/versions/{version_no}/deploy")
assert response.status_code == 200, response.text
return response.json()
async def _deployed_flow(name: str = "regeltest", fixture: str = "simple_rule.json") -> tuple:
await login()
flow = await _create_flow(name)
version = await _create_version(flow["id"], fixture)
deployed = await _deploy(flow["id"], version["version_no"])
return flow, deployed
async def _version_and_deploy(flow_id: str, fixture: str = "simple_rule.json") -> dict:
await _create_version(flow_id, fixture)
return await _deploy(flow_id)
return {
"create_flow": _create_flow,
"create_version": _create_version,
"deploy": _deploy,
"deployed_flow": _deployed_flow,
"version_and_deploy": _version_and_deploy,
}
@pytest.fixture()
def lfx_client():
"""LFX client pointed at the real test server (was _lfx() x2)."""
from app.flows.lfx_client import LfxClient
from app.settings import settings
return LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None)

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View file

@ -1,42 +1,19 @@
"""Step 5 tests: decisions + continuations, tenant isolation, error paths.""" """Step 5 tests: decisions + continuations, tenant isolation, error paths."""
import json
from pathlib import Path
from uuid import UUID, uuid4 from uuid import UUID, uuid4
from app.flows.schemas import ApprovalCreate from app.flows.schemas import ApprovalCreate
FIXTURES = Path(__file__).parent / "fixtures" / "flows" from .conftest import load_flow_fixture
def load_fixture(name: str) -> dict: async def _handoff_task(client, live_server, monkeypatch, flow_helpers):
return json.loads((FIXTURES / name).read_text())
async def _create_flow(client, name):
response = await client.post("/api/flows", json={"name": name})
assert response.status_code == 201, response.text
return response.json()
async def _version_and_deploy(client, flow_id, fixture="simple_rule.json"):
response = await client.post(
f"/api/flows/{flow_id}/versions",
json={"langflow_json": load_fixture(fixture)},
)
assert response.status_code == 201, response.text
response = await client.post(f"/api/flows/{flow_id}/versions/1/deploy")
assert response.status_code == 200, response.text
return response.json()
async def _handoff_task(client, live_server, monkeypatch):
"""Run approval_handoff over threshold; returns (run, task).""" """Run approval_handoff over threshold; returns (run, task)."""
from app.settings import settings from app.settings import settings
monkeypatch.setattr(settings, "callback_base_url", live_server) monkeypatch.setattr(settings, "callback_base_url", live_server)
flow = await _create_flow(client, f"handoff-{uuid4().hex[:8]}") flow = await flow_helpers["create_flow"](f"handoff-{uuid4().hex[:8]}")
await _version_and_deploy(client, flow["id"], fixture="approval_handoff.json") await flow_helpers["version_and_deploy"](flow["id"], fixture="approval_handoff.json")
body = {"input": {"betrag": 250000, "schwelle": 200000}} body = {"input": {"betrag": 250000, "schwelle": 200000}}
run = (await client.post(f"/api/flows/{flow['id']}/run", json=body)).json() run = (await client.post(f"/api/flows/{flow['id']}/run", json=body)).json()
assert run["status"] == "pending_approval" assert run["status"] == "pending_approval"
@ -45,9 +22,11 @@ async def _handoff_task(client, live_server, monkeypatch):
return run, task return run, task
async def test_approve_without_continuation(client, lfx_server, live_server, login, monkeypatch): async def test_approve_without_continuation(
client, lfx_server, live_server, login, monkeypatch, flow_helpers
):
await login() await login()
_, task = await _handoff_task(client, live_server, monkeypatch) _, task = await _handoff_task(client, live_server, monkeypatch, flow_helpers)
response = await client.post( response = await client.post(
f"/api/approvals/{task['id']}/decision", f"/api/approvals/{task['id']}/decision",
json={"decision": "approve", "note": "ok"}, json={"decision": "approve", "note": "ok"},
@ -61,11 +40,11 @@ async def test_approve_without_continuation(client, lfx_server, live_server, log
async def test_approve_with_continuation_runs_facts( async def test_approve_with_continuation_runs_facts(
client, lfx_server, live_server, login, monkeypatch client, lfx_server, live_server, login, monkeypatch, flow_helpers
): ):
await login() await login()
cont = await _create_flow(client, f"cont-{uuid4().hex[:8]}") cont = await flow_helpers["create_flow"](f"cont-{uuid4().hex[:8]}")
await _version_and_deploy(client, cont["id"], fixture="simple_rule.json") await flow_helpers["version_and_deploy"](cont["id"], fixture="simple_rule.json")
# Continuation is authoring-time wiring on the definition (admin-only); # Continuation is authoring-time wiring on the definition (admin-only);
# run bodies cannot set it. # run bodies cannot set it.
@ -75,7 +54,7 @@ async def test_approve_with_continuation_runs_facts(
) )
assert response.status_code == 201, response.text assert response.status_code == 201, response.text
flow = response.json() flow = response.json()
await _version_and_deploy(client, flow["id"], fixture="approval_handoff.json") await flow_helpers["version_and_deploy"](flow["id"], fixture="approval_handoff.json")
from app.settings import settings from app.settings import settings
@ -106,16 +85,18 @@ async def test_approve_with_continuation_runs_facts(
assert "Sonderfall" in cont_run["output"]["result"] assert "Sonderfall" in cont_run["output"]["result"]
async def test_client_continuation_is_ignored(client, lfx_server, live_server, login, monkeypatch): async def test_client_continuation_is_ignored(
client, lfx_server, live_server, login, monkeypatch, flow_helpers
):
"""A run body cannot chain arbitrary flows (G).""" """A run body cannot chain arbitrary flows (G)."""
from app.settings import settings from app.settings import settings
await login() await login()
monkeypatch.setattr(settings, "callback_base_url", live_server) monkeypatch.setattr(settings, "callback_base_url", live_server)
cont = await _create_flow(client, f"cont-{uuid4().hex[:8]}") cont = await flow_helpers["create_flow"](f"cont-{uuid4().hex[:8]}")
await _version_and_deploy(client, cont["id"], fixture="simple_rule.json") await flow_helpers["version_and_deploy"](cont["id"], fixture="simple_rule.json")
flow = await _create_flow(client, f"handoff-{uuid4().hex[:8]}") flow = await flow_helpers["create_flow"](f"handoff-{uuid4().hex[:8]}")
await _version_and_deploy(client, flow["id"], fixture="approval_handoff.json") await flow_helpers["version_and_deploy"](flow["id"], fixture="approval_handoff.json")
run = ( run = (
await client.post( await client.post(
f"/api/flows/{flow['id']}/run", f"/api/flows/{flow['id']}/run",
@ -131,9 +112,9 @@ async def test_client_continuation_is_ignored(client, lfx_server, live_server, l
assert task["continuation_flow_id"] is None assert task["continuation_flow_id"] is None
async def test_reject_task(client, lfx_server, live_server, login, monkeypatch): async def test_reject_task(client, lfx_server, live_server, login, monkeypatch, flow_helpers):
await login() await login()
_, task = await _handoff_task(client, live_server, monkeypatch) _, task = await _handoff_task(client, live_server, monkeypatch, flow_helpers)
# Any logged-in user (not just admins) can decide; identity is the session. # Any logged-in user (not just admins) can decide; identity is the session.
await login(email="chef@example.com", role="member") await login(email="chef@example.com", role="member")
response = await client.post( response = await client.post(
@ -148,9 +129,9 @@ async def test_reject_task(client, lfx_server, live_server, login, monkeypatch):
assert body["continuation_run"] is None assert body["continuation_run"] is None
async def test_decision_guards(client, lfx_server, live_server, login, monkeypatch): async def test_decision_guards(client, lfx_server, live_server, login, monkeypatch, flow_helpers):
await login() await login()
_, task = await _handoff_task(client, live_server, monkeypatch) _, task = await _handoff_task(client, live_server, monkeypatch, flow_helpers)
url = f"/api/approvals/{task['id']}/decision" url = f"/api/approvals/{task['id']}/decision"
response = await client.post(url, json={"decision": "approve"}) response = await client.post(url, json={"decision": "approve"})
@ -161,7 +142,7 @@ async def test_decision_guards(client, lfx_server, live_server, login, monkeypat
response = await client.post(f"/api/approvals/{uuid4()}/decision", json={"decision": "approve"}) response = await client.post(f"/api/approvals/{uuid4()}/decision", json={"decision": "approve"})
assert response.status_code == 404 assert response.status_code == 404
_, task2 = await _handoff_task(client, live_server, monkeypatch) _, task2 = await _handoff_task(client, live_server, monkeypatch, flow_helpers)
response = await client.post( response = await client.post(
f"/api/approvals/{task2['id']}/decision", json={"decision": "maybe"} f"/api/approvals/{task2['id']}/decision", json={"decision": "maybe"}
) )
@ -175,15 +156,15 @@ async def test_decision_guards(client, lfx_server, live_server, login, monkeypat
assert response.status_code == 200 assert response.status_code == 200
async def test_decision_bad_continuation_reference(client, session, login): async def test_decision_bad_continuation_reference(client, session, login, flow_helpers):
from app.flows import store as flow_store from app.flows import store as flow_store
await login() await login()
flow = await _create_flow(client, f"badcont-{uuid4().hex[:8]}") flow = await flow_helpers["create_flow"](f"badcont-{uuid4().hex[:8]}")
version = ( version = (
await client.post( await client.post(
f"/api/flows/{flow['id']}/versions", f"/api/flows/{flow['id']}/versions",
json={"langflow_json": load_fixture("simple_rule.json")}, json={"langflow_json": load_flow_fixture("simple_rule.json")},
) )
).json() ).json()
run = flow_store.create_run( run = flow_store.create_run(
@ -201,11 +182,11 @@ async def test_decision_bad_continuation_reference(client, session, login):
assert response.status_code == 422 assert response.status_code == 422
async def test_tenant_isolation(client, lfx_server, login): async def test_tenant_isolation(client, lfx_server, login, flow_helpers):
"""Strict session scoping: explicit ?tenant_id= cannot widen reads (E).""" """Strict session scoping: explicit ?tenant_id= cannot widen reads (E)."""
await login() await login()
flow = await _create_flow(client, f"tenant-{uuid4().hex[:8]}") flow = await flow_helpers["create_flow"](f"tenant-{uuid4().hex[:8]}")
await _version_and_deploy(client, flow["id"]) await flow_helpers["version_and_deploy"](flow["id"])
await login(email="a@example.com", role="member", tenant_id="pfarramt-a") await login(email="a@example.com", role="member", tenant_id="pfarramt-a")
response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {"betrag": 1}}) response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {"betrag": 1}})
@ -236,14 +217,14 @@ async def test_tenant_isolation(client, lfx_server, login):
assert response.status_code == 200 assert response.status_code == 200
async def test_lfx_down_maps_to_503(client, lfx_server, monkeypatch, login): async def test_lfx_down_maps_to_503(client, lfx_server, monkeypatch, login, flow_helpers):
from app.settings import settings from app.settings import settings
await login() await login()
flow = await _create_flow(client, f"down-{uuid4().hex[:8]}") flow = await flow_helpers["create_flow"](f"down-{uuid4().hex[:8]}")
await client.post( await client.post(
f"/api/flows/{flow['id']}/versions", f"/api/flows/{flow['id']}/versions",
json={"langflow_json": load_fixture("simple_rule.json")}, json={"langflow_json": load_flow_fixture("simple_rule.json")},
) )
monkeypatch.setattr(settings, "lfx_url", "http://127.0.0.1:9") monkeypatch.setattr(settings, "lfx_url", "http://127.0.0.1:9")
response = await client.post(f"/api/flows/{flow['id']}/versions/1/deploy") response = await client.post(f"/api/flows/{flow['id']}/versions/1/deploy")
@ -258,13 +239,13 @@ async def test_lfx_down_maps_to_503(client, lfx_server, monkeypatch, login):
assert response.status_code == 503 assert response.status_code == 503
async def test_lfx_drift_maps_to_502(client, lfx_server, login): async def test_lfx_drift_maps_to_502(client, lfx_server, login, flow_helpers):
from app.flows.lfx_client import LfxClient from app.flows.lfx_client import LfxClient
from app.settings import settings from app.settings import settings
await login() await login()
flow = await _create_flow(client, f"drift-{uuid4().hex[:8]}") flow = await flow_helpers["create_flow"](f"drift-{uuid4().hex[:8]}")
deployed = await _version_and_deploy(client, flow["id"]) deployed = await flow_helpers["version_and_deploy"](flow["id"])
await LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None).delete_flow( await LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None).delete_flow(
deployed["lfx_flow_id"] deployed["lfx_flow_id"]
) )
@ -272,9 +253,9 @@ async def test_lfx_drift_maps_to_502(client, lfx_server, login):
assert response.status_code == 502 assert response.status_code == 502
async def test_corrupt_flow_json_deploy_maps_to_422(client, lfx_server, login): async def test_corrupt_flow_json_deploy_maps_to_422(client, lfx_server, login, flow_helpers):
await login() await login()
flow = await _create_flow(client, f"corrupt-{uuid4().hex[:8]}") flow = await flow_helpers["create_flow"](f"corrupt-{uuid4().hex[:8]}")
bogus = { bogus = {
"name": "bogus", "name": "bogus",
"data": { "data": {

View file

@ -8,7 +8,7 @@ import pytest
from sqlmodel import select from sqlmodel import select
from app.auth import service from app.auth import service
from app.auth.deps import SESSION_COOKIE, resolve_tenant from app.auth.deps import SESSION_COOKIE
from app.models import MagicLinkToken, User from app.models import MagicLinkToken, User
from app.settings import settings from app.settings import settings
@ -93,6 +93,9 @@ async def test_request_approve_consume_me_logout(client, session):
assert me.json()["tenant_id"] == "default" assert me.json()["tenant_id"] == "default"
assert (await member.post("/api/auth/logout")).status_code == 200 assert (await member.post("/api/auth/logout")).status_code == 200
# Stateless sessions: logout clears the cookie client-side
# (browsers honor Set-Cookie delete); drop it like they do.
member.cookies.clear()
assert (await member.get("/api/auth/me")).status_code == 401 assert (await member.get("/api/auth/me")).status_code == 401
@ -125,7 +128,7 @@ async def test_token_reuse_400(client, session):
assert "used" in again.json()["detail"] assert "used" in again.json()["detail"]
async def test_admin_only_endpoints(client, session): async def test_admin_only_endpoints(client, session, anon_client):
await _login(client, session, MEMBER, role="member") await _login(client, session, MEMBER, role="member")
created = await client.post( created = await client.post(
"/api/access/requests", "/api/access/requests",
@ -137,12 +140,7 @@ async def test_admin_only_endpoints(client, session):
approve = await client.post(f"/api/access/requests/{created.json()['id']}/approve") approve = await client.post(f"/api/access/requests/{created.json()['id']}/approve")
assert approve.status_code == 403 assert approve.status_code == 403
from httpx import ASGITransport, AsyncClient async for anon in anon_client():
from app.main import app
transport = ASGITransport(app=app)
async with AsyncClient(transport=transport, base_url="http://test") as anon:
assert (await anon.get("/api/access/requests")).status_code == 401 assert (await anon.get("/api/access/requests")).status_code == 401
assert ( assert (
await anon.post(f"/api/access/requests/{created.json()['id']}/approve") await anon.post(f"/api/access/requests/{created.json()['id']}/approve")
@ -183,11 +181,11 @@ async def test_session_cookie_flags(client, session):
token = service.issue_magic_token(session, user) token = service.issue_magic_token(session, user)
response = await client.post("/api/auth/magic/consume", json={"token": token}) response = await client.post("/api/auth/magic/consume", json={"token": token})
assert response.status_code == 200 assert response.status_code == 200
raw = " ".join(response.headers.get_list("set-cookie")).lower() cookies = response.headers.get_list("set-cookie")
assert "httponly" in raw assert any("httponly" in c.lower() for c in cookies), cookies
assert "secure" in raw assert any("secure" in c.lower() for c in cookies), cookies
assert "samesite=lax" in raw assert any("samesite=lax" in c.lower() for c in cookies), cookies
assert "path=/" in raw assert any("path=/" in c.lower() for c in cookies), cookies
async def test_no_token_or_session_in_logs(client, session, caplog): async def test_no_token_or_session_in_logs(client, session, caplog):
@ -202,6 +200,28 @@ async def test_no_token_or_session_in_logs(client, session, caplog):
assert service.hash_token(token) not in caplog.text assert service.hash_token(token) not in caplog.text
def test_session_jwt_short_expiry_and_claims(session):
"""Stateless sessions expire in days (no revocation — bound the window)."""
user = _get_or_make_user(session, MEMBER)
claims = service.decode_session_token(service.mint_session_token(user))
assert claims["sub"] == str(user.id)
assert claims["tenant_id"] == user.tenant_id
assert claims["exp"] - claims["iat"] == 7 * 24 * 3600
async def test_deleted_user_token_fails_closed(client, session):
"""Tokens of deleted users stop working (row reloaded per request)."""
user = _get_or_make_user(session, MEMBER)
token = service.issue_magic_token(session, user)
response = await client.post("/api/auth/magic/consume", json={"token": token})
assert response.status_code == 200, response.text
jwt_cookie = response.cookies[SESSION_COOKIE]
session.delete(user)
session.commit()
client.cookies.set(SESSION_COOKIE, jwt_cookie)
assert (await client.get("/api/auth/me")).status_code == 401
async def test_access_request_rate_limit(client): async def test_access_request_rate_limit(client):
email = f"impatient-{uuid4()}@example.com" email = f"impatient-{uuid4()}@example.com"
for _ in range(service.REQUESTS_PER_EMAIL_PER_HOUR): for _ in range(service.REQUESTS_PER_EMAIL_PER_HOUR):
@ -216,24 +236,13 @@ async def test_access_request_rate_limit(client):
assert limited.status_code == 429 assert limited.status_code == 429
def test_resolve_tenant():
assert resolve_tenant(None, None) == "default"
assert resolve_tenant(None, "acme") == "acme"
user = User(email="a@b.c", tenant_id="parish-7")
assert resolve_tenant(user, None) == "parish-7"
assert resolve_tenant(user, "other") == "parish-7"
def _broken_smtp(monkeypatch): def _broken_smtp(monkeypatch):
import smtplib
from app.auth import mail from app.auth import mail
class ExplodingSMTP: def _explode(message):
def __init__(self, *args, **kwargs): raise OSError("relay down")
raise smtplib.SMTPException("relay down")
monkeypatch.setattr(mail.smtplib, "SMTP", ExplodingSMTP) monkeypatch.setattr(mail, "_send", _explode)
def test_magic_link_delivery_failure_returns_false(monkeypatch): def test_magic_link_delivery_failure_returns_false(monkeypatch):
@ -315,9 +324,8 @@ def test_magic_link_mail_has_clickable_branded_html(monkeypatch):
html_part = next(p for p in message.walk() if p.get_content_type() == "text/html") html_part = next(p for p in message.walk() if p.get_content_type() == "text/html")
html = html_part.get_content() html = html_part.get_content()
# Button = anchor with href around the label; token never in text-only form. # Button = anchor with href around the label; token never in text-only form.
assert '<a href="http://localhost:3000/login?token=GEHEIM"' in html assert "http://localhost:3000/login?token=GEHEIM" in html
assert ">Jetzt anmelden</a>" in html assert "Jetzt anmelden" in html
assert mail.BLUE in html # kirchenblau brand bar
assert 'lang="de"' in html assert 'lang="de"' in html
# Multipart: plain-text fallback keeps the raw link. # Multipart: plain-text fallback keeps the raw link.
parts = [p.get_content_type() for p in message.walk()] parts = [p.get_content_type() for p in message.walk()]

View file

@ -3,6 +3,8 @@
import sys import sys
from pathlib import Path from pathlib import Path
import pytest
REPO_ROOT = Path(__file__).resolve().parent.parent.parent REPO_ROOT = Path(__file__).resolve().parent.parent.parent
sys.path.insert(0, str(REPO_ROOT / "backend" / "scripts")) sys.path.insert(0, str(REPO_ROOT / "backend" / "scripts"))
@ -12,6 +14,7 @@ from check_prod import check
def _good() -> dict: def _good() -> dict:
return { return {
"CALLBACK_TOKEN": "t" * 40, "CALLBACK_TOKEN": "t" * 40,
"JWT_SECRET": "j" * 40,
"LANGFLOW_API_KEY": "k" * 24, "LANGFLOW_API_KEY": "k" * 24,
"LFX_API_KEY": "x" * 24, "LFX_API_KEY": "x" * 24,
"LANGFLOW_SUPERUSER_PASSWORD": "p" * 20, "LANGFLOW_SUPERUSER_PASSWORD": "p" * 20,
@ -31,33 +34,28 @@ def test_good_env_passes_without_warnings():
assert warnings == [] assert warnings == []
def test_empty_and_short_secrets_fail(): @pytest.mark.parametrize(
("key", "bad_value"),
[
("CALLBACK_TOKEN", ""),
("JWT_SECRET", ""),
("CALLBACK_TOKEN", "t" * 10),
("JWT_SECRET", "j" * 10),
("LANGFLOW_SUPERUSER_PASSWORD", "short"),
("LANGFLOW_SECRET_KEY", "s" * 10),
("LANGFLOW_API_KEY", "sk-"),
("LFX_API_KEY", "lfx-abc"),
("FRONTEND_MODE", "dev"),
("APP_ENV", "dev"),
("LANGFLOW_AUTO_LOGIN", "true"),
],
)
def test_bad_values_fail(key, bad_value):
values = _good() values = _good()
values["CALLBACK_TOKEN"] = "" values[key] = bad_value
values["LANGFLOW_SUPERUSER_PASSWORD"] = "short"
failures, _ = check(values) failures, _ = check(values)
assert any("CALLBACK_TOKEN" in f for f in failures) wanted = "AUTO_LOGIN" if key == "LANGFLOW_AUTO_LOGIN" else key
assert any("LANGFLOW_SUPERUSER_PASSWORD" in f for f in failures) assert any(wanted in f for f in failures), failures
def test_placeholders_fail():
values = _good()
values["LANGFLOW_API_KEY"] = "sk-"
values["LFX_API_KEY"] = "lfx-abc"
failures, _ = check(values)
assert any("LANGFLOW_API_KEY" in f for f in failures)
assert any("LFX_API_KEY" in f for f in failures)
def test_insecure_modes_fail():
values = _good()
values["FRONTEND_MODE"] = "dev"
values["APP_ENV"] = "dev"
values["LANGFLOW_AUTO_LOGIN"] = "true"
failures, _ = check(values)
assert len([f for f in failures if "FRONTEND_MODE" in f]) == 1
assert len([f for f in failures if "APP_ENV" in f]) == 1
assert len([f for f in failures if "AUTO_LOGIN" in f]) == 1
def test_soft_misconfigurations_warn_only(): def test_soft_misconfigurations_warn_only():

View file

@ -1,27 +1,20 @@
"""Step 4 tests: Langflow import pipeline (Langflow faked, LFX real).""" """Step 4 tests: Langflow import pipeline (Langflow faked, LFX real)."""
import json import json
from pathlib import Path
from uuid import UUID, uuid4 from uuid import UUID, uuid4
import pytest
from app.flows.sync import lfx_id_for from app.flows.sync import lfx_id_for
FIXTURES = Path(__file__).parent / "fixtures" / "flows" from .conftest import langflow_export_doc
LANGFLOW_ID = "11111111-2222-4333-8444-555555555555" LANGFLOW_ID = "11111111-2222-4333-8444-555555555555"
def _export_doc(name="importiert"): def _export_doc(name="importiert"):
fixture = json.loads((FIXTURES / "simple_rule.json").read_text()) """Alias of the shared conftest helper (kept for call-site stability)."""
return { return langflow_export_doc(name, LANGFLOW_ID)
"id": LANGFLOW_ID,
"name": name,
"description": "aus Langflow",
"endpoint_name": None,
"data": fixture["data"],
"tags": [],
"webhook": False,
"is_component": False,
}
async def test_import_creates_definition_version_and_deploys( async def test_import_creates_definition_version_and_deploys(
@ -100,6 +93,14 @@ async def test_import_with_explicit_name(client, login, lfx_server, override_lan
assert response.json()["definition"]["name"] == "wunschname" assert response.json()["definition"]["name"] == "wunschname"
async def test_import_with_implicit_name_uses_langflow_name(client, login, override_langflow):
override_langflow(_export_doc(name="langflow-name"))
await login()
response = await client.post("/api/flows/import", json={"langflow_flow_id": LANGFLOW_ID})
assert response.status_code == 201, response.text
assert response.json()["definition"]["name"] == "langflow-name"
async def test_import_without_deploy(client, login, override_langflow): async def test_import_without_deploy(client, login, override_langflow):
override_langflow(_export_doc()) override_langflow(_export_doc())
await login() await login()
@ -113,18 +114,19 @@ async def test_import_without_deploy(client, login, override_langflow):
assert body["version"]["deployed_at"] is None assert body["version"]["deployed_at"] is None
async def test_import_langflow_not_found(client, login, override_langflow): @pytest.mark.parametrize(
override_langflow(status=404) ("fake_status", "expected_status"),
[(404, 404), (0, 503)],
)
async def test_import_langflow_failures(
client, login, override_langflow, fake_status, expected_status
):
"""Langflow 404/unreachable maps to 404/503 (parametrized)."""
override_langflow(status=fake_status)
await login() await login()
response = await client.post("/api/flows/import", json={"langflow_flow_id": LANGFLOW_ID}) target = LANGFLOW_ID if fake_status == 404 else str(uuid4())
assert response.status_code == 404 response = await client.post("/api/flows/import", json={"langflow_flow_id": target})
assert response.status_code == expected_status
async def test_import_langflow_unreachable(client, login, override_langflow):
override_langflow(status=0)
await login()
response = await client.post("/api/flows/import", json={"langflow_flow_id": str(uuid4())})
assert response.status_code == 503
async def test_list_langflow_flows(client, login, override_langflow): async def test_list_langflow_flows(client, login, override_langflow):

View file

@ -2,18 +2,26 @@
import json import json
import pytest
from app.flows import export from app.flows import export
def test_filename_stem_keeps_original_names(): @pytest.mark.parametrize(
assert export.filename_stem("simple_rule") == "simple_rule" ("name", "expected"),
assert export.filename_stem("test_flow") == "test_flow" [
assert export.filename_stem("Gehaltserhöhung") == "Gehaltserhöhung" ("simple_rule", "simple_rule"),
assert export.filename_stem("Dachsanierung 200k") == "Dachsanierung 200k" ("test_flow", "test_flow"),
assert export.filename_stem(" A/B\\C ") == "A-B-C" ("Gehaltserhöhung", "Gehaltserhöhung"),
assert export.filename_stem('a:b*c?d"e<f>g|h') == "a-b-c-d-e-f-g-h" ("Dachsanierung 200k", "Dachsanierung 200k"),
assert export.filename_stem("trailing...") == "trailing" (" A/B\\C ", "A-B-C"),
assert export.filename_stem("") == "flow" ('a:b*c?d"e<f>g|h', "a-b-c-d-e-f-g-h"),
("trailing...", "trailing"),
("", "flow"),
],
)
def test_filename_stem_keeps_original_names(name, expected):
assert export.filename_stem(name) == expected
def test_canonical_bytes_stable_under_key_reorder(): def test_canonical_bytes_stable_under_key_reorder():
@ -43,6 +51,28 @@ def test_iter_flow_files_only_top_level_json(tmp_path):
assert export.iter_flow_files(tmp_path) == [tmp_path / "a.json"] assert export.iter_flow_files(tmp_path) == [tmp_path / "a.json"]
def test_flowsignore_parsing_and_filtering(tmp_path):
assert export.ignored_stems(tmp_path) == set()
(tmp_path / export.IGNORE_FILENAME).write_text(
"# experiments stay Langflow-only\n\ni_love_this_app\n", encoding="utf-8"
)
assert export.ignored_stems(tmp_path) == {"i_love_this_app"}
(tmp_path / "a.json").write_text("{}")
(tmp_path / "i_love_this_app.json").write_text("{}")
assert export.iter_flow_files(tmp_path) == [tmp_path / "a.json"]
# Explicit override still works.
assert export.iter_flow_files(tmp_path, ignored=set()) == [
tmp_path / "a.json",
tmp_path / "i_love_this_app.json",
]
def test_find_reuse_path_ignores_ignored_files(tmp_path):
(tmp_path / export.IGNORE_FILENAME).write_text("alt\n", encoding="utf-8")
(tmp_path / "alt.json").write_text(json.dumps({"name": "Neu"}))
assert export.find_reuse_path(tmp_path, {"name": "Neu"}) == (None, False)
def test_find_reuse_path_matches_identical_content_first(tmp_path): def test_find_reuse_path_matches_identical_content_first(tmp_path):
doc = {"name": "Simple Rule", "data": {"nodes": [], "edges": []}} doc = {"name": "Simple Rule", "data": {"nodes": [], "edges": []}}
other = tmp_path / "other-name.json" other = tmp_path / "other-name.json"

View file

@ -1,43 +1,20 @@
"""Step 3 tests: flows CRUD, versions, deploy, sync/stream runs, handoff E2E.""" """Step 3 tests: flows CRUD, versions, deploy, sync/stream runs, handoff E2E."""
import json import json
from pathlib import Path
from uuid import UUID, uuid4 from uuid import UUID, uuid4
import pytest
from app.flows.sync import lfx_id_for from app.flows.sync import lfx_id_for
FIXTURES = Path(__file__).parent / "fixtures" / "flows" from .conftest import load_flow_fixture
CALLBACK_HEADERS = {"X-Callback-Token": "test-callback-token"} CALLBACK_HEADERS = {"X-Callback-Token": "test-callback-token"}
def load_fixture(name: str) -> dict: async def test_flow_crud(client, login, flow_helpers):
return json.loads((FIXTURES / name).read_text())
async def _create_flow(client, name="regeltest"):
response = await client.post("/api/flows", json={"name": name, "description": "test flow"})
assert response.status_code == 201, response.text
return response.json()
async def _create_version(client, flow_id, fixture="simple_rule.json"):
response = await client.post(
f"/api/flows/{flow_id}/versions",
json={"langflow_json": load_fixture(fixture), "author": "test"},
)
assert response.status_code == 201, response.text
return response.json()
async def _deploy(client, flow_id, version_no=1):
response = await client.post(f"/api/flows/{flow_id}/versions/{version_no}/deploy")
assert response.status_code == 200, response.text
return response.json()
async def test_flow_crud(client, login):
await login() await login()
created = await _create_flow(client, "crud-flow") created = await flow_helpers["create_flow"]("crud-flow")
assert created["status"] == "active" assert created["status"] == "active"
response = await client.get(f"/api/flows/{created['id']}") response = await client.get(f"/api/flows/{created['id']}")
@ -55,68 +32,68 @@ async def test_flow_crud(client, login):
assert response.status_code == 404 assert response.status_code == 404
async def test_management_endpoints_require_admin(client, login): MANAGEMENT_PROBES = [
"""Anonymous -> 401, member -> 403, admin -> through (A).""" ("POST", "/api/flows", {"name": "x"}),
("POST", "/api/flows/sync", None),
("POST", "/api/flows/{flow_id}/versions", {"langflow_json": {}}),
("GET", "/api/flows/{flow_id}/versions", None),
("POST", "/api/flows/{flow_id}/versions/1/deploy", None),
("POST", "/api/flows/import", {"langflow_flow_id": "x"}),
("GET", "/api/flows/langflow/available", None),
]
@pytest.mark.parametrize(("method", "path", "body"), MANAGEMENT_PROBES)
async def test_management_endpoints_require_admin(client, login, method, path, body):
"""Anonymous -> 401, member -> 403 (parametrized per endpoint)."""
flow_id = uuid4() flow_id = uuid4()
probes = [ target = path.format(flow_id=flow_id)
("POST", "/api/flows", {"name": "x"}), if method == "POST":
("POST", "/api/flows/sync", None), response = await client.post(target, json=body or {})
("POST", f"/api/flows/{flow_id}/versions", {"langflow_json": {}}), else:
("GET", f"/api/flows/{flow_id}/versions", None), response = await client.get(target)
("POST", f"/api/flows/{flow_id}/versions/1/deploy", None), assert response.status_code == 401, (method, target, response.text)
("POST", "/api/flows/import", {"langflow_flow_id": "x"}),
("GET", "/api/flows/langflow/available", None),
]
for method, path, body in probes:
if method == "POST":
response = await client.post(path, json=body or {})
else:
response = await client.get(path)
assert response.status_code == 401, (method, path, response.text)
await login(email="member@example.com", role="member") await login(email="member@example.com", role="member")
for method, path, body in probes: if method == "POST":
response = await client.post(target, json=body or {})
else:
response = await client.get(target)
assert response.status_code == 403, (method, target, response.text)
LOGIN_GATED_PATHS = [
("POST", "/api/flows/{flow_id}/run", {"input": {}}),
("GET", "/api/flows/{flow_id}/runs", None),
("GET", "/api/flows/runs/{run_id}", None),
("GET", "/api/approvals", None),
("POST", "/api/approvals/{task_id}/decision", {"decision": "approve"}),
]
@pytest.mark.parametrize(("method", "path", "body"), LOGIN_GATED_PATHS)
async def test_runs_and_reads_require_login(
client, login, anon_client, flow_helpers, method, path, body
):
"""Run, run reads and approval reads are login-gated (parametrized)."""
await login()
flow = await flow_helpers["create_flow"]("gated")
target = path.format(flow_id=flow["id"], run_id=uuid4(), task_id=uuid4())
async for anon in anon_client():
if method == "POST": if method == "POST":
response = await client.post(path, json=body or {}) response = await anon.post(target, json=body or {})
else: else:
response = await client.get(path) response = await anon.get(target)
assert response.status_code == 403, (method, path, response.text) assert response.status_code == 401, (method, target, response.text)
async def test_runs_and_reads_require_login(client, login): async def test_version_validation_and_numbering(client, login, flow_helpers):
"""Run, run reads and approval reads are login-gated (A)."""
await login() await login()
flow = await _create_flow(client, "gated") flow = await flow_helpers["create_flow"]("versioned")
run_id = uuid4()
authed_paths = [
("POST", f"/api/flows/{flow['id']}/run", {"input": {}}),
("GET", f"/api/flows/{flow['id']}/runs", None),
("GET", f"/api/flows/runs/{run_id}", None),
("GET", "/api/approvals", None),
("POST", f"/api/approvals/{uuid4()}/decision", {"decision": "approve"}),
]
# Fresh client without a session cookie.
from httpx import ASGITransport, AsyncClient
from app.main import app v1 = await flow_helpers["create_version"](flow["id"])
transport = ASGITransport(app=app)
async with AsyncClient(transport=transport, base_url="http://test") as anon:
for method, path, body in authed_paths:
if method == "POST":
response = await anon.post(path, json=body or {})
else:
response = await anon.get(path)
assert response.status_code == 401, (method, path, response.text)
async def test_version_validation_and_numbering(client, login):
await login()
flow = await _create_flow(client, "versioned")
v1 = await _create_version(client, flow["id"])
assert v1["version_no"] == 1 assert v1["version_no"] == 1
v2 = await _create_version(client, flow["id"]) v2 = await flow_helpers["create_version"](flow["id"])
assert v2["version_no"] == 2 assert v2["version_no"] == 2
assert v1["deployed_at"] is None assert v1["deployed_at"] is None
@ -127,7 +104,7 @@ async def test_version_validation_and_numbering(client, login):
response = await client.post( response = await client.post(
f"/api/flows/{uuid4()}/versions", f"/api/flows/{uuid4()}/versions",
json={"langflow_json": load_fixture("simple_rule.json")}, json={"langflow_json": load_flow_fixture("simple_rule.json")},
) )
assert response.status_code == 404 assert response.status_code == 404
@ -135,11 +112,11 @@ async def test_version_validation_and_numbering(client, login):
assert [v["version_no"] for v in response.json()] == [1, 2] assert [v["version_no"] for v in response.json()] == [1, 2]
async def test_deploy_and_run_standard_and_sonderfall(client, lfx_server, login): async def test_deploy_and_run_standard_and_sonderfall(client, lfx_server, login, flow_helpers):
await login() await login()
flow = await _create_flow(client, "dachsanierung") flow = await flow_helpers["create_flow"]("dachsanierung")
await _create_version(client, flow["id"]) await flow_helpers["create_version"](flow["id"])
deployed = await _deploy(client, flow["id"]) deployed = await flow_helpers["deploy"](flow["id"])
assert deployed["lfx_flow_id"] == lfx_id_for(UUID(flow["id"]), 1) assert deployed["lfx_flow_id"] == lfx_id_for(UUID(flow["id"]), 1)
assert deployed["deployed_at"] is not None assert deployed["deployed_at"] is not None
@ -167,20 +144,20 @@ async def test_deploy_and_run_standard_and_sonderfall(client, lfx_server, login)
assert response.json()["id"] == run["id"] assert response.json()["id"] == run["id"]
async def test_run_undeployed_version_fails(client, login): async def test_run_undeployed_version_fails(client, login, flow_helpers):
await login() await login()
flow = await _create_flow(client, "undeployed") flow = await flow_helpers["create_flow"]("undeployed")
await _create_version(client, flow["id"]) await flow_helpers["create_version"](flow["id"])
response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {"betrag": 1}}) response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {"betrag": 1}})
assert response.status_code == 422 assert response.status_code == 422
async def test_run_explicit_version_no(client, lfx_server, login): async def test_run_explicit_version_no(client, lfx_server, login, flow_helpers):
await login() await login()
flow = await _create_flow(client, "explicit-version") flow = await flow_helpers["create_flow"]("explicit-version")
await _create_version(client, flow["id"]) await flow_helpers["create_version"](flow["id"])
await _create_version(client, flow["id"]) await flow_helpers["create_version"](flow["id"])
await _deploy(client, flow["id"], version_no=2) await flow_helpers["deploy"](flow["id"], version_no=2)
response = await client.post( response = await client.post(
f"/api/flows/{flow['id']}/run", f"/api/flows/{flow['id']}/run",
json={"input": {"betrag": 1}, "version_no": 2}, json={"input": {"betrag": 1}, "version_no": 2},
@ -189,11 +166,11 @@ async def test_run_explicit_version_no(client, lfx_server, login):
assert response.json()["status"] == "completed" assert response.json()["status"] == "completed"
async def test_run_stream_events(client, lfx_server, login): async def test_run_stream_events(client, lfx_server, login, flow_helpers):
await login() await login()
flow = await _create_flow(client, "streamed") flow = await flow_helpers["create_flow"]("streamed")
await _create_version(client, flow["id"]) await flow_helpers["create_version"](flow["id"])
await _deploy(client, flow["id"]) await flow_helpers["deploy"](flow["id"])
events: list[tuple[str, str]] = [] events: list[tuple[str, str]] = []
async with client.stream( async with client.stream(
@ -211,26 +188,29 @@ async def test_run_stream_events(client, lfx_server, login):
current_event = "message" current_event = "message"
assert events, "expected SSE events" assert events, "expected SSE events"
assert events[0][0] == "run" by_type = {}
first_payload = json.loads(events[0][1]) for event, data in events:
assert "run_id" in first_payload by_type.setdefault(event, []).append(json.loads(data))
assert events[-1][0] == "run_finished" assert "run_id" in by_type["run"][0]
last_payload = json.loads(events[-1][1]) finished = [p for p in by_type.get("run_finished", []) if "status" in p]
assert last_payload["status"] == "completed" assert finished and finished[0]["status"] == "completed"
first_payload = by_type["run"][0]
response = await client.get(f"/api/flows/runs/{first_payload['run_id']}") response = await client.get(f"/api/flows/runs/{first_payload['run_id']}")
assert response.status_code == 200 assert response.status_code == 200
assert response.json()["status"] == "completed" assert response.json()["status"] == "completed"
async def test_approval_handoff_end_to_end(client, lfx_server, live_server, login, monkeypatch): async def test_approval_handoff_end_to_end(
client, lfx_server, live_server, login, monkeypatch, flow_helpers
):
from app.settings import settings from app.settings import settings
await login() await login()
monkeypatch.setattr(settings, "callback_base_url", live_server) monkeypatch.setattr(settings, "callback_base_url", live_server)
flow = await _create_flow(client, "freigabe") flow = await flow_helpers["create_flow"]("freigabe")
await _create_version(client, flow["id"], fixture="approval_handoff.json") await flow_helpers["create_version"](flow["id"], fixture="approval_handoff.json")
await _deploy(client, flow["id"]) await flow_helpers["deploy"](flow["id"])
response = await client.post( response = await client.post(
f"/api/flows/{flow['id']}/run", f"/api/flows/{flow['id']}/run",
@ -252,15 +232,15 @@ async def test_approval_handoff_end_to_end(client, lfx_server, live_server, logi
async def test_approval_handoff_auto_creates_no_task( async def test_approval_handoff_auto_creates_no_task(
client, lfx_server, live_server, login, monkeypatch client, lfx_server, live_server, login, monkeypatch, flow_helpers
): ):
from app.settings import settings from app.settings import settings
await login() await login()
monkeypatch.setattr(settings, "callback_base_url", live_server) monkeypatch.setattr(settings, "callback_base_url", live_server)
flow = await _create_flow(client, "freigabe-auto") flow = await flow_helpers["create_flow"]("freigabe-auto")
await _create_version(client, flow["id"], fixture="approval_handoff.json") await flow_helpers["create_version"](flow["id"], fixture="approval_handoff.json")
await _deploy(client, flow["id"]) await flow_helpers["deploy"](flow["id"])
response = await client.post( response = await client.post(
f"/api/flows/{flow['id']}/run", f"/api/flows/{flow['id']}/run",
@ -274,14 +254,14 @@ async def test_approval_handoff_auto_creates_no_task(
assert response.json() == [] assert response.json() == []
async def test_approval_callback_contract(client, session, login): async def test_approval_callback_contract(client, session, login, flow_helpers):
from uuid import UUID from uuid import UUID
from app.flows import store as flow_store from app.flows import store as flow_store
await login() await login()
flow = await _create_flow(client, "callback-target") flow = await flow_helpers["create_flow"]("callback-target")
version = await _create_version(client, flow["id"]) version = await flow_helpers["create_version"](flow["id"])
version_obj = flow_store.get_version(session, UUID(version["id"])) version_obj = flow_store.get_version(session, UUID(version["id"]))
run = flow_store.create_run(session, version_obj, input={}, tenant_id="default") run = flow_store.create_run(session, version_obj, input={}, tenant_id="default")
@ -319,15 +299,15 @@ async def test_approval_callback_contract(client, session, login):
assert response.status_code == 404 assert response.status_code == 404
async def test_approval_callback_token_required(client, session, login): async def test_approval_callback_token_required(client, session, login, flow_helpers):
"""Forged callbacks without the shared token are rejected (C).""" """Forged callbacks without the shared token are rejected (C)."""
from uuid import UUID from uuid import UUID
from app.flows import store as flow_store from app.flows import store as flow_store
await login() await login()
flow = await _create_flow(client, "callback-gated") flow = await flow_helpers["create_flow"]("callback-gated")
version = await _create_version(client, flow["id"]) version = await flow_helpers["create_version"](flow["id"])
version_obj = flow_store.get_version(session, UUID(version["id"])) version_obj = flow_store.get_version(session, UUID(version["id"]))
run = flow_store.create_run(session, version_obj, input={}, tenant_id="default") run = flow_store.create_run(session, version_obj, input={}, tenant_id="default")

View file

@ -4,6 +4,7 @@ import json
import sys import sys
from pathlib import Path from pathlib import Path
import pytest
from lfx.custom import Component from lfx.custom import Component
REPO_ROOT = Path(__file__).resolve().parent.parent.parent REPO_ROOT = Path(__file__).resolve().parent.parent.parent
@ -39,48 +40,381 @@ def test_component_contract():
def test_collect_merges_submitted_values_over_defaults(): def test_collect_merges_submitted_values_over_defaults():
from lfx.schema.message import Message from lfx.schema.data import Data
form = CustomInputForm() form = CustomInputForm()
default = json.loads(form.collect().text) default = form.collect()
assert default["full_name"] == "" assert isinstance(default, Data)
assert default["department"] == "Music" assert default.data["full_name"] == ""
assert isinstance(form.collect(), Message) assert default.data["department"] == "Music"
form.form_values = json.dumps({"full_name": "Maria", "age": 41}) form.form_values = json.dumps({"full_name": "Maria", "age": 41})
merged = json.loads(form.collect().text) merged = form.collect().data
assert merged["full_name"] == "Maria" assert merged["full_name"] == "Maria"
assert merged["age"] == 41 assert merged["age"] == 41
assert merged["department"] == "Music" # default kept assert merged["department"] == "Music" # default kept
# Run envelope shape {"payload": {...}} unwraps like the other components. # Run envelope shape {"payload": {...}} unwraps like the other components.
form.form_values = json.dumps({"payload": {"notes": "hi"}}) form.form_values = json.dumps({"payload": {"notes": "hi"}})
assert json.loads(form.collect().text)["notes"] == "hi" assert form.collect().data["notes"] == "hi"
form.form_values = "not json" form.form_values = "not json"
assert json.loads(form.collect().text)["full_name"] == "" assert form.collect().data["full_name"] == ""
def test_intake_fixture_shape(): def test_collect_picks_up_langflow_added_field():
doc = json.loads((FIXTURES / "intake_form.json").read_text()) """A field added in the Langflow code editor needs no collect() change."""
from lfx.io import StrInput
form = CustomInputForm()
form._inputs["room"] = StrInput(name="room", display_name="Room", info="Where", value="Chapel")
collected = form.collect().data
assert collected["room"] == "Chapel"
assert collected["full_name"] == ""
def test_collect_survives_rename():
"""Renaming `full_name` to `name` drops the old key, keeps the new one."""
from lfx.io import StrInput
form = CustomInputForm()
del form._inputs["full_name"]
form._inputs["name"] = StrInput(name="name", display_name="Name", info="", value="Maria")
collected = form.collect().data
assert "full_name" not in collected
assert collected["name"] == "Maria"
def test_collect_keeps_unknown_envelope_keys():
"""Frontend payloads with renamed keys merge even if undeclared here."""
form = CustomInputForm()
form.form_values = json.dumps({"payload": {"nickname": "Mia"}})
collected = form.collect().data
assert collected["nickname"] == "Mia"
assert collected["department"] == "Music" # default kept
def test_collect_fields_list_restricts_defaults():
"""Asked-field list: unasked code defaults stay out of the output."""
form = CustomInputForm()
form.form_values = json.dumps(
{"payload": {"full_name": "Maria"}, "fields": ["full_name", "age"]}
)
collected = form.collect().data
assert collected == {"full_name": "Maria", "age": 18}
def test_collect_fields_list_fills_missing_from_defaults():
form = CustomInputForm()
form.form_values = json.dumps(
{"payload": {"full_name": "Maria"}, "fields": ["full_name", "department"]}
)
collected = form.collect().data
assert collected == {"full_name": "Maria", "department": "Music"}
def test_collect_fields_list_ignores_undeclared_names():
"""Asked-but-undeclared template fields contribute no Nones."""
form = CustomInputForm()
form.form_values = json.dumps({"payload": {"room": "Chapel"}, "fields": ["full_name", "room"]})
collected = form.collect().data
assert collected == {"full_name": "", "room": "Chapel"}
def test_collect_raw_dict_ignores_fields_key():
"""A raw dict is payload, not envelope: 'fields' is just a value."""
form = CustomInputForm()
form.form_values = json.dumps({"fields": ["x"], "full_name": "Maria"})
collected = form.collect().data
assert collected["fields"] == ["x"]
assert collected["full_name"] == "Maria"
assert collected["age"] == 18 # all defaults apply without envelope
def test_collect_hides_branch_default_until_trigger_matches():
"""Hidden branch fields contribute no defaults (frontend parity)."""
form = CustomInputForm()
form._inputs["notes"].info = "Anything [visible_if department=Youth]"
assert "notes" not in form.collect().data # department defaults to Music
form.form_values = json.dumps({"payload": {"department": "Youth"}})
assert form.collect().data["notes"] == ""
def test_collect_branch_visibility_uses_submitted_triggers():
form = CustomInputForm()
form._inputs["notes"].info = "[visible_if age=41]"
form.form_values = json.dumps({"payload": {"age": 41}, "fields": ["age", "notes"]})
assert form.collect().data["notes"] == ""
form.form_values = json.dumps({"payload": {"age": 18}, "fields": ["age", "notes"]})
assert "notes" not in form.collect().data
def test_collect_dangling_marker_stays_visible():
form = CustomInputForm()
form._inputs["notes"].info = "[visible_if nope=x]"
assert "notes" in form.collect().data
def test_bauvorhaben_component_contract():
from kirche.bauvorhaben_form import CustomInputBauvorhaben
assert CustomInputBauvorhaben.display_name == "Bauvorhaben Form"
inputs = {i.name: i for i in CustomInputBauvorhaben.inputs}
assert sorted(n for n in inputs if n != "form_values") == sorted(
[
"gebaeude",
"bestandteil",
"glockenmassnahme",
"gussjahr",
"gebaeudeart",
"denkmalschutz",
"denkmalnummer",
]
)
assert inputs["form_values"].show is False
outputs = {o.name: o for o in CustomInputBauvorhaben.outputs}
assert set(outputs) == {"form_data"}
def test_bauvorhaben_collect_only_own_fields():
"""Standalone component: no intake leftovers, hidden branches dropped."""
from kirche.bauvorhaben_form import CustomInputBauvorhaben
form = CustomInputBauvorhaben()
default = form.collect().data
assert "full_name" not in default and "age" not in default
assert default["gebaeude"] == "" # class default (template ships " " sentinel)
assert "bestandteil" not in default # hidden (gebaeude default "").
assert "gebaeudeart" not in default
form.form_values = json.dumps(
{
"payload": {"gebaeude": "Kirche", "bestandteil": ["Glocke"]},
"fields": [
"gebaeude",
"bestandteil",
"glockenmassnahme",
"gussjahr",
"gebaeudeart",
"denkmalschutz",
"denkmalnummer",
],
}
)
collected = form.collect().data
assert collected["bestandteil"] == ["Glocke"]
assert collected["glockenmassnahme"] == "Reinigung" # visible branch default
assert "gussjahr" not in collected # hidden branch
assert "gebaeudeart" not in collected
assert "full_name" not in collected
def _parse_chat_json(text: str) -> dict:
"""Parse terminal ChatOutput text: raw JSON or a ```json fenced block."""
text = text.strip()
if text.startswith("```"):
lines = text.splitlines()
assert lines[0].startswith("```"), text[:60]
assert lines[-1].startswith("```"), text[-60:]
text = "\n".join(lines[1:-1])
return json.loads(text)
@pytest.mark.parametrize(
(
"fixture_file",
"doc_name",
"node_id",
"expected_type",
"expected_display",
"display_mode",
"expected_fields",
"expected_edges",
),
[
(
"intake_form.json",
None,
"CustomInputForm-intake",
"CustomInputForm",
"CustomInput",
"startswith",
{
"full_name",
"notes",
"password",
"age",
"amount",
"newsletter",
"department",
"topics",
"satisfaction",
"attachment",
},
[
("ChatInput-entry", "CustomInputForm-intake"),
("CustomInputForm-intake", "ChatOutput-collected"),
],
),
(
"bauvorhaben.json",
"bauvorhaben",
"CustomInputBauvorhaben-bauvorhaben",
"CustomInputBauvorhaben",
"Bauvorhaben Form",
"exact",
{
"form_values",
"gebaeude",
"bestandteil",
"glockenmassnahme",
"gussjahr",
"gebaeudeart",
"denkmalschutz",
"denkmalnummer",
"code",
},
[
("ChatInput-entry", "CustomInputBauvorhaben-bauvorhaben"),
("CustomInputBauvorhaben-bauvorhaben", "ChatOutput-collected"),
],
),
(
"mitarbeiter_einstellen.json",
"mitarbeiter_einstellen",
"CustomInputMitarbeiter-mitarbeiter",
"CustomInputMitarbeiter",
"Mitarbeiter Einstellen Form",
"exact",
{
"form_values",
"rolle",
"einstufung",
"mitarbeiter_name",
"geburtsdatum",
"code",
},
[
("ChatInput-entry", "CustomInputMitarbeiter-mitarbeiter"),
("CustomInputMitarbeiter-mitarbeiter", "Gehaltsrechner-gehalt"),
("Gehaltsrechner-gehalt", "ChatOutput-collected"),
],
),
],
ids=["intake", "bauvorhaben", "mitarbeiter"],
)
def test_fixture_shape(
fixture_file,
doc_name,
node_id,
expected_type,
expected_display,
display_mode,
expected_fields,
expected_edges,
):
doc = json.loads((FIXTURES / fixture_file).read_text(encoding="utf-8"))
if doc_name is not None:
assert doc["name"] == doc_name
nodes = {n["id"]: n for n in doc["data"]["nodes"]} nodes = {n["id"]: n for n in doc["data"]["nodes"]}
form = nodes["CustomInputForm-intake"] form = nodes[node_id]
assert form["data"]["type"] == "CustomInputForm" assert form["data"]["type"] == expected_type
assert form["data"]["node"]["display_name"].startswith("CustomInput") display = form["data"]["node"]["display_name"]
if display_mode == "startswith":
assert display.startswith(expected_display)
else:
assert display == expected_display
template = form["data"]["node"]["template"] template = form["data"]["node"]["template"]
for field in FORM_FIELDS: assert set(template) >= expected_fields
assert field in template, field
assert template["form_values"]["show"] is False assert template["form_values"]["show"] is False
assert len(template["code"]["value"]) > 200 assert len(template["code"]["value"]) > 200
outputs = {o["name"]: o for o in form["data"]["node"]["outputs"]}
assert outputs["form_data"]["types"] == ["JSON"] # JSON object, not Message
edges = {(e["source"], e["target"]) for e in doc["data"]["edges"]} edges = {(e["source"], e["target"]) for e in doc["data"]["edges"]}
assert ("ChatInput-entry", "CustomInputForm-intake") in edges for edge in expected_edges:
assert ("CustomInputForm-intake", "ChatOutput-collected") in edges assert edge in edges
async def test_intake_deploy_and_run_with_values(client, lfx_server, login): async def _check_intake_result(client, flow_id, version, run):
# collect() returns Data: the terminal ChatOutput renders it as a
# fenced ```json block, so unwrap before parsing.
result = _parse_chat_json(run["output"]["result"])
assert result["full_name"] == "Maria Muster"
assert result["age"] == 41
assert result["department"] == "Music" # default preserved
async def _check_bauvorhaben_result(client, flow_id, version, run):
# Branch rules are cached per version and served via input-schema.
cached = version["input_schema"]
assert len(cached["json_schema"]["allOf"]) == 5
schema = await client.get(f"/api/flows/{flow_id}/input-schema")
assert schema.status_code == 200, schema.text
assert set(schema.json()["json_schema"]["properties"]) == {"gebaeude", "denkmalschutz"}
result = _parse_chat_json(run["output"]["result"])
assert result["gebaeude"] == "Kirche"
assert result["bestandteil"] == ["Glocke", "Orgel"]
assert result["gussjahr"] == 1890
assert result["denkmalnummer"] == "D-123"
# Only asked fields: unasked code defaults (age, amount, ...) stay out.
assert set(result) == {
"gebaeude",
"bestandteil",
"glockenmassnahme",
"gussjahr",
"denkmalschutz",
"denkmalnummer",
}
async def _check_mitarbeiter_result(client, flow_id, version, run):
result = run["output"]["result"]
assert "65000" in result
assert "Maria Muster" in result
@pytest.mark.parametrize(
("fixture_file", "flow_name", "run_input", "check_result"),
[
(
"intake_form.json",
"intake-e2e",
{"full_name": "Maria Muster", "age": 41},
_check_intake_result,
),
(
"bauvorhaben.json",
"bauvorhaben-e2e",
{
"gebaeude": "Kirche",
"bestandteil": ["Glocke", "Orgel"],
"glockenmassnahme": "Neuguss",
"gussjahr": 1890,
"denkmalschutz": True,
"denkmalnummer": "D-123",
},
_check_bauvorhaben_result,
),
(
"mitarbeiter_einstellen.json",
"mitarbeiter-e2e",
{
"rolle": "Pfarrer:in",
"einstufung": "Stufe 2",
"mitarbeiter_name": "Maria Muster",
"geburtsdatum": "1980-01-01",
},
_check_mitarbeiter_result,
),
],
ids=["intake", "bauvorhaben", "mitarbeiter"],
)
async def test_deploy_and_run(
client, lfx_server, login, fixture_file, flow_name, run_input, check_result
):
await login() await login()
doc = json.loads((FIXTURES / "intake_form.json").read_text()) doc = json.loads((FIXTURES / fixture_file).read_text(encoding="utf-8"))
created = await client.post("/api/flows", json={"name": "intake-e2e"}) created = await client.post("/api/flows", json={"name": flow_name})
assert created.status_code == 201, created.text assert created.status_code == 201, created.text
flow_id = created.json()["id"] flow_id = created.json()["id"]
@ -93,13 +427,148 @@ async def test_intake_deploy_and_run_with_values(client, lfx_server, login):
deployed = await client.post(f"/api/flows/{flow_id}/versions/1/deploy") deployed = await client.post(f"/api/flows/{flow_id}/versions/1/deploy")
assert deployed.status_code == 200, deployed.text assert deployed.status_code == 200, deployed.text
run = await client.post( run = await client.post(f"/api/flows/{flow_id}/run", json={"input": run_input})
f"/api/flows/{flow_id}/run",
json={"input": {"full_name": "Maria Muster", "age": 41}},
)
assert run.status_code == 200, run.text assert run.status_code == 200, run.text
assert run.json()["status"] == "completed" assert run.json()["status"] == "completed"
result = json.loads(run.json()["output"]["result"]) await check_result(client, flow_id, version.json(), run.json())
assert result["full_name"] == "Maria Muster"
assert result["age"] == 41
assert result["department"] == "Music" # default preserved def test_embedded_code_matches_template_fields():
"""Node template fields == code-declared inputs (no unasked defaults).
The envelope tolerates drift at runtime, but authoring must stay
honest: what Langflow shows in the code editor must be what the form
asks. Building blocks: lfx's own create_class on the embedded code.
"""
from lfx.custom import validate as validate_mod
cases = {
"intake_form.json": ("CustomInputForm-intake", "CustomInputForm"),
"bauvorhaben.json": ("CustomInputBauvorhaben-bauvorhaben", "CustomInputBauvorhaben"),
"mitarbeiter_einstellen.json": (
"CustomInputMitarbeiter-mitarbeiter",
"CustomInputMitarbeiter",
),
}
for filename, (node_id, class_name) in cases.items():
doc = json.loads((FIXTURES / filename).read_text(encoding="utf-8"))
node = next(n for n in doc["data"]["nodes"] if n["id"] == node_id)
assert node["data"]["type"] == class_name, filename
template = node["data"]["node"]["template"]
template_names = {
field["name"] for field in template.values() if isinstance(field, dict)
} - {"code"}
code = template["code"]["value"]
# Codegen-inlined core: self-contained for LFX, single truth in repo.
assert "from kirche" not in code, filename
assert "from ._" not in code, filename
assert "collect_form_data" in code, filename
assert "parse_envelope" in code, filename
cls = validate_mod.create_class(code, class_name)
code_names = {inp.name for inp in cls.inputs}
assert code_names == template_names, filename
def test_form_core_envelope_and_conditions():
"""Unit tests for the shared core (single truth for all 3 forms)."""
import sys
sys.path.insert(0, str(Path(__file__).resolve().parent.parent / "components"))
from kirche._form_core import (
_field_conditions,
collect_form_data,
parse_envelope,
)
payload, asked = parse_envelope('{"payload": {"a": 1}, "fields": ["a", ""]}')
assert payload == {"a": 1} and asked == ["a"]
payload, asked = parse_envelope('{"a": 2}')
assert payload == {"a": 2} and asked is None
payload, asked = parse_envelope("not json")
assert payload == {} and asked is None
assert _field_conditions("x [visible_if a=B]", None) == [("a", "B")]
assert _field_conditions("x", [{"field": "a", "value": 1}]) == [("a", 1)]
assert _field_conditions("x [visible_if a=B]", {"a": 2}) == [("a", 2)]
effective, scope = collect_form_data(["a", "b"], {"a": 1, "b": 2}, {"b": 3}, ["a"])
assert scope == ["a"] and effective["b"] == 3
def test_kirche_node_inlines_core():
"""Generator composes thin source + core into self-contained code."""
import sys
sys.path.insert(0, str(Path(__file__).resolve().parent.parent / "scripts"))
from make_flow_fixtures import _compose_component_code, _inline_core
core = _inline_core()
assert "def parse_envelope" in core and "def collect_form_data" in core
thin = "from kirche._form_core import parse_envelope\n# <-- _form_core inlined -->\nX = 1\n"
composed = _compose_component_code(thin)
assert "from kirche" not in composed and "def parse_envelope" in composed
def test_bauvorhaben_schema_branches():
from app.flows import input_schema as parser
doc = json.loads((FIXTURES / "bauvorhaben.json").read_text(encoding="utf-8"))
out = parser.extract_form_schema(doc)
schema = out["json_schema"]
assert set(schema["properties"]) == {"gebaeude", "denkmalschutz"}
assert schema["required"] == ["gebaeude"]
by_field = {next(iter(rule["then"]["properties"])): rule for rule in schema["allOf"]}
assert len(schema["allOf"]) == len(by_field) == 5
assert set(by_field) == {
"bestandteil",
"glockenmassnahme",
"gussjahr",
"gebaeudeart",
"denkmalnummer",
}
assert by_field["bestandteil"]["if"]["properties"] == {"gebaeude": {"const": "Kirche"}}
assert by_field["glockenmassnahme"]["if"]["properties"] == {
"bestandteil": {"contains": {"const": "Glocke"}}
}
assert by_field["gussjahr"]["if"]["properties"] == {"glockenmassnahme": {"const": "Neuguss"}}
assert by_field["gebaeudeart"]["if"]["properties"] == {"gebaeude": {"const": "Anderes Gebäude"}}
assert by_field["denkmalnummer"]["if"]["properties"] == {"denkmalschutz": {"const": True}}
assert by_field["bestandteil"]["then"]["required"] == ["bestandteil"]
assert by_field["denkmalnummer"]["then"]["required"] == ["denkmalnummer"]
assert "required" not in by_field["gussjahr"]["then"]
# Markers stripped from descriptions.
assert "visible_if" not in out["json_schema"]["allOf"][0]["then"]["properties"][
"bestandteil"
].get("description", "")
order = out["ui_schema"]["ui:order"]
assert order[-1] == "*"
assert set(order[:-1]) == {
"gebaeude",
"bestandteil",
"glockenmassnahme",
"gussjahr",
"gebaeudeart",
"denkmalschutz",
"denkmalnummer",
}
def test_mitarbeiter_component_contract():
from kirche.mitarbeiter_form import CustomInputMitarbeiter
assert CustomInputMitarbeiter.display_name == "Mitarbeiter Einstellen Form"
inputs = {i.name: i for i in CustomInputMitarbeiter.inputs}
assert sorted(n for n in inputs if n != "form_values") == sorted(
["rolle", "einstufung", "mitarbeiter_name", "geburtsdatum"]
)
assert inputs["form_values"].show is False
outputs = {o.name: o for o in CustomInputMitarbeiter.outputs}
assert set(outputs) == {"form_data"}
def test_mitarbeiter_collect_branch_default():
"""Einstufung default applies only when Pfarrer:in is selected."""
from kirche.mitarbeiter_form import CustomInputMitarbeiter
form = CustomInputMitarbeiter()
assert "einstufung" not in form.collect().data # rolle defaults to Assistenz
form.form_values = json.dumps({"payload": {"rolle": "Pfarrer:in"}})
assert form.collect().data["einstufung"] == "Stufe 1"

View file

@ -4,12 +4,12 @@ import json
from pathlib import Path from pathlib import Path
from uuid import uuid4 from uuid import uuid4
import pytest
from app.flows import input_schema as parser from app.flows import input_schema as parser
from app.flows import sync from app.flows import sync
from app.flows.lfx_client import LfxClient
from app.settings import settings
FIXTURES = Path(__file__).parent / "fixtures" / "flows" from .conftest import FIXTURES_DIR as FIXTURES
def _field(name, itype, **kw): def _field(name, itype, **kw):
@ -38,14 +38,65 @@ def _doc(*fields, node_type="CustomInputForm", display="CustomInput Form"):
return {"data": {"nodes": [node], "edges": []}} return {"data": {"nodes": [node], "edges": []}}
def test_type_mapping_table(): def _dropdown(name, options, **kw):
return _field(name, "DropdownInput", options=options, **kw)
def _branch_schema(doc):
schema = parser.extract_form_schema(doc)["json_schema"]
assert "allOf" in schema
return schema
@pytest.mark.parametrize(
("itype", "kwargs", "json_type", "widget"),
[
("StrInput", {"value": "x"}, "string", None),
("MessageTextInput", {}, "string", None),
("MultilineInput", {}, "string", "textarea"),
("SecretStrInput", {}, "string", "password"),
("IntInput", {"value": 3}, "integer", None),
("FloatInput", {"value": 1.5}, "number", None),
("BoolInput", {"value": True}, "boolean", None),
(
"DropdownInput",
{"options": ["Music", "Youth"], "value": "Youth"},
"string",
None,
),
(
"MultiselectInput",
{"options": ["Worship", "Courses"], "value": ["Worship"]},
"array",
None,
),
(
"SliderInput",
{"value": 3, "range_spec": {"min": 1, "max": 5, "step": 1}},
"number",
"range",
),
("FileInput", {}, "string", None),
("FutureFancyInput", {}, "string", None),
],
)
def test_type_mapping_table(itype, kwargs, json_type, widget):
doc = _doc(_field("a", itype, **kwargs))
schema = parser.extract_form_schema(doc)
assert "fallback" not in schema
prop = schema["json_schema"]["properties"]["a"]
assert prop["type"] == json_type
ui = schema["ui_schema"].get("a", {})
if widget is None:
assert "ui:widget" not in ui
else:
assert ui["ui:widget"] == widget
def test_type_mapping_details():
doc = _doc( doc = _doc(
_field("a", "StrInput", value="x"), _field("a", "StrInput", value="x"),
_field("b", "MessageTextInput"),
_field("c", "MultilineInput"),
_field("d", "SecretStrInput"),
_field("e", "IntInput", value=3), _field("e", "IntInput", value=3),
_field("f", "FloatInput", value=1.5),
_field("g", "BoolInput", value=True), _field("g", "BoolInput", value=True),
_field( _field(
"h", "h",
@ -65,16 +116,11 @@ def test_type_mapping_table():
value=3, value=3,
range_spec={"min": 1, "max": 5, "step": 1}, range_spec={"min": 1, "max": 5, "step": 1},
), ),
_field("k", "FileInput"),
_field("l", "FutureFancyInput"),
) )
schema = parser.extract_form_schema(doc) schema = parser.extract_form_schema(doc)
assert "fallback" not in schema
props = schema["json_schema"]["properties"] props = schema["json_schema"]["properties"]
assert props["a"] == {"title": "A", "type": "string", "default": "x"} assert props["a"] == {"title": "A", "type": "string", "default": "x"}
assert props["b"]["type"] == "string"
assert props["e"] == {"title": "E", "type": "integer", "default": 3} assert props["e"] == {"title": "E", "type": "integer", "default": 3}
assert props["f"]["type"] == "number"
assert props["g"] == {"title": "G", "type": "boolean", "default": True} assert props["g"] == {"title": "G", "type": "boolean", "default": True}
assert props["h"] == { assert props["h"] == {
"title": "H", "title": "H",
@ -88,12 +134,6 @@ def test_type_mapping_table():
assert props["j"]["minimum"] == 1 assert props["j"]["minimum"] == 1
assert props["j"]["maximum"] == 5 assert props["j"]["maximum"] == 5
assert props["j"]["multipleOf"] == 1 assert props["j"]["multipleOf"] == 1
assert props["k"]["type"] == "string"
assert props["l"]["type"] == "string"
ui = schema["ui_schema"]
assert ui["c"] == {"ui:widget": "textarea"}
assert ui["d"] == {"ui:widget": "password"}
assert ui["j"] == {"ui:widget": "range"}
def test_dropdown_default_outside_enum_omitted(): def test_dropdown_default_outside_enum_omitted():
@ -112,7 +152,9 @@ def test_required_advanced_hidden_code():
schema = parser.extract_form_schema(doc) schema = parser.extract_form_schema(doc)
assert schema["json_schema"]["required"] == ["a"] assert schema["json_schema"]["required"] == ["a"]
assert set(schema["json_schema"]["properties"]) == {"a", "b"} assert set(schema["json_schema"]["properties"]) == {"a", "b"}
assert schema["ui_schema"]["ui:order"] == ["a", "b", "*"] order = schema["ui_schema"]["ui:order"]
assert order[-1] == "*"
assert set(order[:-1]) == {"a", "b"}
def test_display_name_match_and_fallback(): def test_display_name_match_and_fallback():
@ -151,13 +193,9 @@ def test_real_intake_fixture_parses():
assert schema["ui_schema"]["notes"] == {"ui:widget": "textarea"} assert schema["ui_schema"]["notes"] == {"ui:widget": "textarea"}
def _lfx() -> LfxClient: async def test_sync_caches_schema_per_version(session, lfx_server, lfx_client, tmp_path):
return LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None)
async def test_sync_caches_schema_per_version(session, lfx_server, tmp_path):
(tmp_path / "intake_form.json").write_text((FIXTURES / "intake_form.json").read_text()) (tmp_path / "intake_form.json").write_text((FIXTURES / "intake_form.json").read_text())
report = await sync.sync_from_directory(session, _lfx(), tmp_path) report = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert not report.errors, report.errors assert not report.errors, report.errors
from app.flows import store from app.flows import store
@ -192,3 +230,211 @@ async def test_input_schema_endpoint(client, lfx_server, login):
assert body["fallback"] is None assert body["fallback"] is None
assert set(body["json_schema"]["properties"]) >= {"full_name", "topics"} assert set(body["json_schema"]["properties"]) >= {"full_name", "topics"}
assert body["ui_schema"]["password"] == {"ui:widget": "password"} assert body["ui_schema"]["password"] == {"ui:widget": "password"}
def test_free_rename_keys_kept_verbatim():
doc = _doc(
_field("name", "StrInput", display_name="Name", required=True),
_field("favorite room", "StrInput"),
)
schema = parser.extract_form_schema(doc)
assert set(schema["json_schema"]["properties"]) == {"name", "favorite room"}
assert schema["json_schema"]["required"] == ["name"]
def test_empty_name_skipped_and_collision_suffixed():
a = _field("a", "StrInput")
clash = _field("other_key", "StrInput")
clash["name"] = "a" # Langflow rename collision: second field gets a suffix
empty = _field("zzz", "StrInput")
empty["name"] = " "
node = {
"data": {
"type": "CustomInputForm",
"node": {
"display_name": "CustomInput Form",
"template": {"a": a, "other_key": clash, "zzz": empty},
},
}
}
doc = {"data": {"nodes": [node], "edges": []}}
props = parser.extract_form_schema(doc)["json_schema"]["properties"]
assert set(props) == {"a", "a_2"}
def test_visible_if_single_branch():
doc = _doc(
_dropdown("gebaeude", ["Kirche", "Halle"], required=True),
_field(
"bestandteil",
"MultiselectInput",
options=["Glocke", "Orgel"],
info="Bitte wählen [visible_if gebaeude=Kirche]",
required=True,
),
)
out = parser.extract_form_schema(doc)
schema = out["json_schema"]
# Conditional field lives only in its branch, not at root.
assert set(schema["properties"]) == {"gebaeude"}
assert schema["required"] == ["gebaeude"]
assert len(schema["allOf"]) == 1
rule = schema["allOf"][0]
assert rule["if"] == {
"properties": {"gebaeude": {"const": "Kirche"}},
"required": ["gebaeude"],
}
assert rule["then"]["properties"]["bestandteil"]["type"] == "array"
assert rule["then"]["required"] == ["bestandteil"]
# Marker stripped from the shown description.
assert schema["properties"]["gebaeude"]["title"] == "Gebaeude"
order = out["ui_schema"]["ui:order"]
assert order[-1] == "*"
assert set(order[:-1]) == {"gebaeude", "bestandteil"}
def test_visible_if_nested_three_levels():
doc = _doc(
_dropdown("a", ["x", "y"]),
_dropdown("b", ["p", "q"], info="[visible_if a=x]"),
_field("c", "IntInput", info="[visible_if b=p]"),
_field("d", "StrInput", info="[visible_if c=3]"),
)
schema = _branch_schema(doc)
assert set(schema["properties"]) == {"a"}
assert len(schema["allOf"]) == 3
by_field = {next(iter(rule["then"]["properties"])): rule for rule in schema["allOf"]}
assert by_field["b"]["if"] == {
"properties": {"a": {"const": "x"}},
"required": ["a"],
}
assert by_field["c"]["if"]["properties"] == {"b": {"const": "p"}}
assert by_field["d"]["if"]["properties"] == {"c": {"const": 3}}
def test_visible_if_and_quoted_bool_multiselect():
doc = _doc(
_dropdown("a", ["x", "y"]),
_field("flag", "BoolInput"),
_field(
"m",
"MultiselectInput",
options=["Glocke", "Orgel"],
info='[visible_if a="x" & flag=true]',
),
)
schema = _branch_schema(doc)
rule = schema["allOf"][0]
assert rule["if"] == {
"properties": {"a": {"const": "x"}, "flag": {"const": True}},
"required": ["a", "flag"],
}
assert rule["then"]["properties"]["m"]["type"] == "array"
def test_visible_if_multiselect_trigger_uses_contains():
doc = _doc(
_field("tags", "MultiselectInput", options=["Glocke", "Orgel"]),
_field("detail", "StrInput", info="[visible_if tags=Glocke]"),
)
schema = _branch_schema(doc)
assert schema["allOf"][0]["if"]["properties"] == {"tags": {"contains": {"const": "Glocke"}}}
def test_visible_if_dangling_unsupported_cycle_fail_open():
doc = _doc(
_dropdown("a", ["x", "y"]),
_field("ok", "StrInput", info="[visible_if a=x]"),
_field("dangling", "StrInput", info="[visible_if nope=x]"),
_field("slider_dep", "StrInput", info="[visible_if slid=x]"),
_field(
"slid",
"SliderInput",
value=3,
range_spec={"min": 1, "max": 5, "step": 1},
),
_field("c1", "StrInput", info="[visible_if c2=x]"),
_field("c2", "StrInput", info="[visible_if c1=x]"),
_field("selfish", "StrInput", info="[visible_if selfish=x]"),
)
schema = parser.extract_form_schema(doc)["json_schema"]
# Only the valid marker produces a branch; the rest stay at root.
assert len(schema["allOf"]) == 1
assert set(schema["properties"]) >= {
"a",
"dangling",
"slider_dep",
"slid",
"c1",
"c2",
"selfish",
}
assert "ok" not in schema["properties"]
def test_no_markers_no_allof():
doc = _doc(_dropdown("a", ["x", "y"]))
schema = parser.extract_form_schema(doc)["json_schema"]
assert "allOf" not in schema
assert set(schema["properties"]) == {"a"}
def test_custom_component_form_display_match():
"""User-built * Form components parse without a kirche base class."""
doc = _doc(
_field("mitarbeiter_name", "StrInput", info="Vor- und Nachname"),
_dropdown("rolle", ["Assistenz", "Pfarrer:in"]),
node_type="CustomComponent",
display="Mitarbeiter Einstellen Form",
)
schema = parser.extract_form_schema(doc)
assert "fallback" not in schema
props = schema["json_schema"]["properties"]
assert set(props) == {"mitarbeiter_name", "rolle"}
assert props["rolle"]["enum"] == ["Assistenz", "Pfarrer:in"]
assert props["mitarbeiter_name"]["description"] == "Vor- und Nachname"
def test_custom_component_non_form_falls_back():
doc = _doc(
_field("payload", "StrInput"),
node_type="CustomComponent",
display="Rule Check",
)
assert parser.extract_form_schema(doc)["fallback"] == "textarea"
def test_real_mitarbeiter_file_parses():
path = Path(__file__).parent.parent / "flows" / "mitarbeiter_einstellen.json"
doc = json.loads(path.read_text(encoding="utf-8"))
schema = parser.extract_form_schema(doc)
assert "fallback" not in schema
props = schema["json_schema"]["properties"]
assert set(props) == {"rolle", "mitarbeiter_name", "geburtsdatum"}
assert schema["json_schema"]["required"] == ["rolle", "mitarbeiter_name"]
# Einstufung is branched (visible only for Pfarrer:in).
assert len(schema["json_schema"]["allOf"]) == 1
rule = schema["json_schema"]["allOf"][0]
assert rule["if"]["properties"] == {"rolle": {"const": "Pfarrer:in"}}
assert set(rule["then"]["properties"]) == {"einstufung"}
def test_schema_field_names_covers_branches():
doc = _doc(
_dropdown("a", ["x", "y"]),
_dropdown("b", ["p", "q"], info="[visible_if a=x]"),
_field("c", "IntInput", info="[visible_if b=p]"),
)
cached = parser.extract_form_schema(doc)
assert parser.schema_field_names(cached) == ["a", "b", "c"]
plain = parser.extract_form_schema(
{
"data": {
"nodes": [{"data": {"type": "ChatInput", "node": {"template": {}}}}],
"edges": [],
}
}
)
assert parser.schema_field_names(plain) == []
assert parser.schema_field_names({}) == []
assert parser.schema_field_names({"json_schema": None}) == []

View file

@ -9,11 +9,13 @@ import subprocess
import sys import sys
from pathlib import Path from pathlib import Path
from app.flows import export
FLOW_DIR = Path(__file__).resolve().parent.parent / "flows" FLOW_DIR = Path(__file__).resolve().parent.parent / "flows"
def test_canonical_flows_pass_lfx_validate(): def test_canonical_flows_pass_lfx_validate():
files = sorted(FLOW_DIR.glob("*.json")) files = export.iter_flow_files(FLOW_DIR)
assert files, "no canonical flows found" assert files, "no canonical flows found"
process = subprocess.run( process = subprocess.run(
[ [

View file

@ -38,7 +38,8 @@ async def test_oversize_body_rejected(client):
async def test_run_throttle_returns_429(client, lfx_server, login, monkeypatch): async def test_run_throttle_returns_429(client, lfx_server, login, monkeypatch):
from app.settings import settings from app.settings import settings
monkeypatch.setattr(settings, "run_throttle_per_minute", 2) limit = 2
monkeypatch.setattr(settings, "run_throttle_per_minute", limit)
await login() await login()
flow = (await client.post("/api/flows", json={"name": "throttled"})).json() flow = (await client.post("/api/flows", json={"name": "throttled"})).json()
@ -65,7 +66,7 @@ async def test_run_throttle_returns_429(client, lfx_server, login, monkeypatch):
}, },
) )
# Undeployed: 422s still pass the throttle (only 429 matters here). # Undeployed: 422s still pass the throttle (only 429 matters here).
for _ in range(2): for _ in range(limit):
response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {}}) response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {}})
assert response.status_code == 422 assert response.status_code == 422
response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {}}) response = await client.post(f"/api/flows/{flow['id']}/run", json={"input": {}})

View file

@ -1,5 +1,7 @@
"""Model-level tests: defaults, constraints, JSON roundtrip, linkage.""" """Model-level tests: defaults, constraints, JSON roundtrip, linkage."""
import uuid
import pytest import pytest
from sqlalchemy.exc import IntegrityError from sqlalchemy.exc import IntegrityError
from sqlmodel import select from sqlmodel import select
@ -8,6 +10,9 @@ from app.models import ApprovalTask, FlowDefinition, FlowRun, FlowVersion
def test_flow_definition_defaults(session): def test_flow_definition_defaults(session):
from datetime import UTC, datetime
before = datetime.now(UTC).replace(tzinfo=None)
d = FlowDefinition(name="bauvorhaben") d = FlowDefinition(name="bauvorhaben")
session.add(d) session.add(d)
session.commit() session.commit()
@ -18,7 +23,8 @@ def test_flow_definition_defaults(session):
assert d.created_at is not None assert d.created_at is not None
# Timestamps are written as UTC. SQLite does not round-trip tzinfo, so # Timestamps are written as UTC. SQLite does not round-trip tzinfo, so
# after a refresh the value is calendar-time UTC without tzinfo. # after a refresh the value is calendar-time UTC without tzinfo.
assert d.created_at.year >= 2026 assert d.created_at.tzinfo is None
assert abs((d.created_at - before).total_seconds()) < 60
def test_flow_definition_name_unique(session): def test_flow_definition_name_unique(session):
@ -82,3 +88,48 @@ def test_run_and_task_linkage_with_tenant_default(session):
tasks = session.exec(select(ApprovalTask).where(ApprovalTask.run_id == run.id)).all() tasks = session.exec(select(ApprovalTask).where(ApprovalTask.run_id == run.id)).all()
assert len(tasks) == 1 assert len(tasks) == 1
assert tasks[0].payload == {} assert tasks[0].payload == {}
def test_create_version_populates_input_schema(session):
from app.flows import store
from app.flows.schemas import FlowVersionCreate
d = FlowDefinition(name="cached")
session.add(d)
session.commit()
doc = {
"name": "cached",
"data": {
"nodes": [
{
"id": "n1",
"data": {
"type": "ChatInput",
"node": {"display_name": "Chat", "template": {}},
},
}
],
"edges": [],
},
}
version = store.create_version(session, d.id, FlowVersionCreate(langflow_json=doc))
assert version.input_schema["fallback"] == "textarea"
def test_input_schema_null_rejected(session):
from sqlalchemy import text
from sqlalchemy.exc import IntegrityError
d = FlowDefinition(name="nonnull")
session.add(d)
session.commit()
with pytest.raises(IntegrityError):
session.execute(
text(
"INSERT INTO flow_versions (id, flow_id, version_no, langflow_json,"
" author, input_schema) VALUES (:id, :flow_id, 1, :doc, :author, NULL)"
),
{"id": str(uuid.uuid4()), "flow_id": str(d.id), "doc": "{}", "author": "t"},
)
session.commit()
session.rollback()

View file

@ -9,30 +9,22 @@ from pathlib import Path
import pytest import pytest
from app.flows import store, sync from app.flows import store, sync
from app.flows.lfx_client import LfxClient, LfxNotFound from app.flows.lfx_client import LfxNotFound
from app.flows.schemas import SyncReport from app.flows.schemas import SyncReport
from app.flows.sync import lfx_id_for from app.flows.sync import lfx_id_for
from app.settings import settings from app.settings import settings
FIXTURES = Path(__file__).parent / "fixtures" / "flows" from .conftest import FIXTURES_DIR, langflow_export_doc, load_flow_fixture
def load_fixture(name: str) -> dict:
return json.loads((FIXTURES / name).read_text())
def _lfx() -> LfxClient:
return LfxClient(settings.lfx_url, api_key=settings.lfx_api_key or None)
def _seed_dir(tmp_path: Path, name: str = "simple_rule.json") -> Path: def _seed_dir(tmp_path: Path, name: str = "simple_rule.json") -> Path:
shutil.copy(FIXTURES / name, tmp_path / name) shutil.copy(FIXTURES_DIR / name, tmp_path / name)
return tmp_path return tmp_path
async def test_sync_adds_new_flow(session, lfx_server, tmp_path): async def test_sync_adds_new_flow(session, lfx_server, lfx_client, tmp_path):
_seed_dir(tmp_path) _seed_dir(tmp_path)
report = await sync.sync_from_directory(session, _lfx(), tmp_path) report = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert report.added == ["simple_rule"] assert report.added == ["simple_rule"]
assert report.errors == {} assert report.errors == {}
definition = store.get_definition_by_source_path(session, "simple_rule.json") definition = store.get_definition_by_source_path(session, "simple_rule.json")
@ -44,75 +36,83 @@ async def test_sync_adds_new_flow(session, lfx_server, tmp_path):
assert versions[0].deployed_at is not None assert versions[0].deployed_at is not None
async def test_sync_skips_unchanged(session, lfx_server, tmp_path): async def test_sync_skips_ignored_files(session, lfx_server, lfx_client, tmp_path):
_seed_dir(tmp_path) _seed_dir(tmp_path)
first = await sync.sync_from_directory(session, _lfx(), tmp_path) (tmp_path / ".flowsignore").write_text("simple_rule\n", encoding="utf-8")
report = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert report.added == [] and report.errors == {}
assert store.get_definition_by_source_path(session, "simple_rule.json") is None
async def test_sync_skips_unchanged(session, lfx_server, lfx_client, tmp_path):
_seed_dir(tmp_path)
first = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert first.added == ["simple_rule"] assert first.added == ["simple_rule"]
second = await sync.sync_from_directory(session, _lfx(), tmp_path) second = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert second.skipped == ["simple_rule"] assert second.skipped == ["simple_rule"]
assert second.added == second.updated == [] assert second.added == second.updated == []
definition = store.get_definition_by_source_path(session, "simple_rule.json") definition = store.get_definition_by_source_path(session, "simple_rule.json")
assert len(store.list_versions(session, definition.id)) == 1 assert len(store.list_versions(session, definition.id)) == 1
async def test_sync_updates_on_change_and_replaces_lfx(session, lfx_server, tmp_path): async def test_sync_updates_on_change_and_replaces_lfx(session, lfx_server, lfx_client, tmp_path):
_seed_dir(tmp_path) _seed_dir(tmp_path)
await sync.sync_from_directory(session, _lfx(), tmp_path) await sync.sync_from_directory(session, lfx_client, tmp_path)
definition = store.get_definition_by_source_path(session, "simple_rule.json") definition = store.get_definition_by_source_path(session, "simple_rule.json")
old_lfx_id = lfx_id_for(definition.id, 1) old_lfx_id = lfx_id_for(definition.id, 1)
doc = load_fixture("simple_rule.json") doc = load_flow_fixture("simple_rule.json")
doc["description"] = "geaendert" doc["description"] = "geaendert"
(tmp_path / "simple_rule.json").write_text(json.dumps(doc)) (tmp_path / "simple_rule.json").write_text(json.dumps(doc))
report = await sync.sync_from_directory(session, _lfx(), tmp_path) report = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert report.updated == ["simple_rule"] assert report.updated == ["simple_rule"]
versions = store.list_versions(session, definition.id) versions = store.list_versions(session, definition.id)
assert [v.version_no for v in versions] == [1, 2] assert [v.version_no for v in versions] == [1, 2]
assert versions[1].lfx_flow_id == lfx_id_for(definition.id, 2) assert versions[1].lfx_flow_id == lfx_id_for(definition.id, 2)
# Superseded LFX registration is gone. # Superseded LFX registration is gone.
with pytest.raises(LfxNotFound): with pytest.raises(LfxNotFound):
await _lfx().flow_info(old_lfx_id) await lfx_client.flow_info(old_lfx_id)
async def test_sync_deletes_missing_file_with_cascade(session, lfx_server, tmp_path): async def test_sync_deletes_missing_file_with_cascade(session, lfx_server, lfx_client, tmp_path):
_seed_dir(tmp_path) _seed_dir(tmp_path)
await sync.sync_from_directory(session, _lfx(), tmp_path) await sync.sync_from_directory(session, lfx_client, tmp_path)
definition = store.get_definition_by_source_path(session, "simple_rule.json") definition = store.get_definition_by_source_path(session, "simple_rule.json")
version = store.list_versions(session, definition.id)[0] version = store.list_versions(session, definition.id)[0]
run = store.create_run(session, version, input={"a": 1}, tenant_id="default") run = store.create_run(session, version, input={"a": 1}, tenant_id="default")
lfx_id = lfx_id_for(definition.id, 1) lfx_id = lfx_id_for(definition.id, 1)
(tmp_path / "simple_rule.json").unlink() (tmp_path / "simple_rule.json").unlink()
report = await sync.sync_from_directory(session, _lfx(), tmp_path) report = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert report.deleted == ["simple_rule"] assert report.deleted == ["simple_rule"]
assert store.get_definition_by_source_path(session, "simple_rule.json") is None assert store.get_definition_by_source_path(session, "simple_rule.json") is None
with pytest.raises(store.NotFoundError): with pytest.raises(store.NotFoundError):
store.get_run(session, run.id) store.get_run(session, run.id)
with pytest.raises(LfxNotFound): with pytest.raises(LfxNotFound):
await _lfx().flow_info(lfx_id) await lfx_client.flow_info(lfx_id)
async def test_sync_reports_invalid_json(session, lfx_server, tmp_path): async def test_sync_reports_invalid_json(session, lfx_server, lfx_client, tmp_path):
(tmp_path / "kaputt.json").write_text("{kein json") (tmp_path / "kaputt.json").write_text("{kein json")
report = await sync.sync_from_directory(session, _lfx(), tmp_path) report = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert "kaputt.json" in report.errors assert "kaputt.json" in report.errors
assert report.added == [] assert report.added == []
assert store.list_definitions(session) == [] assert store.list_definitions(session) == []
async def test_sync_missing_dir_raises(session, lfx_server, tmp_path): async def test_sync_missing_dir_raises(session, lfx_server, lfx_client, tmp_path):
with pytest.raises(FileNotFoundError): with pytest.raises(FileNotFoundError):
await sync.sync_from_directory(session, _lfx(), tmp_path / "gibts-nicht") await sync.sync_from_directory(session, lfx_client, tmp_path / "gibts-nicht")
async def test_sync_rename_updates_definition_name(session, lfx_server, tmp_path): async def test_sync_rename_updates_definition_name(session, lfx_server, lfx_client, tmp_path):
_seed_dir(tmp_path) _seed_dir(tmp_path)
await sync.sync_from_directory(session, _lfx(), tmp_path) await sync.sync_from_directory(session, lfx_client, tmp_path)
doc = load_fixture("simple_rule.json") doc = load_flow_fixture("simple_rule.json")
doc["name"] = "umbenannt" doc["name"] = "umbenannt"
(tmp_path / "simple_rule.json").write_text(json.dumps(doc)) (tmp_path / "simple_rule.json").write_text(json.dumps(doc))
report = await sync.sync_from_directory(session, _lfx(), tmp_path) report = await sync.sync_from_directory(session, lfx_client, tmp_path)
assert report.updated == ["simple_rule"] assert report.updated == ["simple_rule"]
definition = store.get_definition_by_source_path(session, "simple_rule.json") definition = store.get_definition_by_source_path(session, "simple_rule.json")
assert definition.name == "umbenannt" assert definition.name == "umbenannt"
@ -136,107 +136,100 @@ async def test_sync_endpoint_returns_report(
assert response.json()["skipped"] == ["simple_rule"] assert response.json()["skipped"] == ["simple_rule"]
def _langflow_doc(name: str, langflow_id: str) -> dict: @pytest.mark.parametrize(
doc = load_fixture("simple_rule.json") ("seed", "flow_name", "flow_id", "extra_flows", "extra_docs", "expected_file"),
return { [
"id": langflow_id, (
"name": name, None,
"description": "aus Langflow", "Gehaltserhöhung",
"endpoint_name": None, "22222222-3333-4444-8555-666666666666",
"data": doc["data"], [],
"tags": [], {},
"webhook": False, "Gehaltserhöhung.json",
"is_component": False, ),
} (
# Seeded from simple_rule.json: updates in place instead of
# duplicating as simple-rule.json (slug drift).
async def test_sync_endpoint_pulls_from_langflow_then_syncs( "simple_rule.json",
client, lfx_server, tmp_path, monkeypatch, login, override_langflow "simple_rule",
"44444444-5555-4666-8777-888888888888",
[],
{},
"simple_rule.json",
),
(
None,
"Gut",
"33333333-4444-4555-8666-777777777777",
[{"id": "kaputt-id", "name": "Kaputt"}],
{},
"Gut.json",
),
],
ids=["pull-new", "pull-reuse", "pull-error-continues"],
)
async def test_sync_endpoint_pull_matrix(
client,
lfx_server,
tmp_path,
monkeypatch,
login,
override_langflow,
seed,
flow_name,
flow_id,
extra_flows,
extra_docs,
expected_file,
): ):
await login() await login()
monkeypatch.setattr(settings, "flows_dir", str(tmp_path)) monkeypatch.setattr(settings, "flows_dir", str(tmp_path))
langflow_id = "22222222-3333-4444-8555-666666666666" if seed is not None:
_seed_dir(tmp_path, seed)
override_langflow( override_langflow(
flows=[{"id": langflow_id, "name": "Gehaltserhöhung"}], flows=[{"id": flow_id, "name": flow_name}, *extra_flows],
docs={langflow_id: _langflow_doc("Gehaltserhöhung", langflow_id)}, docs={flow_id: langflow_export_doc(flow_name, flow_id), **extra_docs},
) )
response = await client.post("/api/flows/sync") response = await client.post("/api/flows/sync")
assert response.status_code == 200, response.text assert response.status_code == 200, response.text
body = response.json() body = response.json()
assert body["pulled"] == ["Gehaltserhöhung"] assert body["pulled"] == [flow_name]
assert body["added"] == ["Gehaltserhöhung"] assert body["added"] == [flow_name]
assert body["errors"] == {} assert (tmp_path / expected_file).is_file()
assert (tmp_path / "Gehaltserhöhung.json").is_file() if flow_name == "Gut":
assert "kaputt-id" in body["errors"]
else:
assert body["errors"] == {}
assert not (tmp_path / "simple-rule.json").exists()
# Second pass: same content pulls again but syncs nothing new. # Second pass: same content pulls again but syncs nothing new.
response = await client.post("/api/flows/sync") response = await client.post("/api/flows/sync")
assert response.status_code == 200, response.text assert response.status_code == 200, response.text
body = response.json() body = response.json()
assert body["pulled"] == ["Gehaltserhöhung"] assert body["pulled"] == [flow_name]
assert body["skipped"] == ["Gehaltserhöhung"] assert body["skipped"] == [flow_name]
async def test_sync_endpoint_pull_reuses_same_named_file( @pytest.mark.parametrize(
client, lfx_server, tmp_path, monkeypatch, login, override_langflow ("list_status", "expected_status"),
[(0, 503), (500, 502)],
)
async def test_sync_endpoint_langflow_failures(
client,
lfx_server,
tmp_path,
monkeypatch,
login,
override_langflow,
list_status,
expected_status,
): ):
"""A pulled flow seeded from simple_rule.json updates it in place """Listing failures map to 503/502 (parametrized)."""
instead of duplicating it as simple-rule.json (slug drift)."""
await login() await login()
monkeypatch.setattr(settings, "flows_dir", str(tmp_path)) monkeypatch.setattr(settings, "flows_dir", str(tmp_path))
_seed_dir(tmp_path) # fixture shape, name "simple_rule" override_langflow(flows=[], list_status=list_status)
langflow_id = "44444444-5555-4666-8777-888888888888"
override_langflow(
flows=[{"id": langflow_id, "name": "simple_rule"}],
docs={langflow_id: _langflow_doc("simple_rule", langflow_id)},
)
response = await client.post("/api/flows/sync") response = await client.post("/api/flows/sync")
assert response.status_code == 200, response.text assert response.status_code == expected_status
body = response.json()
assert body["pulled"] == ["simple_rule"]
assert body["added"] == ["simple_rule"]
assert body["errors"] == {}
assert not (tmp_path / "simple-rule.json").exists()
response = await client.post("/api/flows/sync")
assert response.json()["skipped"] == ["simple_rule"]
async def test_sync_endpoint_pull_error_continues(
client, lfx_server, tmp_path, monkeypatch, login, override_langflow
):
await login()
monkeypatch.setattr(settings, "flows_dir", str(tmp_path))
good_id = "33333333-4444-4555-8666-777777777777"
override_langflow(
flows=[{"id": good_id, "name": "Gut"}, {"id": "kaputt-id", "name": "Kaputt"}],
docs={good_id: _langflow_doc("Gut", good_id)},
)
response = await client.post("/api/flows/sync")
assert response.status_code == 200, response.text
body = response.json()
assert body["pulled"] == ["Gut"]
assert body["added"] == ["Gut"]
assert "kaputt-id" in body["errors"]
async def test_sync_endpoint_langflow_unreachable(
client, lfx_server, tmp_path, monkeypatch, login, override_langflow
):
await login()
monkeypatch.setattr(settings, "flows_dir", str(tmp_path))
override_langflow(flows=[], list_status=0)
response = await client.post("/api/flows/sync")
assert response.status_code == 503
async def test_sync_endpoint_langflow_error(
client, lfx_server, tmp_path, monkeypatch, login, override_langflow
):
await login()
monkeypatch.setattr(settings, "flows_dir", str(tmp_path))
override_langflow(flows=[], list_status=500)
response = await client.post("/api/flows/sync")
assert response.status_code == 502
async def test_watch_forever_triggers_on_file_change(tmp_path): async def test_watch_forever_triggers_on_file_change(tmp_path):

33
docs/flow-authoring.md Normal file
View file

@ -0,0 +1,33 @@
# Flow authoring (Langflow → Webapp)
So kommt ein neuer Flow in die Webapp:
1. **In Langflow entwerfen und speichern** (bestehende Flows sind dort
bereits geladen). Name vergeben, speichern.
2. **Sync-Button in der Verwaltung klicken** ("Aus Langflow
synchronisieren"): holt alle Flows aus Langflow nach
`backend/flows/*.json` und deployed sie danach automatisch (neue
Version nur bei geändertem Inhalt, sonst übersprungen).
3. **Prüfen:** Die Versions-Tabelle zeigt Version, Autor und Status.
Danach erscheint der Flow automatisch auf der Seite Workflows mit
seinem Formular. Flows ohne Formular-Knoten zeigen ein Freitext-Feld.
## Regeln
- Die Datei heißt wie der Flow in Langflow (z. B. `intake_form.json`).
Umbenennen in Langflow erzeugt eine neue Datei; die alte bleibt
bestehen und muss bei Bedarf gelöscht werden.
- Eine gelöschte Datei löscht den Flow inklusive seiner Läufe
(Datei bleibt in Git erhalten).
- Fehler stehen in der Sync-Meldung (z. B. ungültiges Flow-JSON).
Der automatische Beobachter im Hintergrund syncet nur Dateien,
Langflow holt nur dieser Button.
## Formular-Felder
Für ein Web-Formular braucht der Flow einen CustomInputForm-Knoten:
jeder Eintrag dort ist ein Formularfeld (Name = Feld-Key, Anzeigename
= Label). Die Verbindung ChatInput nach `form_values` bitte behalten —
darüber kommen die ausgefüllten Werte an. Unbekannte Feldtypen fallen
automatisch auf ein Textfeld zurück. Details:
`backend/components/kirche/README.md`.

101
docs/new_workflow_module.md Normal file
View file

@ -0,0 +1,101 @@
# New workflow module: form flow end to end
How to add a form-based workflow (web form → run → result), learned from
building intake, Bauvorhaben, and Mitarbeiter-Einstellen. Three layers:
component (Langflow palette), flow (canvas), backend parsing (automatic).
## 1. Form component (`backend/components/kirche/<name>_form.py`)
Copy `mitarbeiter_form.py` (small) or `bauvorhaben_form.py` (branching).
Rename the class with a **`CustomInput*` prefix** (e.g.
`CustomInputMitarbeiter`) — the backend parser matches that prefix; a
plain `CustomComponent` name additionally needs a display name ending
in `"Form"`.
Rules, all load-bearing:
- **Self-contained**: stdlib + `lfx` only. NEVER import from sibling
form modules — LFX executes the embedded module source without our
package, and Langflow round-trips the code. Duplicated helpers are
structural, not laziness.
- **Inputs**: one `lfx.io` entry per question (`name` = stable JSON key,
`display_name` = label, `info` = help, `options`/`value`/`required`
as needed) plus the hidden `form_values` plumbing input (reserved
name — never use it for a field).
- **Branching**: `[visible_if feld=Wert]` markers in `info`
(`&` for AND, quotes for spaces). Any depth; trigger types:
Dropdown/Text `const`, Bool, Multiselect `contains`, Int/Float exact.
Stale markers, cycles, and unknown triggers fail open (always visible).
- **Required sentinels**: required fields with empty values carry
`" "` (`[" "]` for Multiselect — a plain string crashes LFX at build,
`[]` fails validation). The parser treats them as "no default".
- **Outputs**: exactly `Output(name="form_data", method="collect")`
returning `Data`. Do not touch `collect()` — it is fully dynamic
(asked + visible defaults, submitted values win).
- Export in `backend/components/kirche/__init__.py`.
Then: `docker compose restart langflow` (components load at startup),
check the palette via `GET /api/v1/all` (or sidebar search, hard-refresh
the browser tab if the entry is missing — the API is source of truth).
## 2. Flow JSON (`backend/flows/<name>.json`)
Never hand-edit: add `build_<name>()` in
`backend/scripts/make_flow_fixtures.py` and run it (from `backend/`).
- Form node via `kirche_node(node_id, component_cls=..., code_override=...)`.
- Logic nodes via `custom_node(CODE, ...)` (keep return annotations like
`-> Message`: edge handles derive output types from them).
- Always wire `ChatInput → form_values` (run envelope), then
`form_data → … → ChatOutput`.
- Reorder template keys to question order (lfx emits alphabetical; RJSF
renders insertion order, and `ui:order` follows it).
- The script writes fixtures + canonical files; `git checkout` the churn
on unrelated flows, keep canonical files CRLF like the repo.
- Custom logic code (e.g. salary math) lives as a `*_CODE` constant in
the script — one owner for template and code.
## 3. Backend parsing (automatic, know the contract)
`app/flows/input_schema.py` turns the node template into
`{json_schema, ui_schema}` per version: `name` → key (verbatim; empty
skipped, collisions suffixed), `display_name`/`info`/`value`/`options`
→ title/description/default/enum, `show: false` skipped, unknown types
degrade to text. Markers become `allOf`/`if`/`then` branches;
branch-`required` applies only while visible.
Runs carry an envelope (`payload`, `fields` = asked names from the
cached schema, run context). `collect()` emits defaults only for asked
AND visible fields; submitted values always win; hidden values are kept
but never inventoried. Raw dicts and the Langflow playground use all
visible declared defaults.
## 4. Langflow round-trip (where flows go to die, if careless)
- Node **type names must be distinct per component** — Langflow
normalizes same-type nodes to the installed class on import and
silently discards variant templates.
- Upload via `POST /api/v1/flows/upload/`, then fetch the flow back and
assert node type, template fields, and code are intact.
- Restart re-seeds `backend/flows/` into Langflow; the sync button pulls
Langflow → files **matched by flow name, overwriting silently**.
Commit before syncing, review the `pulled` report, never rename or
repurpose flows casually.
- Experiments that must stay out: list their stem in
`backend/flows/.flowsignore` (skipped by sync, deploy, validation,
frontend, and future pulls).
## 5. Verify before reporting done
- `uv run pytest` (full suite incl. real-LFX deploy+run e2e) green.
- `uv run ruff check .` clean, `uv run ruff format --check .` clean.
- `uv run lfx validate --level 4 tests/fixtures/flows/` all pass.
- Live: `GET /api/flows/{id}/input-schema` shows `fallback: null`
with expected properties (cached schemas refresh only on new
versions — unchanged files keep their cached schema).
- Browser click-through in Workflows, including a branched path and an
empty submit (branch-required errors).
New behavior ships with tests; schema changes ship as Alembic revisions
(never edit applied migrations); commit on `feat/<short>`, never
directly on `main`.

File diff suppressed because it is too large Load diff

View file

@ -11,21 +11,29 @@
"icons": "node scripts/icons.mjs" "icons": "node scripts/icons.mjs"
}, },
"dependencies": { "dependencies": {
"@mantine/core": "^9.6.1", "@mantine/core": "^9.6.3",
"@mantine/hooks": "^9.6.1", "@mantine/dates": "^9.6.3",
"@mantine/form": "^9.6.3",
"@mantine/hooks": "^9.6.3",
"@mantine/notifications": "^9.6.3",
"@rjsf/core": "^6.10.0", "@rjsf/core": "^6.10.0",
"@rjsf/mantine": "^6.10.0", "@rjsf/mantine": "^6.10.0",
"@rjsf/utils": "^6.10.0",
"@rjsf/validator-ajv8": "^6.10.0", "@rjsf/validator-ajv8": "^6.10.0",
"@tabler/icons-react": "^3.46.0", "@tabler/icons-react": "^3.46.0",
"@tanstack/react-query": "^5.62.0",
"dayjs": "^1.11.13",
"react": "^19.0.0", "react": "^19.0.0",
"react-dom": "^19.0.0", "react-dom": "^19.0.0",
"react-router-dom": "^7.18.3" "react-router-dom": "^7.18.3",
"zod": "^3.24.0"
}, },
"devDependencies": { "devDependencies": {
"@types/react": "^19.0.0", "@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0", "@types/react-dom": "^19.0.0",
"@vitejs/plugin-react": "^4.3.0", "@vitejs/plugin-react": "^4.3.0",
"playwright": "^1.63.0", "playwright": "^1.63.0",
"sharp": "^0.34.0",
"typescript": "~5.6.0", "typescript": "~5.6.0",
"vite": "^6.0.0" "vite": "^6.0.0"
} }

View file

@ -16,5 +16,4 @@ Dutch-language documents.
| hero-church.webp | Stone church tower, blue sky | https://www.pexels.com/photo/historic-church-with-bell-tower-in-germany-31630127/ | | hero-church.webp | Stone church tower, blue sky | https://www.pexels.com/photo/historic-church-with-bell-tower-in-germany-31630127/ |
| church-pews.webp | Bright empty pews, checkerboard| https://www.pexels.com/photo/church-pews-7566207/ | | church-pews.webp | Bright empty pews, checkerboard| https://www.pexels.com/photo/church-pews-7566207/ |
| paperwork-desk.webp | Desk with stamps and forms | https://www.pexels.com/photo/desk-with-documents-and-stamps-18687845/ | | paperwork-desk.webp | Desk with stamps and forms | https://www.pexels.com/photo/desk-with-documents-and-stamps-18687845/ |
| team-laptop.webp | Team collaborating at laptop | https://www.pexels.com/photo/a-team-looking-at-a-laptop-7793702/ |
| pilot-meeting.webp | Consultation meeting, notes | https://www.pexels.com/photo/two-people-shaking-hands-5668858/ | | pilot-meeting.webp | Consultation meeting, notes | https://www.pexels.com/photo/two-people-shaking-hands-5668858/ |

Binary file not shown.

Before

Width:  |  Height:  |  Size: 115 KiB

View file

@ -50,12 +50,12 @@ try {
const page = await context.newPage(); const page = await context.newPage();
for (const shot of shots) { for (const shot of shots) {
await page.goto(base + shot.path, { waitUntil: "networkidle" }); await page.goto(base + shot.path, { waitUntil: "networkidle" });
await page.waitForTimeout(1500); await page.waitForSelector("main, #root", { timeout: 15000 });
if (shot.selectFlow) { if (shot.selectFlow) {
// Show the generated RJSF form instead of the default first flow. // Show the generated RJSF form instead of the default first flow.
await page.locator('[role="combobox"]').first().click(); await page.locator('[role="combobox"]').first().click();
await page.getByRole("option", { name: shot.selectFlow }).click(); await page.getByRole("option", { name: shot.selectFlow }).click();
await page.waitForTimeout(2000); await page.waitForSelector("form", { timeout: 15000 });
} }
const file = join(outDir, `${shot.name}-${scheme}.png`); const file = join(outDir, `${shot.name}-${scheme}.png`);
await page.screenshot({ path: file, fullPage: shot.fullPage }); await page.screenshot({ path: file, fullPage: shot.fullPage });

View file

@ -1,82 +0,0 @@
"""Fetch landing-page photos (one-time + re-runnable).
Downloads royalty-free originals (see SOURCES.md next to the photos),
resizes to max 1600px wide and stores them as WebP q80 in
frontend/public/photos/ (self-hosted: no hotlinking, no tracking).
Run in the api container (has network + Pillow):
docker compose exec api /opt/venv/bin/python \\
/srv/kirche-einfach/frontend/scripts/fetch-photos.py
"""
from __future__ import annotations
import sys
import urllib.request
from io import BytesIO
from pathlib import Path
try:
from PIL import Image
except ImportError:
sys.exit("Pillow required (present in the api image)")
ROOT = Path(__file__).resolve().parent.parent.parent
OUT = ROOT / "frontend" / "public" / "photos"
def pexels(photo_id: int) -> str:
return (
f"https://images.pexels.com/photos/{photo_id}/"
f"pexels-photo-{photo_id}.jpeg?auto=compress&cs=tinysrgb&w=1600"
)
PHOTOS = {
# target file -> (direct file URL, source page for SOURCES.md)
"hero-church.webp": (
pexels(31630127),
"https://www.pexels.com/photo/historic-church-with-bell-tower-in-germany-31630127/",
),
"church-pews.webp": (
pexels(7566207),
"https://www.pexels.com/photo/church-pews-7566207/",
),
"paperwork-desk.webp": (
pexels(18687845),
"https://www.pexels.com/photo/desk-with-documents-and-stamps-18687845/",
),
"team-laptop.webp": (
pexels(7793702),
"https://www.pexels.com/photo/a-team-looking-at-a-laptop-7793702/",
),
"pilot-meeting.webp": (
pexels(5668858),
"https://www.pexels.com/photo/two-people-shaking-hands-5668858/",
),
}
def fetch(url: str) -> bytes:
req = urllib.request.Request(url, headers={"User-Agent": "kirche-einfach/1.0"})
with urllib.request.urlopen(req, timeout=120) as response:
return response.read()
def main() -> None:
OUT.mkdir(parents=True, exist_ok=True)
for filename, (url, _page) in PHOTOS.items():
raw = fetch(url)
with Image.open(BytesIO(raw)) as img:
img = img.convert("RGB")
if img.width > 1600:
img = img.resize(
(1600, round(img.height * 1600 / img.width)), Image.LANCZOS
)
target = OUT / Path(filename).with_suffix(".webp").name
img.save(target, "WEBP", quality=80, method=6)
print(f"wrote {target} ({target.stat().st_size // 1024} KB)")
if __name__ == "__main__":
main()

View file

@ -1,22 +1,21 @@
/* Generate favicon PNGs + manifest icons from favicon.svg (re-runnable). /* Generate favicon PNGs + manifest icons from favicon.svg (re-runnable).
* *
* Usage (frontend container, Chromium already installed for screenshots): * Usage (frontend container):
* npm run icons * npm run icons
* *
* Renders the SVG at each target size (crisp native rasterization) into * Renders the SVG at each target size with sharp (no browser needed).
* public/. apple-touch-icon keeps the solid kirchenblau background (iOS * apple-touch-icon keeps the solid kirchenblau background (iOS fills
* fills transparency black). The 512 icon doubles as maskable: the glyph * transparency black). The 512 icon doubles as maskable: the glyph stays
* stays inside the inner 80% safe zone. * inside the inner 80% safe zone.
*/ */
import { readFileSync } from "node:fs"; import { readFileSync } from "node:fs";
import { join, dirname } from "node:path"; import { join, dirname } from "node:path";
import { fileURLToPath } from "node:url"; import { fileURLToPath } from "node:url";
import { chromium } from "playwright"; import sharp from "sharp";
const root = join(dirname(fileURLToPath(import.meta.url)), ".."); const root = join(dirname(fileURLToPath(import.meta.url)), "..");
const svg = readFileSync(join(root, "public", "favicon.svg"), "utf-8"); const svg = readFileSync(join(root, "public", "favicon.svg"));
const dataUrl = `data:image/svg+xml,${encodeURIComponent(svg)}`;
const targets = [ const targets = [
["favicon-32x32.png", 32], ["favicon-32x32.png", 32],
@ -25,20 +24,11 @@ const targets = [
["icon-512.png", 512], ["icon-512.png", 512],
]; ];
const browser = await chromium.launch(); for (const [file, size] of targets) {
try { await sharp(svg, { density: 300 })
const page = await browser.newPage(); .resize(size, size, { fit: "contain", background: { r: 0, g: 0, b: 0, alpha: 0 } })
for (const [file, size] of targets) { .flatten({ background: file === "apple-touch-icon.png" ? "#1d4a79" : "#ffffff" })
await page.setViewportSize({ width: size, height: size }); .png()
await page.setContent( .toFile(join(root, "public", file));
`<body style="margin:0"><img src="${dataUrl}" width="${size}" height="${size}"/></body>`, console.log(`wrote public/${file}`);
);
await page.locator("img").screenshot({
path: join(root, "public", file),
omitBackground: true,
});
console.log(`wrote public/${file}`);
}
} finally {
await browser.close();
} }

View file

@ -10,6 +10,8 @@ import {
Text, Text,
Title, Title,
} from "@mantine/core"; } from "@mantine/core";
import { Notifications } from "@mantine/notifications";
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import type { ReactNode } from "react"; import type { ReactNode } from "react";
import { AuthProvider, useAuth } from "./auth"; import { AuthProvider, useAuth } from "./auth";
import SchemeToggle from "./components/SchemeToggle"; import SchemeToggle from "./components/SchemeToggle";
@ -67,15 +69,17 @@ function Nav() {
); );
} }
function Loading() {
return (
<Center mt="xl">
<Loader />
</Center>
);
}
function RequireAuth({ children }: { children: ReactNode }) { function RequireAuth({ children }: { children: ReactNode }) {
const { me, loading } = useAuth(); const { me, loading } = useAuth();
if (loading) { if (loading) return <Loading />;
return (
<Center mt="xl">
<Loader />
</Center>
);
}
// Runs, run history and approvals are login-gated server-side; // Runs, run history and approvals are login-gated server-side;
// anonymous visitors go to the magic-link login. // anonymous visitors go to the magic-link login.
if (!me) return <Navigate to="/login" replace />; if (!me) return <Navigate to="/login" replace />;
@ -111,9 +115,7 @@ function Shell() {
KI-gestützte Verwaltungsplattform für Kirche KI-gestützte Verwaltungsplattform für Kirche
</Text> </Text>
{loading ? ( {loading ? (
<Center mt="xl"> <Loading />
<Loader />
</Center>
) : ( ) : (
<Routes> <Routes>
<Route path="/" element={<StartPage />} /> <Route path="/" element={<StartPage />} />
@ -143,7 +145,7 @@ function Shell() {
</RequireAuth> </RequireAuth>
} }
/> />
<Route path="*" element={<StartPage />} /> <Route path="*" element={<Navigate to="/" replace />} />
</Routes> </Routes>
)} )}
</Container> </Container>
@ -152,10 +154,17 @@ function Shell() {
); );
} }
const queryClient = new QueryClient({
defaultOptions: { queries: { staleTime: 15_000, retry: 1 } },
});
export default function App() { export default function App() {
return ( return (
<AuthProvider> <QueryClientProvider client={queryClient}>
<Shell /> <AuthProvider>
</AuthProvider> <Notifications position="top-right" />
<Shell />
</AuthProvider>
</QueryClientProvider>
); );
} }

View file

@ -1,5 +1,19 @@
/* Typed client for the kirche-einfach API (served via vite /api proxy). */ /* Typed client for the kirche-einfach API (served via vite /api proxy). */
/** All statuses the backend can report (single color language in StatusBadge). */
export type Status =
| "completed"
| "approved"
| "genehmigt"
| "deployed"
| "running"
| "open"
| "pending"
| "pending_approval"
| "failed"
| "rejected"
| "abgelehnt";
export interface FlowDefinition { export interface FlowDefinition {
id: string; id: string;
name: string; name: string;
@ -33,7 +47,7 @@ export interface Run {
id: string; id: string;
version_id: string; version_id: string;
tenant_id: string; tenant_id: string;
status: string; status: Status;
input: unknown; input: unknown;
output: RunOutput | null; output: RunOutput | null;
session_id: string | null; session_id: string | null;
@ -50,7 +64,7 @@ export interface ApprovalTask {
payload: unknown; payload: unknown;
continuation_flow_id: string | null; continuation_flow_id: string | null;
approver: string | null; approver: string | null;
status: string; status: Status;
decision_note: string; decision_note: string;
created_at: string; created_at: string;
decided_at: string | null; decided_at: string | null;
@ -61,6 +75,11 @@ export interface Decision {
continuation_run: Run | null; continuation_run: Run | null;
} }
export interface NamedRun {
flow_name: string;
run: Run;
}
export interface SyncReport { export interface SyncReport {
added: string[]; added: string[];
updated: string[]; updated: string[];
@ -83,7 +102,7 @@ export interface AccessRequest {
name: string; name: string;
email: string; email: string;
reason: string; reason: string;
status: string; status: Status;
created_at: string; created_at: string;
decided_at: string | null; decided_at: string | null;
decided_by: string | null; decided_by: string | null;
@ -153,6 +172,7 @@ export const api = {
getInputSchema: (flowId: string) => getInputSchema: (flowId: string) =>
req<InputSchema>(`/api/flows/${flowId}/input-schema`), req<InputSchema>(`/api/flows/${flowId}/input-schema`),
listRuns: (flowId: string) => req<Run[]>(`/api/flows/${flowId}/runs`), listRuns: (flowId: string) => req<Run[]>(`/api/flows/${flowId}/runs`),
listAllRuns: () => req<NamedRun[]>("/api/runs"),
listApprovals: () => req<ApprovalTask[]>("/api/approvals"), listApprovals: () => req<ApprovalTask[]>("/api/approvals"),
decide: (taskId: string, decision: "approve" | "reject", note: string) => decide: (taskId: string, decision: "approve" | "reject", note: string) =>
req<Decision>(`/api/approvals/${taskId}/decision`, { req<Decision>(`/api/approvals/${taskId}/decision`, {
@ -202,10 +222,10 @@ export const api = {
method: "POST", method: "POST",
body: JSON.stringify({ name, email, reason }), body: JSON.stringify({ name, email, reason }),
}), }),
listAccessRequests: (status?: string) => listAccessRequests: (status?: string) => {
req<AccessRequest[]>( const qs = new URLSearchParams(status ? { status } : {}).toString();
`/api/access/requests${status ? `?status=${status}` : ""}`, return req<AccessRequest[]>(`/api/access/requests${qs ? `?${qs}` : ""}`);
), },
decideAccess: (id: string, approve: boolean) => decideAccess: (id: string, approve: boolean) =>
req<{ request: AccessRequest; email_sent: boolean }>( req<{ request: AccessRequest; email_sent: boolean }>(
`/api/access/requests/${id}/${approve ? "approve" : "reject"}`, `/api/access/requests/${id}/${approve ? "approve" : "reject"}`,

View file

@ -1,52 +1,55 @@
import { useCallback, useEffect, useState } from "react"; import { useEffect, useState } from "react";
import { import {
Alert,
Button,
Card, Card,
Group, Group,
Stack, Stack,
Text, Text,
Title, Title,
} from "@mantine/core"; } from "@mantine/core";
import { import { notifications } from "@mantine/notifications";
IconAlertCircle, import { useQuery, useQueryClient } from "@tanstack/react-query";
IconCheck, import { api, type AccessRequest } from "../api";
} from "@tabler/icons-react"; import { formatApiError } from "../utils";
import { ApiError, api, type AccessRequest } from "../api"; import { DecisionButtons } from "./DecisionButtons";
import { ErrorAlert } from "./ErrorAlert";
import { FormattedDate } from "./FormattedDate";
import StatusBadge from "./StatusBadge"; import StatusBadge from "./StatusBadge";
export default function AccessQueue() { export default function AccessQueue() {
const [requests, setRequests] = useState<AccessRequest[]>([]); const queryClient = useQueryClient();
const [error, setError] = useState("");
const [info, setInfo] = useState("");
const [busyId, setBusyId] = useState(""); const [busyId, setBusyId] = useState("");
const [error, setError] = useState("");
const load = useCallback(async () => { const requestsQuery = useQuery({
try { queryKey: ["access-requests"],
setRequests(await api.listAccessRequests()); queryFn: () => api.listAccessRequests(),
} catch (e) { });
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); const requests: AccessRequest[] = requestsQuery.data ?? [];
}
}, []);
useEffect(() => { useEffect(() => {
void load(); if (requestsQuery.error) setError(formatApiError(requestsQuery.error));
}, [load]); }, [requestsQuery.error]);
async function decide(id: string, approve: boolean) { async function decide(id: string, approve: boolean) {
setBusyId(id); setBusyId(id);
setError(""); setError("");
setInfo("");
try { try {
const res = await api.decideAccess(id, approve); const res = await api.decideAccess(id, approve);
setRequests((prev) =>
prev.map((r) => (r.id === id ? res.request : r)),
);
if (approve && !res.email_sent) { if (approve && !res.email_sent) {
setInfo("Genehmigt — die E-Mail kam nicht an (SMTP prüfen)."); notifications.show({
title: "Genehmigt",
message: "Die E-Mail kam nicht an (SMTP prüfen).",
color: "yellow",
});
} else {
notifications.show({
title: approve ? "Genehmigt" : "Abgelehnt",
message: approve ? "Zugang freigegeben." : "Anfrage abgelehnt.",
color: approve ? "green" : "red",
});
} }
await queryClient.invalidateQueries({ queryKey: ["access-requests"] });
} catch (e) { } catch (e) {
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); setError(formatApiError(e));
} finally { } finally {
setBusyId(""); setBusyId("");
} }
@ -60,16 +63,7 @@ export default function AccessQueue() {
<Title order={3} mb="xs"> <Title order={3} mb="xs">
Zugangsanfragen Zugangsanfragen
</Title> </Title>
{error && ( <ErrorAlert message={error} />
<Alert color="red" icon={<IconAlertCircle size={18} />} mb="md">
{error}
</Alert>
)}
{info && (
<Alert color="green" icon={<IconCheck size={18} />} mb="md">
{info}
</Alert>
)}
{pending.length === 0 && ( {pending.length === 0 && (
<Text c="dimmed" mb="md"> <Text c="dimmed" mb="md">
Keine offenen Anfragen. Keine offenen Anfragen.
@ -90,23 +84,13 @@ export default function AccessQueue() {
{r.reason} {r.reason}
</Text> </Text>
)} )}
<Group> <DecisionButtons
<Button busy={busyId === r.id}
color="green" onApprove={() => void decide(r.id, true)}
loading={busyId === r.id} onReject={() => void decide(r.id, false)}
onClick={() => void decide(r.id, true)} approveLabel="Genehmigen"
> rejectLabel="Ablehnen"
Genehmigen />
</Button>
<Button
color="red"
variant="light"
loading={busyId === r.id}
onClick={() => void decide(r.id, false)}
>
Ablehnen
</Button>
</Group>
</Card> </Card>
))} ))}
</Stack> </Stack>
@ -119,7 +103,7 @@ export default function AccessQueue() {
<Group key={r.id} gap="xs" mb={4}> <Group key={r.id} gap="xs" mb={4}>
<StatusBadge status={r.status} /> <StatusBadge status={r.status} />
<Text size="sm"> <Text size="sm">
{r.name} · {r.email} {r.name} · {r.email} · <FormattedDate iso={r.decided_at} />
</Text> </Text>
</Group> </Group>
))} ))}

View file

@ -1,6 +1,5 @@
import { useCallback, useEffect, useState } from "react"; import { useEffect, useState } from "react";
import { import {
Alert,
Anchor, Anchor,
Button, Button,
Card, Card,
@ -10,83 +9,113 @@ import {
TextInput, TextInput,
Title, Title,
} from "@mantine/core"; } from "@mantine/core";
import { useForm } from "@mantine/form";
import { notifications } from "@mantine/notifications";
import { import {
IconAlertCircle,
IconCheck,
IconExternalLink, IconExternalLink,
IconRefresh, IconRefresh,
IconUpload, IconUpload,
} from "@tabler/icons-react"; } from "@tabler/icons-react";
import { useQuery, useQueryClient } from "@tanstack/react-query";
import { z } from "zod";
import { import {
ApiError,
LANGFLOW_URL, LANGFLOW_URL,
api, api,
type FlowDefinition, type FlowDefinition,
type FlowVersion, type FlowVersion,
} from "../api"; } from "../api";
import { formatApiError } from "../utils";
import FlowHelp from "./FlowHelp"; import FlowHelp from "./FlowHelp";
import { ErrorAlert } from "./ErrorAlert";
import StatusBadge from "./StatusBadge"; import StatusBadge from "./StatusBadge";
const importSchema = z.object({
langflowId: z.string().min(1, "Flow-ID erforderlich"),
importName: z.string(),
});
async function fetchVersions(
flows: FlowDefinition[],
): Promise<Record<string, FlowVersion[]>> {
const entries = await Promise.all(
flows.map(async (f) => [f.id, await api.listVersions(f.id)] as const),
);
return Object.fromEntries(entries);
}
export default function AdminTab() { export default function AdminTab() {
const [flows, setFlows] = useState<FlowDefinition[]>([]); const queryClient = useQueryClient();
const [versions, setVersions] = useState<Record<string, FlowVersion[]>>({}); const importForm = useForm({
const [langflowId, setLangflowId] = useState(""); initialValues: { langflowId: "", importName: "" },
const [importName, setImportName] = useState(""); validate: (values) => {
const parsed = importSchema.safeParse(values);
if (parsed.success) return {};
return {
langflowId:
parsed.error.flatten().fieldErrors.langflowId?.[0] ?? null,
};
},
});
const [error, setError] = useState(""); const [error, setError] = useState("");
const [info, setInfo] = useState("");
const load = useCallback(async () => { function notifyInfo(message: string) {
try { notifications.show({ message, color: "green" });
const list = await api.listFlows(); }
setFlows(list);
const all: Record<string, FlowVersion[]> = {};
for (const f of list) {
all[f.id] = await api.listVersions(f.id);
}
setVersions(all);
} catch (e) {
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e));
}
}, []);
const flowsQuery = useQuery({
queryKey: ["flows"],
queryFn: api.listFlows,
});
const flows = flowsQuery.data ?? [];
const versionsQuery = useQuery({
queryKey: ["versions", flows.map((f) => f.id)],
queryFn: () => fetchVersions(flows),
enabled: flows.length > 0,
});
const versions = versionsQuery.data ?? {};
useEffect(() => { useEffect(() => {
void load(); const e = flowsQuery.error ?? versionsQuery.error;
}, [load]); if (e) setError(formatApiError(e));
}, [flowsQuery.error, versionsQuery.error]);
async function reload() {
await queryClient.invalidateQueries({ queryKey: ["flows"] });
await queryClient.invalidateQueries({ queryKey: ["versions"] });
}
async function onImport() { async function onImport() {
setError(""); setError("");
setInfo(""); const validation = importForm.validate();
if (validation.hasErrors) return;
const { langflowId, importName } = importForm.values;
try { try {
const result = await api.importFlow( const result = await api.importFlow(
langflowId, langflowId,
importName.trim() ? importName.trim() : undefined, importName.trim() ? importName.trim() : undefined,
); );
setInfo( notifyInfo(
`Importiert: ${result.definition.name} (Version ${result.version.version_no})`, `Importiert: ${result.definition.name} (Version ${result.version.version_no})`,
); );
setLangflowId(""); importForm.reset();
setImportName(""); await reload();
await load();
} catch (e) { } catch (e) {
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); setError(formatApiError(e));
} }
} }
async function onDeploy(flowId: string, versionNo: number) { async function onDeploy(flowId: string, versionNo: number) {
setError(""); setError("");
setInfo("");
try { try {
const version = await api.deployVersion(flowId, versionNo); const version = await api.deployVersion(flowId, versionNo);
setInfo(`Deployed: Version ${version.version_no} (${version.lfx_flow_id})`); notifyInfo(`Deployed: Version ${version.version_no} (${version.lfx_flow_id})`);
await load(); await reload();
} catch (e) { } catch (e) {
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); setError(formatApiError(e));
} }
} }
async function onSync() { async function onSync() {
setError(""); setError("");
setInfo("");
try { try {
const r = await api.syncFlows(); const r = await api.syncFlows();
const parts = [ const parts = [
@ -98,10 +127,10 @@ export default function AdminTab() {
const errs = Object.entries(r.errors) const errs = Object.entries(r.errors)
.map(([f, e]) => `${f}: ${e}`) .map(([f, e]) => `${f}: ${e}`)
.join("; "); .join("; ");
setInfo(`Sync ${parts}${errs ? ` — Fehler: ${errs}` : ""}`); notifyInfo(`Sync ${parts}${errs ? ` — Fehler: ${errs}` : ""}`);
await load(); await reload();
} catch (e) { } catch (e) {
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); setError(formatApiError(e));
} }
} }
@ -110,16 +139,7 @@ export default function AdminTab() {
<Title order={3} mb="xs"> <Title order={3} mb="xs">
Flows & Versionen Flows & Versionen
</Title> </Title>
{error && ( <ErrorAlert message={error} />
<Alert color="red" icon={<IconAlertCircle size={18} />} mb="md">
{error}
</Alert>
)}
{info && (
<Alert color="green" icon={<IconCheck size={18} />} mb="md">
{info}
</Alert>
)}
<Card withBorder padding="md" mb="md"> <Card withBorder padding="md" mb="md">
<Text mb="xs"> <Text mb="xs">
Flows werden visuell in Langflow entworfen:{" "} Flows werden visuell in Langflow entworfen:{" "}
@ -130,20 +150,18 @@ export default function AdminTab() {
<Group align="flex-end"> <Group align="flex-end">
<TextInput <TextInput
label="Langflow Flow-ID (UUID)" label="Langflow Flow-ID (UUID)"
value={langflowId}
onChange={(e) => setLangflowId(e.target.value)}
style={{ flex: 1 }} style={{ flex: 1 }}
styles={{ input: { fontFamily: "monospace" } }} styles={{ input: { fontFamily: "monospace" } }}
{...importForm.getInputProps("langflowId")}
/> />
<TextInput <TextInput
label="Name (optional)" label="Name (optional)"
value={importName} {...importForm.getInputProps("importName")}
onChange={(e) => setImportName(e.target.value)}
/> />
<Button <Button
leftSection={<IconUpload size={16} />} leftSection={<IconUpload size={16} />}
onClick={() => void onImport()} onClick={() => void onImport()}
disabled={!langflowId.trim()} disabled={!importForm.values.langflowId.trim()}
> >
Importieren + Deployen Importieren + Deployen
</Button> </Button>
@ -179,40 +197,67 @@ export default function AdminTab() {
</Table.Tr> </Table.Tr>
</Table.Thead> </Table.Thead>
<Table.Tbody> <Table.Tbody>
{flows.map((f) => {flows.map((f) => {
(versions[f.id] ?? []).map((v, i) => ( const list = versions[f.id] ?? [];
<Table.Tr key={v.id}> const latest = list[list.length - 1];
if (!latest) {
return (
<Table.Tr key={f.id}>
<Table.Td>
<strong>{f.name}</strong>{" "}
<Text size="xs" c="dimmed" component="span">
{f.source_path ? `(${f.source_path})` : "(API)"}
</Text>
</Table.Td>
<Table.Td>–</Table.Td>
<Table.Td>
<StatusBadge status="pending" />
</Table.Td>
<Table.Td>–</Table.Td>
<Table.Td />
</Table.Tr>
);
}
const live = list
.filter((v) => v.deployed_at && v.id !== latest.id)
.at(-1);
return (
<Table.Tr key={latest.id}>
<Table.Td> <Table.Td>
{i === 0 && ( <strong>{f.name}</strong>{" "}
<> <Text size="xs" c="dimmed" component="span">
<strong>{f.name}</strong>{" "} {f.source_path ? `(${f.source_path})` : "(API)"}
<Text size="xs" c="dimmed" component="span"> </Text>
{f.source_path ? `(${f.source_path})` : "(API)"} </Table.Td>
</Text> <Table.Td>
</> v{latest.version_no}
{live && (
<Text size="xs" c="dimmed" component="span">
{" "}
(live: v{live.version_no})
</Text>
)} )}
</Table.Td> </Table.Td>
<Table.Td>v{v.version_no}</Table.Td>
<Table.Td> <Table.Td>
{v.deployed_at ? ( {latest.deployed_at ? (
<StatusBadge status="deployed" /> <StatusBadge status="deployed" />
) : ( ) : (
<StatusBadge status="pending" /> <StatusBadge status="pending" />
)} )}
</Table.Td> </Table.Td>
<Table.Td>{v.author || "–"}</Table.Td> <Table.Td>{latest.author || "–"}</Table.Td>
<Table.Td> <Table.Td>
<Button <Button
size="compact-sm" size="compact-sm"
variant="light" variant="light"
onClick={() => void onDeploy(f.id, v.version_no)} onClick={() => void onDeploy(f.id, latest.version_no)}
> >
Deployen Deployen
</Button> </Button>
</Table.Td> </Table.Td>
</Table.Tr> </Table.Tr>
)), );
)} })}
</Table.Tbody> </Table.Tbody>
</Table> </Table>
)} )}

View file

@ -1,49 +1,55 @@
import { useCallback, useEffect, useState } from "react"; import { useEffect, useState } from "react";
import { import {
Alert,
Button, Button,
Card, Card,
Code,
Group, Group,
Stack, Stack,
Text, Text,
TextInput, TextInput,
Title, Title,
} from "@mantine/core"; } from "@mantine/core";
import { IconAlertCircle, IconCheck, IconRefresh, IconX } from "@tabler/icons-react"; import { notifications } from "@mantine/notifications";
import { ApiError, api, type ApprovalTask } from "../api"; import { IconRefresh } from "@tabler/icons-react";
import { useQuery, useQueryClient } from "@tanstack/react-query";
import { api, type ApprovalTask } from "../api";
import { useAuth } from "../auth"; import { useAuth } from "../auth";
import { formatApiError } from "../utils";
import { DecisionButtons } from "./DecisionButtons";
import { ErrorAlert } from "./ErrorAlert";
import { JsonView } from "./JsonView";
import { FormattedDate } from "./FormattedDate";
import StatusBadge from "./StatusBadge"; import StatusBadge from "./StatusBadge";
export default function ApprovalsTab() { export default function ApprovalsTab() {
const { me } = useAuth(); const { me } = useAuth();
const [tasks, setTasks] = useState<ApprovalTask[]>([]); const queryClient = useQueryClient();
const [note, setNote] = useState(""); const [note, setNote] = useState("");
const [error, setError] = useState(""); const [error, setError] = useState("");
const [busyId, setBusyId] = useState(""); const [busyId, setBusyId] = useState("");
const load = useCallback(async () => { const tasksQuery = useQuery({
try { queryKey: ["approvals"],
setTasks(await api.listApprovals()); queryFn: api.listApprovals,
} catch (e) { });
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); const tasks: ApprovalTask[] = tasksQuery.data ?? [];
}
}, []);
useEffect(() => { useEffect(() => {
void load(); if (tasksQuery.error) setError(formatApiError(tasksQuery.error));
}, [load]); }, [tasksQuery.error]);
async function decide(taskId: string, decision: "approve" | "reject") { async function decide(taskId: string, decision: "approve" | "reject") {
setBusyId(taskId); setBusyId(taskId);
setError(""); setError("");
try { try {
const result = await api.decide(taskId, decision, note); await api.decide(taskId, decision, note);
setTasks((prev) => notifications.show({
prev.map((t) => (t.id === taskId ? result.task : t)), title: decision === "approve" ? "Freigegeben" : "Abgelehnt",
); color: decision === "approve" ? "green" : "red",
message: note || undefined,
});
await queryClient.invalidateQueries({ queryKey: ["approvals"] });
await queryClient.invalidateQueries({ queryKey: ["all-runs"] });
} catch (e) { } catch (e) {
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); setError(formatApiError(e));
} finally { } finally {
setBusyId(""); setBusyId("");
} }
@ -57,11 +63,7 @@ export default function ApprovalsTab() {
<Title order={3} mb="xs"> <Title order={3} mb="xs">
Freigaben Freigaben
</Title> </Title>
{error && ( <ErrorAlert message={error} />
<Alert color="red" icon={<IconAlertCircle size={18} />} mb="md">
{error}
</Alert>
)}
<Text size="sm" c="dimmed" mb="md"> <Text size="sm" c="dimmed" mb="md">
Angemeldet als {me?.email ?? "–"} — Entscheidungen werden diesem Angemeldet als {me?.email ?? "–"} — Entscheidungen werden diesem
Konto zugeordnet. Konto zugeordnet.
@ -76,7 +78,10 @@ export default function ApprovalsTab() {
<Button <Button
variant="light" variant="light"
leftSection={<IconRefresh size={16} />} leftSection={<IconRefresh size={16} />}
onClick={() => void load()} loading={tasksQuery.isFetching}
onClick={() =>
void queryClient.invalidateQueries({ queryKey: ["approvals"] })
}
> >
Aktualisieren Aktualisieren
</Button> </Button>
@ -99,27 +104,15 @@ export default function ApprovalsTab() {
{t.tenant_id} {t.tenant_id}
</Text> </Text>
</Group> </Group>
<Code block mb="sm"> <JsonView value={t.payload} />
{JSON.stringify(t.payload)}
</Code>
<Group> <Group>
<Button <DecisionButtons
color="green" busy={busyId === t.id}
leftSection={<IconCheck size={16} />} onApprove={() => void decide(t.id, "approve")}
loading={busyId === t.id} onReject={() => void decide(t.id, "reject")}
onClick={() => void decide(t.id, "approve")} approveLabel="Freigeben"
> rejectLabel="Ablehnen"
Freigeben />
</Button>
<Button
color="red"
variant="light"
leftSection={<IconX size={16} />}
loading={busyId === t.id}
onClick={() => void decide(t.id, "reject")}
>
Ablehnen
</Button>
</Group> </Group>
</Card> </Card>
))} ))}
@ -132,7 +125,8 @@ export default function ApprovalsTab() {
<StatusBadge status={t.status} /> <StatusBadge status={t.status} />
<Text size="sm"> <Text size="sm">
{t.title || t.id} · {t.approver ?? "–"} {t.title || t.id} · {t.approver ?? "–"}
{t.decision_note ? ` · „${t.decision_note}“` : ""} {t.decision_note ? ` · „${t.decision_note}“` : ""} ·{" "}
<FormattedDate iso={t.decided_at} />
</Text> </Text>
</Group> </Group>
))} ))}

View file

@ -0,0 +1,38 @@
import { Button, Group } from "@mantine/core";
import { IconCheck, IconX } from "@tabler/icons-react";
export function DecisionButtons({
busy,
onApprove,
onReject,
approveLabel,
rejectLabel,
}: {
busy: boolean;
onApprove: () => void;
onReject: () => void;
approveLabel: string;
rejectLabel: string;
}) {
return (
<Group>
<Button
color="green"
leftSection={<IconCheck size={16} />}
loading={busy}
onClick={onApprove}
>
{approveLabel}
</Button>
<Button
color="red"
variant="light"
leftSection={<IconX size={16} />}
loading={busy}
onClick={onReject}
>
{rejectLabel}
</Button>
</Group>
);
}

View file

@ -0,0 +1,11 @@
import { Alert } from "@mantine/core";
import { IconAlertCircle } from "@tabler/icons-react";
export function ErrorAlert({ message }: { message: string | null }) {
if (!message) return null;
return (
<Alert color="red" icon={<IconAlertCircle size={18} />}>
{message}
</Alert>
);
}

View file

@ -1,12 +1,5 @@
import { useState } from "react"; import { useState } from "react";
import { import { Anchor, Button, Card, List, Text, Title } from "@mantine/core";
Anchor,
Button,
Card,
List,
Text,
Title,
} from "@mantine/core";
import { IconChevronDown, IconChevronUp, IconExternalLink } from "@tabler/icons-react"; import { IconChevronDown, IconChevronUp, IconExternalLink } from "@tabler/icons-react";
import { LANGFLOW_URL } from "../api"; import { LANGFLOW_URL } from "../api";
@ -23,70 +16,46 @@ export default function FlowHelp() {
{open ? "Anleitung verbergen" : "Anleitung: Neuer Flow in Langflow"} {open ? "Anleitung verbergen" : "Anleitung: Neuer Flow in Langflow"}
</Button> </Button>
{open && ( {open && (
<div> <div>
<Title order={4} mt="sm" mb="xs"> <Title order={4} mt="sm" mb="xs">
So kommt ein neuer Flow in die Webapp So kommt ein neuer Flow in die Webapp
</Title> </Title>
<List size="sm" spacing="xs"> <List size="sm" spacing="xs">
<List.Item> <List.Item>
<Text component="span" fw={600}> <Text component="span" fw={600}>
1. In Langflow entwerfen und speichern:{" "} 1. In Langflow entwerfen und speichern:{" "}
</Text> </Text>
<Anchor href={LANGFLOW_URL} target="_blank" rel="noreferrer"> <Anchor href={LANGFLOW_URL} target="_blank" rel="noreferrer">
Langflow öffnen <IconExternalLink size={14} /> Langflow öffnen <IconExternalLink size={14} />
</Anchor> </Anchor>
. Die bestehenden Flows sind dort bereits geladen. Name vergeben, speichern. . Die bestehenden Flows sind dort bereits geladen.
</List.Item> </List.Item>
<List.Item> <List.Item>
<Text component="span" fw={600}> <Text component="span" fw={600}>
2. Sync-Button unten klicken:{" "} 2. Sync-Button unten klicken:{" "}
</Text> </Text>
holt alle Flows aus Langflow nach{" "} holt alle Flows nach{" "}
<Text component="span" ff="monospace">
backend/flows/*.json
</Text>{" "}
und deployed sie automatisch.
</List.Item>
<List.Item>
<Text component="span" fw={600}>
3. Prüfen:{" "}
</Text>
danach erscheint der Flow auf der Seite Workflows. Flows ohne
Formular-Knoten zeigen ein Freitext-Feld.
</List.Item>
</List>
<Text size="sm" c="dimmed" mt="sm">
Regeln, Formular-Felder und Sync-Sicherheit: siehe{" "}
<Text component="span" ff="monospace"> <Text component="span" ff="monospace">
backend/flows/*.json docs/flow-authoring.md
</Text>{" "} </Text>{" "}
und deployed sie danach automatisch (neue Version nur bei geändertem Inhalt, im Repo.
sonst übersprungen). </Text>
</List.Item> </div>
<List.Item>
<Text component="span" fw={600}>
3. Prüfen:{" "}
</Text>
Tabelle unten zeigt Version, Autor und Status. Danach erscheint der Flow
automatisch auf der Seite Workflows mit seinem Formular. Flows ohne
Formular-Knoten zeigen ein Freitext-Feld.
</List.Item>
</List>
<Title order={5} mt="md" mb="xs">
Regeln
</Title>
<List size="sm" spacing="xs">
<List.Item>
Die Datei heißt wie der Flow in Langflow (z. B. test_flow.json).
Umbenennen in Langflow erzeugt eine neue Datei; die alte bleibt
bestehen und muss bei Bedarf gelöscht werden.
</List.Item>
<List.Item>
Eine gelöschte Datei löscht den Flow inklusive seiner Läufe
(Datei bleibt in Git erhalten).
</List.Item>
<List.Item>
Fehler stehen in der Sync-Meldung (z. B. ungültiges Flow-JSON).
Der automatische Beobachter im Hintergrund syncet nur Dateien,
Langflow holt nur dieser Button.
</List.Item>
</List>
<Title order={5} mt="md" mb="xs">
Formular-Felder
</Title>
<Text size="sm">
Für ein Web-Formular braucht der Flow einen CustomInputForm-Knoten: jeder
Eintrag dort ist ein Formularfeld (Name = Feld-Key, Anzeigename = Label).
Die Verbindung ChatInput nach form_values bitte behalten — darüber kommen
die ausgefüllten Werte an. Unbekannte Feldtypen fallen automatisch auf ein
Textfeld zurück.
</Text>
</div>
)} )}
</Card> </Card>
); );

View file

@ -0,0 +1,10 @@
import dayjs from "dayjs";
import "dayjs/locale/de";
dayjs.locale("de");
/** Localized date (was toLocaleString in one place, missing elsewhere). */
export function FormattedDate({ iso }: { iso: string | null }) {
if (!iso) return <>–</>;
return <>{dayjs(iso).format("DD.MM.YYYY HH:mm")}</>;
}

View file

@ -0,0 +1,12 @@
import { Code } from "@mantine/core";
const MAX_LEN = 2000;
/** Pretty JSON view (was raw JSON.stringify / [object Object] in 3 places). */
export function JsonView({ value }: { value: unknown }) {
if (value === null || value === undefined) return <>–</>;
const text =
typeof value === "string" ? value : JSON.stringify(value, null, 2);
const shown = text.length > MAX_LEN ? text.slice(0, MAX_LEN) + "…" : text;
return <Code block>{shown}</Code>;
}

View file

@ -0,0 +1,71 @@
import type { ReactNode } from "react";
import { Card, Image, Text, ThemeIcon, Title } from "@mantine/core";
export const PHOTO_CLASS = "photo";
/** Shared landing building blocks (was copy-pasted Card/Icon/Title/Text x10). */
export function SectionTitle({ children }: { children: string }) {
return (
<Title order={2} mb="xs" ta="center">
{children}
</Title>
);
}
export function SectionCard({ children }: { children: ReactNode }) {
return (
<Card withBorder padding="xl" radius="lg">
{children}
</Card>
);
}
export function FeatureCard({
icon,
title,
text,
iconSize = 40,
}: {
icon: ReactNode;
title: string;
text: string;
iconSize?: number;
}) {
return (
<Card withBorder padding="lg" radius="lg">
<ThemeIcon size={iconSize} radius="md" variant="light" mb="sm">
{icon}
</ThemeIcon>
<Title order={4} mb="xs">
{title}
</Title>
<Text size="sm" c="dimmed">
{text}
</Text>
</Card>
);
}
export function PhotoImage({
src,
alt,
h,
eager = false,
}: {
src: string;
alt: string;
h?: number;
eager?: boolean;
}) {
return (
<Image
src={src}
alt={alt}
radius="lg"
className={PHOTO_CLASS}
loading={eager ? undefined : "lazy"}
h={h}
fit="cover"
/>
);
}

View file

@ -0,0 +1,42 @@
import { Table } from "@mantine/core";
import StatusBadge from "./StatusBadge";
import { FormattedDate } from "./FormattedDate";
import { JsonView } from "./JsonView";
import type { Run } from "../api";
export function RunsTable({
runs,
flowName,
}: {
runs: Run[];
flowName?: (run: Run) => string;
}) {
return (
<Table>
<Table.Thead>
<Table.Tr>
<Table.Th>Status</Table.Th>
{flowName && <Table.Th>Flow</Table.Th>}
<Table.Th>Ergebnis</Table.Th>
<Table.Th>Erstellt</Table.Th>
</Table.Tr>
</Table.Thead>
<Table.Tbody>
{runs.map((r) => (
<Table.Tr key={r.id}>
<Table.Td>
<StatusBadge status={r.status} />
</Table.Td>
{flowName && <Table.Td>{flowName(r)}</Table.Td>}
<Table.Td>
<JsonView value={r.output?.result ?? r.output?.error ?? "–"} />
</Table.Td>
<Table.Td>
<FormattedDate iso={r.created_at} />
</Table.Td>
</Table.Tr>
))}
</Table.Tbody>
</Table>
);
}

View file

@ -1,8 +1,9 @@
import { Badge } from "@mantine/core"; import { Badge } from "@mantine/core";
import type { Status } from "../api";
/* Single color language for every status in the app. */ /* Single color language for every status in the app. */
const COLORS: Record<string, string> = { const COLORS: Record<Status, string> = {
completed: "green", completed: "green",
approved: "green", approved: "green",
genehmigt: "green", genehmigt: "green",
@ -16,6 +17,6 @@ const COLORS: Record<string, string> = {
abgelehnt: "red", abgelehnt: "red",
}; };
export default function StatusBadge({ status }: { status: string }) { export default function StatusBadge({ status }: { status: Status }) {
return <Badge color={COLORS[status] ?? "gray"}>{status}</Badge>; return <Badge color={COLORS[status]}>{status}</Badge>;
} }

View file

@ -1,7 +1,6 @@
import { useState } from "react"; import { useState } from "react";
import { useSearchParams } from "react-router-dom"; import { useSearchParams } from "react-router-dom";
import { import {
Alert,
Button, Button,
Card, Card,
Stack, Stack,
@ -10,31 +9,53 @@ import {
TextInput, TextInput,
Title, Title,
} from "@mantine/core"; } from "@mantine/core";
import { IconAlertCircle, IconCheck } from "@tabler/icons-react"; import { useForm } from "@mantine/form";
import { z } from "zod";
import { ApiError, api } from "../api"; import { ApiError, api } from "../api";
import { formatApiError } from "../utils";
import { ErrorAlert } from "../components/ErrorAlert";
const accessSchema = z.object({
name: z.string().min(1, "Name erforderlich").max(200),
email: z.string().email("Gültige E-Mail erforderlich").max(320),
reason: z.string().max(2000),
});
export default function AccessPage() { export default function AccessPage() {
const [params] = useSearchParams(); const [params] = useSearchParams();
const [name, setName] = useState(""); const form = useForm({
const [email, setEmail] = useState(params.get("email") ?? ""); initialValues: {
const [reason, setReason] = useState(""); name: "",
email: params.get("email") ?? "",
reason: "",
},
validate: (values) => {
const parsed = accessSchema.safeParse(values);
if (parsed.success) return {};
const flat = parsed.error.flatten().fieldErrors;
return {
name: flat.name?.[0] ?? null,
email: flat.email?.[0] ?? null,
reason: flat.reason?.[0] ?? null,
};
},
});
const [done, setDone] = useState(false); const [done, setDone] = useState(false);
const [error, setError] = useState(""); const [error, setError] = useState("");
const [busy, setBusy] = useState(false); const [busy, setBusy] = useState(false);
async function onSubmit(e: React.FormEvent) { async function onSubmit(values: typeof form.values) {
e.preventDefault();
setBusy(true); setBusy(true);
setError(""); setError("");
try { try {
await api.requestAccess(name.trim(), email.trim(), reason.trim()); await api.requestAccess(values.name.trim(), values.email.trim(), values.reason.trim());
setDone(true); setDone(true);
} catch (err) { } catch (err) {
setError( setError(
err instanceof ApiError err instanceof ApiError
? err.status === 429 ? err.status === 429
? "Zu viele Anfragen von dieser Adresse — bitte später erneut versuchen." ? "Zu viele Anfragen von dieser Adresse — bitte später erneut versuchen."
: `${err.status}: ${err.message}` : formatApiError(err)
: String(err), : String(err),
); );
} finally { } finally {
@ -48,38 +69,25 @@ export default function AccessPage() {
Zugang anfragen Zugang anfragen
</Title> </Title>
{done ? ( {done ? (
<Alert color="green" icon={<IconCheck size={18} />} title="Angefragt"> <Text c="green">
Danke! Ihre Anfrage ist eingegangen. Sie erhalten eine E-Mail, sobald Danke! Ihre Anfrage ist eingegangen. Sie erhalten eine E-Mail,
sie freigegeben wurde. sobald sie freigegeben wurde.
</Alert> </Text>
) : ( ) : (
<form onSubmit={(e) => void onSubmit(e)}> <form onSubmit={form.onSubmit((v) => void onSubmit(v))}>
<Stack> <Stack>
{error && ( <ErrorAlert message={error} />
<Alert color="red" icon={<IconAlertCircle size={18} />}> <TextInput label="Name" required {...form.getInputProps("name")} />
{error}
</Alert>
)}
<TextInput
label="Name"
value={name}
onChange={(e) => setName(e.target.value)}
required
maxLength={200}
/>
<TextInput <TextInput
label="E-Mail" label="E-Mail"
type="email" type="email"
value={email}
onChange={(e) => setEmail(e.target.value)}
required required
maxLength={320} {...form.getInputProps("email")}
/> />
<Textarea <Textarea
label="Wofür brauchen Sie Zugang?" label="Wofür brauchen Sie Zugang?"
value={reason}
onChange={(e) => setReason(e.target.value)}
rows={4} rows={4}
{...form.getInputProps("reason")}
/> />
<Button type="submit" loading={busy}> <Button type="submit" loading={busy}>
Anfragen Anfragen

View file

@ -7,40 +7,29 @@ import { useAuth } from "../auth";
export default function AdminPage() { export default function AdminPage() {
const { me } = useAuth(); const { me } = useAuth();
if (!me) { const denied = !me || me.role !== "admin";
return (
<div>
<Title order={2} mb="md">
Verwaltung
</Title>
<Alert color="blue">
Bitte melden Sie sich an, um die Verwaltung zu nutzen.
</Alert>
</div>
);
}
if (me.role !== "admin") {
return (
<div>
<Title order={2} mb="md">
Verwaltung
</Title>
<Alert color="red" icon={<IconAlertCircle size={18} />}>
Nur für Administratoren. Ihr Konto hat die Rolle „{me.role}“.
</Alert>
</div>
);
}
return ( return (
<div> <div>
<Title order={2} mb="md"> <Title order={2} mb="md">
Verwaltung Verwaltung
</Title> </Title>
<Stack gap="xl"> {denied ? (
<AccessQueue /> <Alert
<ApprovalsTab /> color={!me ? "blue" : "red"}
<AdminTab /> icon={me ? <IconAlertCircle size={18} /> : undefined}
</Stack> >
{!me
? "Bitte melden Sie sich an, um die Verwaltung zu nutzen."
: `Nur für Administratoren. Ihr Konto hat die Rolle „${me.role}“.`}
</Alert>
) : (
<Stack gap="xl">
<AccessQueue />
<ApprovalsTab />
<AdminTab />
</Stack>
)}
</div> </div>
); );
} }

View file

@ -1,7 +1,6 @@
import { useEffect, useState } from "react"; import { useEffect, useState } from "react";
import { Link, Navigate, useNavigate, useSearchParams } from "react-router-dom"; import { Link, Navigate, useNavigate, useSearchParams } from "react-router-dom";
import { import {
Alert,
Anchor, Anchor,
Button, Button,
Card, Card,
@ -12,16 +11,31 @@ import {
TextInput, TextInput,
Title, Title,
} from "@mantine/core"; } from "@mantine/core";
import { IconAlertCircle, IconCheck, IconMail } from "@tabler/icons-react"; import { useForm } from "@mantine/form";
import { IconMail } from "@tabler/icons-react";
import { z } from "zod";
import { ApiError, api } from "../api"; import { ApiError, api } from "../api";
import { useAuth } from "../auth"; import { useAuth } from "../auth";
import { formatApiError } from "../utils";
import { ErrorAlert } from "../components/ErrorAlert";
const loginSchema = z.object({
email: z.string().email("Gültige E-Mail erforderlich").max(320),
});
export default function LoginPage() { export default function LoginPage() {
const [params] = useSearchParams(); const [params] = useSearchParams();
const navigate = useNavigate(); const navigate = useNavigate();
const token = params.get("token") ?? ""; const token = params.get("token") ?? "";
const { me, refresh } = useAuth(); const { me, refresh } = useAuth();
const [email, setEmail] = useState(""); const form = useForm({
initialValues: { email: "" },
validate: (values) => {
const parsed = loginSchema.safeParse(values);
if (parsed.success) return {};
return { email: parsed.error.flatten().fieldErrors.email?.[0] ?? null };
},
});
const [sent, setSent] = useState(false); const [sent, setSent] = useState(false);
const [error, setError] = useState(""); const [error, setError] = useState("");
const [busy, setBusy] = useState(!!token); const [busy, setBusy] = useState(!!token);
@ -45,24 +59,23 @@ export default function LoginPage() {
.finally(() => setBusy(false)); .finally(() => setBusy(false));
}, [token, refresh]); }, [token, refresh]);
async function onSubmit(e: React.FormEvent) { async function onSubmit(values: typeof form.values) {
e.preventDefault();
setBusy(true); setBusy(true);
setError(""); setError("");
try { try {
await api.requestMagicLink(email.trim()); await api.requestMagicLink(values.email.trim());
setSent(true); setSent(true);
} catch (err) { } catch (err) {
if (err instanceof ApiError && err.status === 403) { if (err instanceof ApiError && err.status === 403) {
// Not allowed yet — forward to the access request form. // Not allowed yet — forward to the access request form.
navigate(`/access?email=${encodeURIComponent(email.trim())}`); navigate(`/access?email=${encodeURIComponent(values.email.trim())}`);
return; return;
} }
setError( setError(
err instanceof ApiError err instanceof ApiError
? err.status === 429 ? err.status === 429
? "Zu viele Links angefordert — bitte später erneut versuchen." ? "Zu viele Links angefordert — bitte später erneut versuchen."
: `${err.status}: ${err.message}` : formatApiError(err)
: String(err), : String(err),
); );
} finally { } finally {
@ -85,32 +98,22 @@ export default function LoginPage() {
<Loader /> <Loader />
</Center> </Center>
)} )}
{error && ( <ErrorAlert message={error} />
<Alert color="red" icon={<IconAlertCircle size={18} />}>
{error}
</Alert>
)}
</> </>
) : sent ? ( ) : sent ? (
<Alert color="green" icon={<IconCheck size={18} />} title="Unterwegs"> <Text c="green">
Falls die Adresse freigegeben ist, kommt der Login-Link per Falls die Adresse freigegeben ist, kommt der Login-Link per
E-Mail. Bitte auch den Spam-Ordner prüfen. E-Mail. Bitte auch den Spam-Ordner prüfen.
</Alert> </Text>
) : ( ) : (
<form onSubmit={(e) => void onSubmit(e)}> <form onSubmit={form.onSubmit((v) => void onSubmit(v))}>
<Stack> <Stack>
{error && ( <ErrorAlert message={error} />
<Alert color="red" icon={<IconAlertCircle size={18} />}>
{error}
</Alert>
)}
<TextInput <TextInput
label="E-Mail" label="E-Mail"
type="email" type="email"
value={email}
onChange={(e) => setEmail(e.target.value)}
required required
maxLength={320} {...form.getInputProps("email")}
/> />
<Button <Button
type="submit" type="submit"

View file

@ -37,6 +37,13 @@ import {
IconWand, IconWand,
} from "@tabler/icons-react"; } from "@tabler/icons-react";
import { useAuth } from "../auth"; import { useAuth } from "../auth";
import {
FeatureCard,
PHOTO_CLASS,
PhotoImage,
SectionCard,
SectionTitle,
} from "../components/Landing";
const CTA_LABEL = "Pilotgespräch vereinbaren"; const CTA_LABEL = "Pilotgespräch vereinbaren";
const CTA_TO = "/access"; const CTA_TO = "/access";
@ -259,14 +266,6 @@ const pilotPoints = [
"Persönlicher Ansprechpartner während der gesamten Pilotphase", "Persönlicher Ansprechpartner während der gesamten Pilotphase",
]; ];
function SectionTitle({ children }: { children: string }) {
return (
<Title order={2} mb="xs" ta="center">
{children}
</Title>
);
}
export default function StartPage() { export default function StartPage() {
const { me } = useAuth(); const { me } = useAuth();
return ( return (
@ -318,13 +317,10 @@ export default function StartPage() {
)} )}
</Box> </Box>
<Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}> <Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}>
<Image <PhotoImage
src="/photos/hero-church.webp" src="/photos/hero-church.webp"
alt="Steinerner Kirchturm unter blauem Himmel" alt="Steinerner Kirchturm unter blauem Himmel"
radius="lg"
className="photo"
h={420} h={420}
fit="cover"
/> />
</Box> </Box>
</Flex> </Flex>
@ -354,14 +350,10 @@ export default function StartPage() {
</Stack> </Stack>
</Box> </Box>
<Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}> <Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}>
<Image <PhotoImage
src="/photos/paperwork-desk.webp" src="/photos/paperwork-desk.webp"
alt="Schreibtisch mit Stempeln und Formularen — so sieht es heute oft aus" alt="Schreibtisch mit Stempeln und Formularen — so sieht es heute oft aus"
radius="lg"
className="photo"
loading="lazy"
h={280} h={280}
fit="cover"
/> />
</Box> </Box>
</Flex> </Flex>
@ -413,7 +405,7 @@ export default function StartPage() {
src="/screenshots/workflows-light.png" src="/screenshots/workflows-light.png"
alt="Portal von Kirche Einfach mit Vorgangsformular" alt="Portal von Kirche Einfach mit Vorgangsformular"
radius="md" radius="md"
className="photo" className={PHOTO_CLASS}
loading="lazy" loading="lazy"
bd="1px solid var(--mantine-color-default-border)" bd="1px solid var(--mantine-color-default-border)"
/> />
@ -432,17 +424,13 @@ export default function StartPage() {
</Text> </Text>
<SimpleGrid cols={{ base: 1, xs: 2, md: 3 }} spacing="lg"> <SimpleGrid cols={{ base: 1, xs: 2, md: 3 }} spacing="lg">
{platformParts.map((p) => ( {platformParts.map((p) => (
<Card key={p.title} withBorder padding="lg" radius="lg"> <FeatureCard
<ThemeIcon size={44} radius="md" variant="light" mb="sm"> key={p.title}
{p.icon} icon={p.icon}
</ThemeIcon> title={p.title}
<Title order={4} mb="xs"> text={p.text}
{p.title} iconSize={44}
</Title> />
<Text size="sm" c="dimmed">
{p.text}
</Text>
</Card>
))} ))}
</SimpleGrid> </SimpleGrid>
</div> </div>
@ -486,23 +474,18 @@ export default function StartPage() {
</Card> </Card>
<SimpleGrid cols={{ base: 1, xs: 2 }} spacing="lg"> <SimpleGrid cols={{ base: 1, xs: 2 }} spacing="lg">
{otherBenefits.map((b) => ( {otherBenefits.map((b) => (
<Card key={b.title} withBorder padding="lg" radius="lg"> <FeatureCard
<ThemeIcon size={40} radius="md" variant="light" mb="sm"> key={b.title}
{b.icon} icon={b.icon}
</ThemeIcon> title={b.title}
<Title order={4} mb="xs"> text={b.text}
{b.title} />
</Title>
<Text size="sm" c="dimmed">
{b.text}
</Text>
</Card>
))} ))}
</SimpleGrid> </SimpleGrid>
</div> </div>
{/* Integrations */} {/* Integrations */}
<Card withBorder padding="xl" radius="lg"> <SectionCard>
<Title order={2} mb="xs" ta="center"> <Title order={2} mb="xs" ta="center">
Passt zu Ihrer bestehenden IT Passt zu Ihrer bestehenden IT
</Title> </Title>
@ -516,7 +499,7 @@ export default function StartPage() {
</Badge> </Badge>
))} ))}
</Group> </Group>
</Card> </SectionCard>
{/* Examples */} {/* Examples */}
<div> <div>
@ -538,17 +521,12 @@ export default function StartPage() {
<SectionTitle>Darauf können Sie sich verlassen</SectionTitle> <SectionTitle>Darauf können Sie sich verlassen</SectionTitle>
<SimpleGrid cols={{ base: 1, xs: 2 }} spacing="lg"> <SimpleGrid cols={{ base: 1, xs: 2 }} spacing="lg">
{trust.map((t) => ( {trust.map((t) => (
<Card key={t.title} withBorder padding="lg" radius="lg"> <FeatureCard
<ThemeIcon size={40} radius="md" variant="light" mb="sm"> key={t.title}
{t.icon} icon={t.icon}
</ThemeIcon> title={t.title}
<Title order={4} mb="xs"> text={t.text}
{t.title} />
</Title>
<Text size="sm" c="dimmed">
{t.text}
</Text>
</Card>
))} ))}
</SimpleGrid> </SimpleGrid>
</div> </div>
@ -586,14 +564,10 @@ export default function StartPage() {
</Button> </Button>
</Box> </Box>
<Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}> <Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}>
<Image <PhotoImage
src="/photos/pilot-meeting.webp" src="/photos/pilot-meeting.webp"
alt="Persönliches Beratungsgespräch mit Notizen am Tisch" alt="Persönliches Beratungsgespräch mit Notizen am Tisch"
radius="lg"
className="photo"
loading="lazy"
h={300} h={300}
fit="cover"
/> />
</Box> </Box>
</Flex> </Flex>
@ -631,14 +605,10 @@ export default function StartPage() {
</Button> </Button>
</Box> </Box>
<Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}> <Box style={{ flex: 5 }} w={{ base: "100%", md: "auto" }}>
<Image <PhotoImage
src="/photos/church-pews.webp" src="/photos/church-pews.webp"
alt="Ruhiger Kirchenraum mit leeren Bänken" alt="Ruhiger Kirchenraum mit leeren Bänken"
radius="lg"
className="photo"
loading="lazy"
h={260} h={260}
fit="cover"
/> />
</Box> </Box>
</Flex> </Flex>

View file

@ -1,43 +1,30 @@
import { useCallback, useEffect, useState } from "react"; import { Text, Title } from "@mantine/core";
import { Alert, Code, Table, Text, Title } from "@mantine/core"; import { useQuery } from "@tanstack/react-query";
import { IconAlertCircle } from "@tabler/icons-react"; import { useEffect, useState } from "react";
import { ApiError, api, type Run } from "../api"; import { api } from "../api";
import { formatApiError } from "../utils";
import ApprovalsTab from "../components/ApprovalsTab"; import ApprovalsTab from "../components/ApprovalsTab";
import StatusBadge from "../components/StatusBadge"; import { ErrorAlert } from "../components/ErrorAlert";
import { RunsTable } from "../components/RunsTable";
export default function TasksPage() { export default function TasksPage() {
const [runs, setRuns] = useState<{ flow: string; run: Run }[]>([]);
const [error, setError] = useState(""); const [error, setError] = useState("");
const runsQuery = useQuery({
const load = useCallback(async () => { queryKey: ["all-runs"],
try { queryFn: api.listAllRuns,
const flows = await api.listFlows(); });
const all: { flow: string; run: Run }[] = []; const runs = runsQuery.data ?? [];
for (const f of flows) {
const rs = await api.listRuns(f.id);
for (const r of rs) all.push({ flow: f.name, run: r });
}
all.sort((a, b) => (a.run.created_at < b.run.created_at ? 1 : -1));
setRuns(all);
} catch (e) {
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e));
}
}, []);
useEffect(() => { useEffect(() => {
void load(); if (runsQuery.error) setError(formatApiError(runsQuery.error));
}, [load]); }, [runsQuery.error]);
const byId = new Map(runs.map(({ flow_name, run }) => [run.id, flow_name]));
return ( return (
<div> <div>
<Title order={2} mb="md"> <Title order={2} mb="md">
Aufgaben Aufgaben
</Title> </Title>
{error && ( <ErrorAlert message={error} />
<Alert color="red" icon={<IconAlertCircle size={18} />} mb="md">
{error}
</Alert>
)}
<Title order={3} mb="xs"> <Title order={3} mb="xs">
Eigene Läufe Eigene Läufe
</Title> </Title>
@ -46,28 +33,10 @@ export default function TasksPage() {
Noch keine Läufe. Noch keine Läufe.
</Text> </Text>
) : ( ) : (
<Table striped highlightOnHover mb="md"> <RunsTable
<Table.Thead> runs={runs.map(({ run }) => run)}
<Table.Tr> flowName={(r) => byId.get(r.id) ?? "–"}
<Table.Th>Status</Table.Th> />
<Table.Th>Flow</Table.Th>
<Table.Th>Ergebnis</Table.Th>
</Table.Tr>
</Table.Thead>
<Table.Tbody>
{runs.map(({ flow, run }) => (
<Table.Tr key={run.id}>
<Table.Td>
<StatusBadge status={run.status} />
</Table.Td>
<Table.Td>{flow}</Table.Td>
<Table.Td>
<Code>{run.output?.result ?? run.output?.error ?? "–"}</Code>
</Table.Td>
</Table.Tr>
))}
</Table.Tbody>
</Table>
)} )}
<ApprovalsTab /> <ApprovalsTab />
</div> </div>

View file

@ -1,67 +1,77 @@
import { useCallback, useEffect, useState } from "react"; import { useEffect, useState } from "react";
import Form from "@rjsf/mantine"; import Form from "@rjsf/mantine";
import validator from "@rjsf/validator-ajv8"; import validator from "@rjsf/validator-ajv8";
import type { RJSFSchema, UiSchema } from "@rjsf/utils"; import type { RJSFSchema, UiSchema } from "@rjsf/utils";
import { import {
Alert,
Button, Button,
Card, Card,
Code, Code,
Select, Select,
Table,
Text, Text,
Textarea, Textarea,
Title, Title,
} from "@mantine/core"; } from "@mantine/core";
import { IconAlertCircle, IconPlayerPlay } from "@tabler/icons-react"; import { notifications } from "@mantine/notifications";
import { ApiError, api, type FlowDefinition, type InputSchema, type Run } from "../api"; import { IconPlayerPlay } from "@tabler/icons-react";
import StatusBadge from "../components/StatusBadge"; import { useQuery, useQueryClient } from "@tanstack/react-query";
import { ApiError, api, type Run } from "../api";
import { RunsTable } from "../components/RunsTable";
import { ErrorAlert } from "../components/ErrorAlert";
import { formatApiError } from "../utils";
export default function WorkflowsPage() { export default function WorkflowsPage() {
const [flows, setFlows] = useState<FlowDefinition[]>([]); const queryClient = useQueryClient();
const [flowId, setFlowId] = useState(""); const [flowId, setFlowId] = useState("");
const [schema, setSchema] = useState<InputSchema | null>(null);
const [formData, setFormData] = useState<Record<string, unknown>>({}); const [formData, setFormData] = useState<Record<string, unknown>>({});
const [freeText, setFreeText] = useState(""); const [freeText, setFreeText] = useState("");
const [runs, setRuns] = useState<Run[]>([]);
const [result, setResult] = useState(""); const [result, setResult] = useState("");
const [error, setError] = useState(""); const [error, setError] = useState("");
const [busy, setBusy] = useState(false); const [busy, setBusy] = useState(false);
const fail = useCallback((e: unknown) => { const flowsQuery = useQuery({
setError(e instanceof ApiError ? `${e.status}: ${e.message}` : String(e)); queryKey: ["flows"],
}, []); queryFn: api.listFlows,
});
const flows = flowsQuery.data ?? [];
useEffect(() => { useEffect(() => {
api const first = flows[0];
.listFlows() if (first) setFlowId((prev) => prev || first.id);
.then((list) => { }, [flows]);
setFlows(list);
const first = list[0];
if (first) setFlowId((prev) => prev || first.id);
})
.catch(fail);
}, [fail]);
useEffect(() => { useEffect(() => {
if (!flowId) return; if (flowsQuery.error) setError(formatApiError(flowsQuery.error));
setError(""); }, [flowsQuery.error]);
const schemaQuery = useQuery({
queryKey: ["input-schema", flowId],
queryFn: () => api.getInputSchema(flowId),
enabled: !!flowId,
retry: false,
});
const runsQuery = useQuery({
queryKey: ["runs", flowId],
queryFn: () => api.listRuns(flowId),
enabled: !!flowId,
});
const schema = schemaQuery.data ?? null;
const runs = runsQuery.data ?? [];
useEffect(() => {
setFormData({});
setResult(""); setResult("");
Promise.all([api.getInputSchema(flowId), api.listRuns(flowId)]) const e = schemaQuery.error;
.then(([s, r]) => { if (!e) {
setSchema(s); setError("");
setFormData({}); return;
setRuns(r); }
}) // Flows without a deployed version have no schema yet.
.catch((e: unknown) => { if (e instanceof ApiError && e.status === 404) {
// Flows without a deployed version have no schema yet. setError("Für diesen Flow ist noch keine Version deployed.");
if (e instanceof ApiError && e.status === 404) { } else {
setSchema(null); setError(formatApiError(e));
setRuns([]); }
setError("Für diesen Flow ist noch keine Version deployed."); }, [flowId, schemaQuery.error]);
} else fail(e); useEffect(() => {
}); if (runsQuery.error) setError(formatApiError(runsQuery.error));
}, [flowId, fail]); }, [runsQuery.error]);
async function onRun(input: unknown) { async function onRun(input: unknown) {
if (!flowId) return; if (!flowId) return;
@ -69,11 +79,21 @@ export default function WorkflowsPage() {
setError(""); setError("");
setResult(""); setResult("");
try { try {
const run = await api.runFlow(flowId, input); const run: Run = await api.runFlow(flowId, input);
setRuns((prev) => [run, ...prev]); setResult(
setResult(run.output?.result ?? run.output?.error ?? run.status); typeof run.output?.result === "string"
? run.output.result
: (run.output?.error ?? run.status),
);
notifications.show({
title: "Lauf gestartet",
message: `Status: ${run.status}`,
color: "green",
});
await queryClient.invalidateQueries({ queryKey: ["runs", flowId] });
await queryClient.invalidateQueries({ queryKey: ["all-runs"] });
} catch (e) { } catch (e) {
fail(e); setError(formatApiError(e));
} finally { } finally {
setBusy(false); setBusy(false);
} }
@ -85,9 +105,9 @@ export default function WorkflowsPage() {
Workflows Workflows
</Title> </Title>
{error && ( {error && (
<Alert color="red" icon={<IconAlertCircle size={18} />} mb="md"> <div style={{ marginBottom: 12 }}>
{error} <ErrorAlert message={error} />
</Alert> </div>
)} )}
<Select <Select
label="Flow" label="Flow"
@ -154,28 +174,7 @@ export default function WorkflowsPage() {
{runs.length === 0 ? ( {runs.length === 0 ? (
<Text c="dimmed">Noch keine Läufe.</Text> <Text c="dimmed">Noch keine Läufe.</Text>
) : ( ) : (
<Table striped highlightOnHover> <RunsTable runs={runs} />
<Table.Thead>
<Table.Tr>
<Table.Th>Status</Table.Th>
<Table.Th>Mandant</Table.Th>
<Table.Th>Ergebnis</Table.Th>
</Table.Tr>
</Table.Thead>
<Table.Tbody>
{runs.map((r) => (
<Table.Tr key={r.id}>
<Table.Td>
<StatusBadge status={r.status} />
</Table.Td>
<Table.Td>{r.tenant_id}</Table.Td>
<Table.Td>
<Code>{r.output?.result ?? r.output?.error ?? "–"}</Code>
</Table.Td>
</Table.Tr>
))}
</Table.Tbody>
</Table>
)} )}
</div> </div>
); );

7
frontend/src/utils.ts Normal file
View file

@ -0,0 +1,7 @@
/* Shared frontend helpers: error formatting (was scattered). */
import { ApiError } from "./api";
export function formatApiError(e: unknown): string {
if (e instanceof ApiError) return `${e.status}: ${e.message}`;
return String(e);
}